Closed
Bug 1435342
Opened 8 years ago
Closed 8 years ago
ESLint should ignore the tp5n dataset
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P1)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: mossop, Assigned: standard8)
References
Details
Attachments
(1 file)
I guess if you run talos locally then it extracts the tp5n dataset into testing/talos/talos/tests/tp5n. This path is ignored in .hgignore but not in .eslintignore so we attempt to lint all this lovely web content against our coding standards ultimately leading to an eslint crash!
We should be ignoring this directory in .eslintignore.
|
Assignee | |
Comment 2•8 years ago
|
||
I've filed bug 1435677 as I think that Talos shouldn't really be doing this. However, patch coming up for the ignore file.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: -- → P1
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8948327 [details]
Bug 1435342 - ESLint should ignore the tp5n dataset when extracted by Talos.
https://reviewboard.mozilla.org/r/217806/#review223686
Attachment #8948327 -
Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c587bb954008
ESLint should ignore the tp5n dataset when extracted by Talos. r=mossop
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•8 years ago
|
Product: Testing → Firefox Build System
|
||
Updated•7 years ago
|
Version: Version 3 → 3 Branch
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•