1435586 - gpu process + xrender = Crash in [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Darkspirit]

Summary: layers.gpu-process.enabled;true and gfx.xrender.enabled;true do not like each other. Both are preffed off by default.

-------------------------------------------------
Nightly 60 x64 20180203220331 de_DE @ Debian Testing (KDE, Radeon RX480).
main profile: gpu process, webrender.all, image.mem.shared;0, (gfx.xrender.enabled)

I just browsed a bit through the source code because I wanted to know how things look under the hood. bug 1406230 and bug 1418201 are my fields of interest.

I saw XRender and ShmImage in https://dxr.mozilla.org/mozilla-central/rev/5d6d869ec7becc99b8c3dc639fc52e49b1af3ef1/widget/gtk/WindowSurfaceProvider.cpp#91,
flipped gfx.xrender.enabled to true, restarted Nightly, got a small hang, saw the crash reports and disabled it again.

bp-15c7e20e-b7df-4e39-92d9-380940180204 04.02.18 04:47 [@ IPCError-content | PContentChild::RecvReinitRendering ]
bp-f5ffcb32-31be-4388-893c-b2d980180204 04.02.18 04:47 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-656b4db1-3673-45f7-b32c-c9d1b0180204 04.02.18 04:47 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-dbf9548b-f5d1-48b7-a25a-52d9e0180204 04.02.18 04:47 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-f646fa1e-ea84-49e6-8cb5-1950a0180204 04.02.18 04:46 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-ff1aa31d-9429-4da6-abdf-d22650180204 04.02.18 04:46 [@ IPCError-content | PContentChild::RecvReinitRendering ]
bp-a1acdc16-e89f-4a55-9458-e41850180204 04.02.18 04:46 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-e9edd8c5-feed-4bb8-88e3-759050180204 04.02.18 04:46 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-49e84d8f-3c4c-4b59-989c-5398b0180204 04.02.18 04:46 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-61f7ee2b-b306-401b-9df5-07d6b0180204 04.02.18 04:46 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-b6426f5a-18d4-43e8-833f-61fd50180204 04.02.18 04:46 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-60fb1339-a1bc-40fb-a41a-ee9e50180204 04.02.18 04:46 bug 1350566 [@ mozilla::ipc::MessageChannel::Send | mozilla::layers::PAPZCTreeManagerChild::SendUpdateZoomConstraints ]
bp-f3aaa915-3d6a-4479-83fd-47f480180204 04.02.18 04:46 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-62214d7d-e66c-4ae6-8907-23c620180204 04.02.18 04:46 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]


-------------------------------------------------
THE SAME WITHOUT WEBRENDER:

I got one [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ] per GPU process crash.
Yes, I learned from that and resetted layers.gpu-process.max_restarts.

HW_COMPOSITING	
blocked by default: Acceleration blocked by platform
OPENGL_COMPOSITING	
unavailable by default: Hardware compositing is disabled
GPU_PROCESS	
available by user: Enabled via layers.gpu-process.enabled
failed by runtime: GPU process disabled after 6 attempts
WEBRENDER	
opt-in by default: WebRender is an opt-in feature
unavailable by runtime: Hardware compositing is disabled
OMTP	
disabled by default: Disabled by default


(#0) Error	1, 1, 1024, 2
(#33) Error	Failed buffer for 0, 0, 1270, 200
(#34) Error	1, 1, 1024, 19
(#35) Error	Failed buffer for 40, 9, 224, 33
(#36) Error	1, 1, 1024, 20
(#37) Error	Failed buffer for 0, 0, 1270, 1400
(#38) Error	1, 1, 1024, 21
(#39) Error	Failed buffer for 0, 0, 1270, 200
(#40) Error	1, 1, 1024, 22
(#41) Error	Failed buffer for 40, 9, 224, 33
(#42) Error	Receive IPC close with reason=AbnormalShutdown
(#43) 	CP+[GFX1-]: Receive IPC close with reason=AbnormalShutdown
(#44) 	CP+[GFX1-]: ClientLayerManager::BeginTransaction with IPC channel down. GPU process may have died.
(#45) Error	Receive IPC close with reason=AbnormalShutdown
(#46) Error	GPU process disabled after 6 attempts
(#47) 	CP+[GFX1-]: Receive IPC close with reason=AbnormalShutdown


bp-17661928-be72-4a5a-9d58-adc580180204	04.02.18	05:09 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-ddeb4902-f88f-4083-bca6-8d52a0180204	04.02.18	05:09
bp-afbc0f7d-cdc9-4e99-abe0-4f1c60180204	04.02.18	05:09
bp-84197859-1226-4174-b0f3-fefbc0180204	04.02.18	05:09
bp-cbe462eb-8009-4c89-98f4-0f7f10180204	04.02.18	05:09
bp-2b1a0917-ca30-446d-92e6-2e7b30180204	04.02.18	05:09
bp-b5e45160-0402-480a-8d42-0b2bc0180204	04.02.18	05:09
bp-5d3a21a6-edb2-4690-9409-9fa200180204	04.02.18	05:09
bp-06f3fe1e-8c37-48ca-bf0d-efab80180204	04.02.18	05:09
bp-effa6460-1269-46ac-b26a-957280180204	04.02.18	05:09
bp-c32ea00d-f56a-4c69-bc32-964be0180204	04.02.18	05:09
bp-45e050ed-c04a-4f1e-a2b9-ce4910180204	04.02.18	05:09
bp-2debaf00-f080-4a4d-8315-b225d0180204	04.02.18	05:09
bp-346d3b52-d70e-4d5a-8b7d-5de9a0180204	04.02.18	05:09
bp-f55d2427-496b-486a-8d46-19c890180204	04.02.18	05:09
bp-487a6b37-eff2-424c-a19e-c16c50180204	04.02.18	05:09
bp-9230c47d-c459-45cb-8d7c-e8e510180204	04.02.18	05:09
bp-1da5d039-b3ad-4e9b-8b38-1edba0180204	04.02.18	05:09
bp-8124ee23-8aa0-426c-a18e-43abe0180204	04.02.18	05:09
bp-b9670e24-d711-452d-a26e-157390180204	04.02.18	05:08
bp-e25d2472-c0b4-4e37-b9c5-6e5c70180204	04.02.18	05:08
bp-daa95dba-8bdd-4eab-9631-eb8340180204	04.02.18	05:08
bp-4c4a75a1-8beb-4c54-b1c6-716d40180204	04.02.18	05:08
bp-6792270d-f5ef-4fa7-ad12-778d10180204	04.02.18	05:08
bp-799be1e3-4161-4eef-b3a2-eb6e60180204	04.02.18	05:08
bp-48a2e9c4-20d7-4683-9f4c-680a30180204	04.02.18	05:08
bp-f1d0d72f-26bb-4cc4-ba62-a544d0180204	04.02.18	05:08
bp-f4093739-5e9f-43a7-906f-3ccd10180204	04.02.18	05:08
bp-83d2a2dc-e599-48c5-81f7-bdfad0180204	04.02.18	05:08
bp-ebf3d95e-2560-4ce2-9d64-a26270180204	04.02.18	05:08
bp-c6e88e18-4dd9-4c4c-bc9c-8db5a0180204 04.02.18	05:08
bp-d8806c56-2b74-44a0-8499-e427d0180204	04.02.18	05:08
bp-f618a775-8127-4505-9a61-fc7fe0180204	04.02.18	05:08
bp-3c3c3e16-cedb-4bd0-9a2f-75e1a0180204	04.02.18	05:08
bp-d9a78c75-c3c5-4e1c-866b-48e950180204	04.02.18	05:08 [@ IPCError-content | PContentChild::RecvReinitRendering ]
bp-7ee0060a-f9db-4f23-adfd-820c60180204	04.02.18	05:08 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-a89d0446-8404-4b80-a9c1-0ed4d0180204	04.02.18	05:08
bp-f303f94d-72aa-480d-a0fe-54f080180204	04.02.18	05:08 bug 1350566 [@ mozilla::ipc::MessageChannel::Send | mozilla::layers::PAPZCTreeManagerChild::SendUpdateZoomConstraints ]
bp-5c3a3660-c579-46ee-a259-108330180204	04.02.18	05:08 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-44a6aec0-dae4-4442-a0be-7d9c60180204	04.02.18	05:08 bug 1350566 [@ mozilla::ipc::MessageChannel::Send | mozilla::layers::PAPZCTreeManagerChild::SendUpdateZoomConstraints ]
bp-1a9f8fef-f912-4ab7-9d5b-fa8210180204	04.02.18	05:08 [@ gfxPlatform::Init | mozilla::layers::X11DataTextureSourceBasic::Update ]
bp-67115f2e-7fe8-43cb-8e88-34b1b0180204	04.02.18	05:08
bp-a95064ee-36b8-4895-a24f-872270180204	04.02.18	05:08
bp-f3e95d05-0793-4e45-b3cc-da6510180204	04.02.18	05:08
bp-48ff6665-dbce-44be-b22f-9eb3e0180204	04.02.18	05:08
bp-c1af3a45-6bfd-4270-a7d9-133a80180204	04.02.18	05:08
bp-53dfe93a-9d1d-4230-a03b-8b7790180204	04.02.18	05:08

Comment 1

[Bas Schouten (:bas.schouten)]

This is an exotic configuration, so this isn't particularly important, but Nicolas may want to know about this.

Comment 2

[Darkspirit]

(bug 1180942)
I assume removing XRender will be anyway part of removing support for GTK2? (https://public.etherpad-mozilla.org/p/gfx-code-kill)

Comment 3

[Darkspirit]

I had totally forgotten about this bug. Crashes already happened before bug 1549965 landed.
Still reproducible when manually enabling xrender: bp-e0e9b6a1-6041-4b21-b000-338500190601
Solution: Disable gfx.xrender.enabled. It is disabled by default.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

When I get a moment, I will write a patch to switch uses of gfxPlatform::GetPlatform()->CreateDrawTargetForSurface to gfxPlatform::CreateDrawTargetForSurface. We don't actually need to initialize gfxPlatform to use this method.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1435586 - Use static gfxPlatform methods directly instead of requiring initialization.

gfxPlatform::GetSourceSurfaceForSurface and CreateDrawTargetForSurface
are both static methods that we sometimes use via the pattern
gfxPlatform::GetPlatform()->... This is problematic because this forces
gfxPlatform to be initialized in the process, and in the GPU process, we
don't support this. It should be safe to call these methods without
initializing gfxPlatform, so this patch removes the GetPlatform() call.

GetSourceSurfaceForSurface may end up initializing gfxPlatform anyways,
depending on whether or not a DrawTarget was given. This should not be a
concern for the crashes observed in bug 1435586.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b714a1a806490f4dfc31e91c9dc8172c35a121ac

Comment 7

[Marcia Knous [:marcia]]

This moved up to the #5 top crash on 69 nightly. Crashes started increasing in the 5-31 build.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/611d4651e151
Use static gfxPlatform methods directly instead of requiring initialization. r=kats

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/611d4651e151