1436014 - Create explicit unit-tests for in_changeset

Status: NEW

(Localization Infrastructure and Tools :: Fluent Migration, enhancement)

Description

[Axel Hecht [:Pike]]

Right now, the behavior of the internal function `in_changeset` in `MergeContext.merge_changeset` is done via testing the `merge_changeset` method.

I wonder if we can make the code a bit easier to read and to test if we'd move in_changeset to MergeContext, and used https://docs.python.org/2/library/functools.html#functools.partial to bind it to a path.

Then we could explicitly just test its own behaviour, and that'd make a bunch of tests a lot smaller, and probably easier to verify, too.

Comment 1

[Staś Małolepszy :stas]

Thanks for filing this. I had a similar though. I bothers me that in_changeset, despite its small size, has such an important role. I'll be happy to refactor this and have more tests!

Comment 2

[Axel Hecht [:Pike]]

Taking a stab at this.

Comment 3

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/fluent-migration/rev/e3791d22c931 laid the foundation here.
https://hg.mozilla.org/l10n/fluent-migration/rev/cb364e72d8d5 started the first couple of tests.

To actually fix this, we'll need to extend the real test coverage, and maybe also consider to remove obsolete merge_changeset tests. Unless we want to keep 'em as integration tests.

I don't have work lined up for this right now, so unassigning myself.