1436145 - Green up our JS dependencies for Firefox 60

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ed Lee :Mardak]

Let's try to keep our dependencies up to date each cycle. Steps:

1) green up dependencies that are already passing tests
- next-update --test './node_modules/.bin/npm-run-all test buildmc' --type dev
- maybe --without istanbul-instrumenter-loader,karma-sinon,loader-utils ?

2) fix up dependencies that require changes as separate commits
- non-dev dependencies probably require vendor/ file changes

3) create PR with greening up commits
- good to link to major version changes release tags
-- e.g., https://github.com/mochajs/mocha/releases/tag/v5.0.0

4) file new bug for next cycle

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I like the template!

(In reply to Ed Lee :Mardak from comment #0)
> Let's try to keep our dependencies up to date each cycle. Steps:
> 
> 1) green up dependencies that are already passing tests
> - next-update --test './node_modules/.bin/npm-run-all test buildmc' --type
> dev

Maybe also do:

npm run mochitest

> - maybe --without istanbul-instrumenter-loader,karma-sinon,loader-utils ?
> 

Why these three?

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3973

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/391f03042cdd668cb9af81c19cd037f47522dac5
Merge pull request #3973 from Mardak/b1436145-green

Fix Bug 1436145 - Green up our JS dependencies for Firefox 60

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/22f78ddb5720