1436490 - Move more data related functions into calDataUtils.jsm

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Using the script from attachment 8942466 [details] [diff] [review] and the following migrations:

cal.binarySearch                     -> cal.data.binarySearch
cal.binaryInsertNode                 -> cal.data.binaryInsertNode
cal.binaryInsert                     -> cal.data.binaryInsert
cal.compareObjects                   -> cal.data.compareObjects
cal.compareArrays                    -> cal.data.compareArrays

I'd like to move window functions out of calUtils.js(m). Again, there will be some manual changes in one patch, and one with all automatic changes. This goes after bug 1436488 in patch order.

Comment 1

[Martin Schröder [:mschroeder]]

The function compareArrays() seems to be unused.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Manual Changes - v1

Thanks Martin, I've removed that one.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Automatic Changes - v1

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0a2e7d1cf4dbbb9cc445adf9086fb84557d11fb0

Looks pretty much like comm-central right now.

Comment 5

[[:MakeMyDay]]

Comment on attachment 8949173 [details] [diff] [review]
Manual Changes - v1

Review of attachment 8949173 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Please push both the automatic and manual patches, after the bug mentioned in comment 0.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e2c686325a54
Move more data related functions into calDataUtils.jsm  - manual changes. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/afe12c107559
Move more data related functions into calDataUtils.jsm  - automatic changes. r=MakeMyDay