Move more data related functions into calDataUtils.jsm

RESOLVED FIXED in 6.2

Status

defect
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

Lightning 6.2
Dependency tree / graph

Details

Attachments

(2 attachments)

Using the script from attachment 8942466 [details] [diff] [review] and the following migrations:

cal.binarySearch                     -> cal.data.binarySearch
cal.binaryInsertNode                 -> cal.data.binaryInsertNode
cal.binaryInsert                     -> cal.data.binaryInsert
cal.compareObjects                   -> cal.data.compareObjects
cal.compareArrays                    -> cal.data.compareArrays

I'd like to move window functions out of calUtils.js(m). Again, there will be some manual changes in one patch, and one with all automatic changes. This goes after bug 1436488 in patch order.
The function compareArrays() seems to be unused.
Posted patch Manual Changes - v1 β€” β€” Splinter Review
Thanks Martin, I've removed that one.
Attachment #8949173 - Flags: review?(makemyday)
Comment on attachment 8949173 [details] [diff] [review]
Manual Changes - v1

Review of attachment 8949173 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me
Attachment #8949173 - Flags: review?(makemyday) → review+
Please push both the automatic and manual patches, after the bug mentioned in comment 0.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e2c686325a54
Move more data related functions into calDataUtils.jsm  - manual changes. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/afe12c107559
Move more data related functions into calDataUtils.jsm  - automatic changes. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.2
You need to log in before you can comment on or make changes to this bug.