Move more data related functions into calDataUtils.jsm

RESOLVED FIXED in 6.2

Status

Calendar
Internal Components
RESOLVED FIXED
16 days ago
10 days ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

(Blocks: 1 bug)

Lightning 6.2

Details

Attachments

(2 attachments)

(Assignee)

Description

16 days ago
Using the script from attachment 8942466 [details] [diff] [review] and the following migrations:

cal.binarySearch                     -> cal.data.binarySearch
cal.binaryInsertNode                 -> cal.data.binaryInsertNode
cal.binaryInsert                     -> cal.data.binaryInsert
cal.compareObjects                   -> cal.data.compareObjects
cal.compareArrays                    -> cal.data.compareArrays

I'd like to move window functions out of calUtils.js(m). Again, there will be some manual changes in one patch, and one with all automatic changes. This goes after bug 1436488 in patch order.
The function compareArrays() seems to be unused.
(Assignee)

Comment 2

16 days ago
Created attachment 8949173 [details] [diff] [review]
Manual Changes - v1

Thanks Martin, I've removed that one.
Attachment #8949173 - Flags: review?(makemyday)
(Assignee)

Comment 3

16 days ago
Created attachment 8949174 [details] [diff] [review]
Automatic Changes - v1

Comment 5

11 days ago
Comment on attachment 8949173 [details] [diff] [review]
Manual Changes - v1

Review of attachment 8949173 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me
Attachment #8949173 - Flags: review?(makemyday) → review+
(Assignee)

Comment 6

10 days ago
Please push both the automatic and manual patches, after the bug mentioned in comment 0.
Keywords: checkin-needed

Comment 7

10 days ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e2c686325a54
Move more data related functions into calDataUtils.jsm  - manual changes. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/afe12c107559
Move more data related functions into calDataUtils.jsm  - automatic changes. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Last Resolved: 10 days ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

10 days ago
Target Milestone: --- → 6.2
You need to log in before you can comment on or make changes to this bug.