1436491 - Move category related functions into calCategoryUtils.jsm

Status: RESOLVED FIXED

(Calendar :: Internal Components, enhancement)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Using the script from attachment 8942466 [details] [diff] [review] and the following migrations:

cal.setupDefaultCategories           -> cal.category.setupDefaultCategories
cal.getPrefCategoriesArray           -> cal.category.fromPrefs
cal.setPrefCategoriesFromArray       -> cal.category.toPrefs
cal.categoriesStringToArray          -> cal.category.stringToArray
cal.categoriesArrayToString          -> cal.category.arrayToString

I'd like to move window functions out of calUtils.js(m). Again, there will be some manual changes in one patch, and one with all automatic changes. This goes after bug 1436490 in patch order.

Comment 1

[Martin Schröder [:mschroeder]]

The function setPrefCategoriesFromArray() seems to be unused.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Manual Changes - v1

Removing toPrefs while there is fromPrefs makes me a bit uncomfortable, but there is indeed no further use so I'll remove it.

In case you are wondering about the categories.js removal, the code has moved into the category retrieval function where it should be.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Automatic Changes - v1

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Manual Changes - v2

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0a2e7d1cf4dbbb9cc445adf9086fb84557d11fb0

Looks pretty much like comm-central right now.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Manual Changes - v3

This is the patch I used on the try run.

Comment 7

[[:MakeMyDay]]

Comment on attachment 8949337 [details] [diff] [review]
Manual Changes - v3

Review of attachment 8949337 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, r=me

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Please push both the automatic and manual patches, after the bug mentioned in comment 0.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3de68de8bf72
Move category related functions into calCategoryUtils.jsm - manual changes. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/79de47fa45ed
Move category related functions into calCategoryUtils.jsm - automatic changes. r=MakeMyDay