Closed Bug 1436491 Opened 2 years ago Closed 2 years ago
Move category related functions into cal
Category Utils .jsm
Using the script from attachment 8942466 [details] [diff] [review] and the following migrations: cal.setupDefaultCategories -> cal.category.setupDefaultCategories cal.getPrefCategoriesArray -> cal.category.fromPrefs cal.setPrefCategoriesFromArray -> cal.category.toPrefs cal.categoriesStringToArray -> cal.category.stringToArray cal.categoriesArrayToString -> cal.category.arrayToString I'd like to move window functions out of calUtils.js(m). Again, there will be some manual changes in one patch, and one with all automatic changes. This goes after bug 1436490 in patch order.
The function setPrefCategoriesFromArray() seems to be unused.
Removing toPrefs while there is fromPrefs makes me a bit uncomfortable, but there is indeed no further use so I'll remove it. In case you are wondering about the categories.js removal, the code has moved into the category retrieval function where it should be.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0a2e7d1cf4dbbb9cc445adf9086fb84557d11fb0 Looks pretty much like comm-central right now.
This is the patch I used on the try run.
Comment on attachment 8949337 [details] [diff] [review] Manual Changes - v3 Review of attachment 8949337 [details] [diff] [review]: ----------------------------------------------------------------- looks good, r=me
Attachment #8949337 - Flags: review?(makemyday) → review+
Please push both the automatic and manual patches, after the bug mentioned in comment 0.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/3de68de8bf72 Move category related functions into calCategoryUtils.jsm - manual changes. r=MakeMyDay https://hg.mozilla.org/comm-central/rev/79de47fa45ed Move category related functions into calCategoryUtils.jsm - automatic changes. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.