Closed Bug 1436557 Opened 2 years ago Closed 2 years ago

Move calOperationGroup to calDataUtils.jsm

Categories

(Calendar :: Internal Components, defect)

Lightning 6.2
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

Not sure why I didn't fold this when I created the original patches, but here is another one for calDataUtils. In patch order, this is after bug 1436491.

I went ahead and included the automatic changes in one patch since there are not really a lot.
Attached patch Fix - v1 β€” β€” Splinter Review
Not doing a migration here, this seems to be used pretty much internally.
Attachment #8949199 - Flags: review?(makemyday)
Comment on attachment 8949199 [details] [diff] [review]
Fix - v1

Review of attachment 8949199 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me
Attachment #8949199 - Flags: review?(makemyday) → review+
Please push both the automatic and manual patches, after the bug mentioned in comment 0.
Keywords: checkin-needed
(In reply to Philipp Kewisch [:Fallen]  from comment #4)
> Please push both the automatic and manual patches, after the bug mentioned
> in comment 0.
Nice copy/paste job, but there's only one patch to land here. I also checked
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0a2e7d1cf4dbbb9cc445adf9086fb84557d11fb0
:-)
Attachment #8949199 - Attachment filename: datamanual.diff → datamanual2.diff
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/38e20522425a
Move calOperationGroup to calDataUtils.jsm. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.2
Adding a unit test for this in bug 1433802.
You need to log in before you can comment on or make changes to this bug.