1436557 - Move calOperationGroup to calDataUtils.jsm

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Not sure why I didn't fold this when I created the original patches, but here is another one for calDataUtils. In patch order, this is after bug 1436491.

I went ahead and included the automatic changes in one patch since there are not really a lot.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Not doing a migration here, this seems to be used pretty much internally.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0a2e7d1cf4dbbb9cc445adf9086fb84557d11fb0

Looks pretty much like comm-central right now.

Comment 3

[[:MakeMyDay]]

Comment on attachment 8949199 [details] [diff] [review]
Fix - v1

Review of attachment 8949199 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Please push both the automatic and manual patches, after the bug mentioned in comment 0.

Comment 5

[Jorg K (CEST = GMT+2)]

(In reply to Philipp Kewisch [:Fallen]  from comment #4)
> Please push both the automatic and manual patches, after the bug mentioned
> in comment 0.
Nice copy/paste job, but there's only one patch to land here. I also checked
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0a2e7d1cf4dbbb9cc445adf9086fb84557d11fb0
:-)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/38e20522425a
Move calOperationGroup to calDataUtils.jsm. r=MakeMyDay

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Adding a unit test for this in bug 1433802.