1436662 - `uninstall/helper.exe` is no longer translated

Status: VERIFIED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Tom Prince [:tomprince]]

The `uninstall/helper.exe` binary in Firefox mar's and exe installers, and in Thunderbird mar's is no longer translated. I think this is probably fallout from Bug 1385227.

It seems that Thunderbird's exe installers do have the translations (checked with `de`).

Comment 1

[Tom Prince [:tomprince]]

Wayne, this is what caused the update-verify failures for TB 59.0b1-build1, as it caught the difference between the translated and untranslated helper.exe (at least for the one u-v build I checked; all of them probably failed just on helper.exe)

Comment 2

[Axel Hecht [:Pike]]

I'm not convinced that this is fall-out from the installers-rearch.

Here's what I found out locally so far:

We do build a localized helpers.exe, I think it's in the right place in dist, but it's not packaged into the zip (also then probably not the .exe):

Fuchsia:obj-firefox-win-repack axelhecht$ ls -al `find . -name helper.exe`
-rwxr-xr-x  1 axelhecht  wheel  889757 Feb  8 15:47 ./browser/installer/windows/l10ngen/helper.exe
-rwxr-xr-x  1 axelhecht  wheel  889757 Feb  8 15:47 ./dist/l10n-stage/firefox/uninstall/helper.exe
-rwxr-xr-x  1 axelhecht  wheel  895120 Feb  8 12:14 ./dist/unpacked-installer/firefox/uninstall/helper.exe
Fuchsia:obj-firefox-win-repack axelhecht$ unzip -l dist/firefox-60.0a1.de.win32.zip |grep helper.exe
   895120  02-08-2018 12:14   firefox/uninstall/helper.exe

As you can see, the helper.exe in l10n-stage is the one we've built, and the local files there have German strings. But the one in the packaged de zip is the one fro the unpacked-installer, i.e., the en-US one.

I haven't found a way to actually inspect what's in helper.exe UI-string-wise. If someone has tips, it'd be good to do an explicit regression range search.

Comment 3

[Tom Prince [:tomprince]]

I discovered this running `strings -T pei-i386 -e l complete/uninstall/helper.exe` on the unpacked binary.

Comment 4

[Axel Hecht [:Pike]]

OK, figured out what's going on. And I confirmed that it's a regression from the installers patch, sorry for putting doubt in that.

We build the uninstaller/helper.exe as side-effect of building the setup.exe, https://dxr.mozilla.org/mozilla-central/rev/0ac953fcddf10132eaecdb753d72b2ba5a43c32a/toolkit/mozapps/installer/windows/nsis/makensis.mk#61.

We moved that step from "somewhere" into the windows installer packaging, which happens after the zip and mar package now.

Which means that the uninstaller is localized in the .exe installer, but not in the mar or zip.

I'll take a look at this.

Comment 5

[Justin Wood (:Callek)]

[Tracking Requested - why for this release]: This is affecting Firefox 59, and is resulting in different binaries installed for localized windows installers vs localized windows .zip's and updates.

The end result is untranslated dialogs in the uninstall process.

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Axel Hecht [:Pike] from comment #4)
> OK, figured out what's going on. And I confirmed that it's a regression from
> the installers patch, sorry for putting doubt in that.
> 
> We build the uninstaller/helper.exe as side-effect of building the
> setup.exe,
> https://dxr.mozilla.org/mozilla-central/rev/
> 0ac953fcddf10132eaecdb753d72b2ba5a43c32a/toolkit/mozapps/installer/windows/
> nsis/makensis.mk#61.
> 
> We moved that step from "somewhere" into the windows installer packaging,
> which happens after the zip and mar package now.
> 
> Which means that the uninstaller is localized in the .exe installer, but not
> in the mar or zip.
> 
> I'll take a look at this.

Are you sure they don't match across all 3 packages? I just downloaded the "ach" MAR, installer, and zip from 59.0b8 and found:
9dc03bd48c9f5aadedb468f4f2c35a857aea604d644eb713789121c34f5373e3aee470740b5f7566cf24f5c6508e459ffc01e8abfd2311aefe1c7983d33681ea  installer/core/uninstall/helper.exe
9dc03bd48c9f5aadedb468f4f2c35a857aea604d644eb713789121c34f5373e3aee470740b5f7566cf24f5c6508e459ffc01e8abfd2311aefe1c7983d33681ea  mar/uninstall/helper.exe
9dc03bd48c9f5aadedb468f4f2c35a857aea604d644eb713789121c34f5373e3aee470740b5f7566cf24f5c6508e459ffc01e8abfd2311aefe1c7983d33681ea  zip/firefox/uninstall/helper.exe

Comment 7

[Axel Hecht [:Pike]]

Turns out that I can't reproduce the problem, which makes it pretty pointless for me to try to fix it. From the logs, and my local tests, the behavior should be different than on beta and nightly, and I can't get to anything close to production build environments. Unassigning.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Tom, are you still able to reproduce this?

Comment 9

[Justin Wood (:Callek)]

:Pike, per our conversation yesterday it sounds like you still plan to look into this bug more?

Comment 10

[Axel Hecht [:Pike]]

I look at this as something of low to medium impact, and coming with a horrible engineering productivity for me.

I'll probably throw a patch at try every now and then, but this isn't a bug that keeps me up at night.

Here's why:

If the uninstaller isn't localized, that's unfortunate, but also, that's at a point where we probably won't keep the user through great UX to begin with.
Any idea I'd have builds on the assumption that the uninstaller packaged in the installer is localized, which doesn't seem to be the case. So the likelyhood of me just fixing this isn't really big.

And my productivity on windows is abysmal. Which makes other bugs of similar impact be higher on my personal list.

Comment 11

[Tom Prince [:tomprince]]

Inspecting the latest firefox nightly (win64 de) installer, the included uninstaller does appear to be untranlated. (This is inspecting the file on linux, not running it).

Comment 12

[Ryan VanderMeulen [:RyanVM]]

This sounds pretty crappy, but I'm inclined to agree that it's not something we need to track for 59 at this point either. I'd still accept a low-risk fix for this if one materializes in the near future, though.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Jeff, based on comment 0, this is a recent regression in 59. I hope this is an easy one to fix. Could you please help find an assignee for this bug? As Ryan said, we'd be happy to take a low risk fix in 59.

Comment 14

[Jeff Beatty [:gueroJeff]]

(In reply to Ritu Kothari (:ritu) from comment #13)
> Hi Jeff, based on comment 0, this is a recent regression in 59. I hope this
> is an easy one to fix. Could you please help find an assignee for this bug?
> As Ryan said, we'd be happy to take a low risk fix in 59.

Zibi would be the closest person to being able to investigate this on a Friday afternoon. Zibi, do you have some remaining cycles to look into it?

I also agree that it isn't urgent enough to need tracking for 59.

Comment 15

[Axel Hecht [:Pike]]

FWIW, I managed to push https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d530013b73605c5a3ebe158067145211b2f6911 to try on my way to a workweek on Monday, but I didn't have time yet to investigate the results.

Comment 16

[Wayne Mery (:wsmwk)]

(In reply to Axel Hecht [:Pike] from comment #15)
> FWIW, I managed to push
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=4d530013b73605c5a3ebe158067145211b2f6911 to try on my
> way to a workweek on Monday, but I didn't have time yet to investigate the
> results.

all green

Comment 17

[Tom Prince [:tomprince]]

(In reply to Axel Hecht [:Pike] from comment #15)
> FWIW, I managed to push
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d530013b73605c5a3ebe158067145211b2f6911 to try on my
> way to a workweek on Monday, but I didn't have time yet to investigate the
> results.

That doesn't appear to work (based on running strings on the de artifacts from https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d530013b73605c5a3ebe158067145211b2f6911&selectedJob=162983042)

Comment 18

[Tom Prince [:tomprince]]

https://hg.mozilla.org/try/rev/d64ec4b48173ae59bd0b507dcdaf70e0ecb6487b maybe?

Comment 19

[Axel Hecht [:Pike]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ceeca714c90c133412aa771f1df8268c31f06bc&selectedJob=165307361 failed to generate the en-US build with 

21:16:09     INFO -  mkdir instgen
21:16:09     INFO -  mozmake.EXE[6]: Leaving directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:09     INFO -  mozmake.EXE[6]: Entering directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:09     INFO -  z:/build/build/src/obj-firefox/_virtualenv/Scripts/python.exe z:/build/build/src/config/nsinstall.py -t z:/build/build/src/browser/installer/windows/app.tag z:/build/build/src/browser/installer/windows/nsis/installer.nsi z:/build/build/src/browser/installer/windows/nsis/uninstaller.nsi z:/build/build/src/browser/installer/windows/nsis/stub.nsi z:/build/build/src/browser/installer/windows/nsis/shared.nsh z:/build/build/src/browser/installer/windows/stub.tag z:/build/build/src/browser/installer/windows/nsis/maintenanceservice_installer.nsi instgen
21:16:09     INFO -  mozmake.EXE[6]: Leaving directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:09     INFO -  mozmake.EXE[6]: Entering directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:09     INFO -  z:/build/build/src/obj-firefox/_virtualenv/Scripts/python.exe z:/build/build/src/config/nsinstall.py -t z:/build/build/src/browser/branding/nightly/bgstub.jpg z:/build/build/src/browser/branding/nightly/bgstub_2x.jpg z:/build/build/src/browser/branding/nightly/branding.nsi z:/build/build/src/browser/branding/nightly/firefox64.ico z:/build/build/src/browser/branding/nightly/wizHeader.bmp z:/build/build/src/browser/branding/nightly/wizHeaderRTL.bmp z:/build/build/src/browser/branding/nightly/wizWatermark.bmp instgen
21:16:09     INFO -  mozmake.EXE[6]: Leaving directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:09     INFO -  mozmake.EXE[6]: Entering directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:09     INFO -  z:/build/build/src/obj-firefox/_virtualenv/Scripts/python.exe -m mozbuild.action.preprocessor -Fsubstitution -DNDEBUG=1 -DTRIMMED=1 -DAPP_VERSION=60.0a1 -DMOZ_APP_NAME=firefox '-DMOZ_APP_DISPLAYNAME=Firefox Nightly' -DMOZILLA_VERSION=60.0a1 -DA11Y_LOG=1 -DACCESSIBILITY=1 -DBUILD_CTYPES=1 -DCROSS_COMPILE='' -DEARLY_BETA_OR_EARLIER=1 -DENABLE_INTL_API=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DENABLE_TESTS=1 -DEXPOSE_INTL_API=1 -DFIREFOX_VERSION=60.0a1 -DFORCE_PR_LOG=1 -DGTEST_HAS_RTTI=0 -DHAVE_FORCEINLINE=1 -DHAVE_FT_BITMAP_SIZE_Y_PPEM=1 -DHAVE_FT_GLYPHSLOT_EMBOLDEN=1 -DHAVE_FT_LOAD_SFNT_TABLE=1 -DHAVE_INTTYPES_H=1 -DHAVE_IO_H=1 -DHAVE_ISATTY=1 -DHAVE_LOCALECONV=1 -DHAVE_MALLOC_H=1 -DHAVE_SEH_EXCEPTIONS=1 -DHAVE_STDINT_H=1 -DHAVE_UINT64_T=1 -DJS_CODEGEN_X86=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DJS_NUNBOX32=1 -DMALLOC_H='<malloc.h>' -DMALLOC_USABLE_SIZE_CONST_PTR=const -DMOZILLA_OFFICIAL=1 -DMOZILLA_UAVERSION='"60.0"' -DMOZILLA_VERSION='"60.0a1"' -DMOZILLA_VERSION_U=60.0a1 -DMOZ_ADDON_SIGNING=1 -DMOZ_ALLOW_LEGACY_EXTENSIONS=1 -DMOZ_APP_UA_NAME='""' -DMOZ_APP_UA_VERSION='"60.0a1"' -DMOZ_AV1=1 -DMOZ_BUILD_APP=browser -DMOZ_BUILD_WEBRENDER=1 -DMOZ_BUNDLED_FONTS=1 -DMOZ_CONTENT_SANDBOX=1 -DMOZ_CRASHREPORTER=1 -DMOZ_CRASHREPORTER_INJECTOR=1 -DMOZ_DATA_REPORTING=1 -DMOZ_DISTRIBUTION_ID='"org.mozilla"' -DMOZ_DLL_SUFFIX='".dll"' -DMOZ_ENABLE_SIGNMAR=1 -DMOZ_ENABLE_SKIA=1 -DMOZ_ENABLE_SKIA_PDF=1 -DMOZ_ENABLE_SKIA_PDF_SFNTLY=1 -DMOZ_FEEDS=1 -DMOZ_FFVPX=1 -DMOZ_FMP4=1 -DMOZ_GECKO_PROFILER=1 -DMOZ_GMP_SANDBOX=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_LIBAV_FFT=1 -DMOZ_LOGGING=1 -DMOZ_MACBUNDLE_ID=org.mozilla.nightly -DMOZ_MAINTENANCE_SERVICE=1 -DMOZ_MEMORY=1 -DMOZ_MSVC_STL_WRAP_RAISE=1 -DMOZ_OLD_STYLE=1 -DMOZ_PEERCONNECTION=1 -DMOZ_PHOENIX=1 -DMOZ_PLACES=1 -DMOZ_PROFILING=1 -DMOZ_RAW=1 -DMOZ_REPLACE_MALLOC=1 -DMOZ_RUST_SIMD=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_SANDBOX=1 -DMOZ_SCTP=1 -DMOZ_SERVICES_HEALTHREPORT=1 -DMOZ_SRTP=1 -DMOZ_STATIC_JS=1 -DMOZ_STYLO=1 -DMOZ_STYLO_ENABLE=1 -DMOZ_TELEMETRY_ON_BY_DEFAULT=1 -DMOZ_TELEMETRY_REPORTING=1 -DMOZ_TREE_CAIRO=1 -DMOZ_TREE_FREETYPE=1 -DMOZ_TREE_PIXMAN=1 -DMOZ_UPDATER=1 -DMOZ_UPDATE_CHANNEL=nightly-try -DMOZ_USER_DIR='"Mozilla"' -DMOZ_VERIFY_MAR_SIGNATURE=1 -DMOZ_VORBIS=1 -DMOZ_VPX_NO_MEM_REPORTING=1 -DMOZ_VTUNE=1 -DMOZ_WEBM_ENCODER=1 -DMOZ_WEBRTC=1 -DMOZ_WEBRTC_ASSERT_ALWAYS=1 -DMOZ_WEBRTC_SIGNALING=1 -DMOZ_WEBSPEECH=1 -DMOZ_WEBSPEECH_TEST_BACKEND=1 -DMOZ_WMF=1 -DMOZ_XUL=1 -DMSVC_HAS_DIA_SDK=1 -DNIGHTLY_BUILD=1 -DNOMINMAX=1 -DNO_NSPR_10_SUPPORT=1 -DNS_ENABLE_TSF=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DSTATIC_JS_API=1 -DSTDC_HEADERS=1 -DTARGET_XPCOM_ABI='"x86-msvc"' -DUSE_SKIA=1 -DUSE_SKIA_GPU=1 -DU_STATIC_IMPLEMENTATION=1 -DU_USING_ICU_NAMESPACE=0 -DVPX_X86_ASM=1 -DWIN32=1 -DWIN32_LEAN_AND_MEAN=1 -DWINVER=0x601 -DXP_WIN=1 -DXP_WIN32=1 -DX_DISPLAY_MISSING=1 -D_CRT_NONSTDC_NO_WARNINGS=1 -D_CRT_SECURE_NO_WARNINGS=1 -D_USE_MATH_DEFINES=1 -D_WIN32_IE=0x0800 -D_WIN32_WINNT=0x601 -D_WINDOWS=1 -D_X86_=1 -DAB_CD=en-US z:/build/build/src/browser/installer/windows/nsis/defines.nsi.in -o instgen/defines.nsi
21:16:09     INFO -  mozmake.EXE[6]: Leaving directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:10     INFO -  mozmake.EXE[6]: Entering directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:10     INFO -  z:/build/build/src/obj-firefox/_virtualenv/Scripts/python.exe z:/build/build/src/toolkit/mozapps/installer/windows/nsis/preprocess-locale.py \
21:16:10     INFO -    --preprocess-locale z:/build/build/src \
21:16:10     INFO -    z:/build/build/src/browser/locales/en-US/installer en-US instgen
21:16:10     INFO -  mozmake.EXE[6]: Leaving directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:10     INFO -  mozmake.EXE[6]: Entering directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:10     INFO -  cd instgen && c:/mozilla-build/nsis-3.01/makensis-3.01.exe  uninstaller.nsi
21:16:10     INFO -  Processing config: c:\mozilla-build\nsis-3.01\nsisconf.nsh
21:16:10     INFO -  Processing script file: "uninstaller.nsi" (ACP)
21:16:10     INFO -  !include: could not find: "common.nsh"
21:16:10     INFO -  Error in script "uninstaller.nsi" on line 59 -- aborting creation process
21:16:10     INFO -  z:/build/build/src/toolkit/mozapps/installer/windows/nsis/makensis.mk:57: recipe for target 'instgen/helper.exe' failed
21:16:10     INFO -  mozmake.EXE[6]: *** [instgen/helper.exe] Error 1
21:16:10     INFO -  mozmake.EXE[6]: Leaving directory 'z:/build/build/src/obj-firefox/browser/installer/windows'
21:16:10     INFO -  Makefile:20: recipe for target 'libs' failed
21:16:10     INFO -  mozmake.EXE[5]: *** [libs] Error 2
21:16:10     INFO -  z:/build/build/src/config/recurse.mk:100: recipe for target 'browser/libs' failed
21:16:10     INFO -  mozmake.EXE[4]: *** [browser/libs] Error 2
21:16:10     INFO -  z:/build/build/src/config/recurse.mk:32: recipe for target 'libs' failed
21:16:10     INFO -  mozmake.EXE[3]: *** [libs] Error 2
21:16:10     INFO -  z:/build/build/src/config/rules.mk:434: recipe for target 'default' failed
21:16:10     INFO -  mozmake.EXE[2]: *** [default] Error 2
21:16:10     INFO -  Makefile:235: recipe for target 'profiledbuild' failed
21:16:10     INFO -  mozmake.EXE[1]: *** [profiledbuild] Error 2
21:16:10     INFO -  client.mk:168: recipe for target 'build' failed
21:16:10     INFO -  mozmake.EXE: *** [build] Error 2
21:16:10     INFO -  117 compiler warnings present.
21:16:10    ERROR - Return code: 2
21:16:10  WARNING - setting return code to 2
21:16:10    FATAL - 'mach build' did not run successfully. Please check log for errors.
21:16:10    FATAL - Running post_fatal callback...

Comment 20

[Phabricator Automation]

Attachment: Bug 1436662: Translate uninstaller again.

Comment 21

[Tom Prince [:tomprince]]

The attached patch seems to fix the issue, and incidentally also fixes Bug 1382766.

It needs some cleanup, and work to make it compatible with Thunderbird and Seamonkey.

Comment 22

[Tom Prince [:tomprince]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=85ee21ffea59ef6e959e5133b617e7c92edce6ad

Comment 23

[Axel Hecht [:Pike]]

Thanks for continuing to hack on this. That looks promising from the end-result, I checked both the target.zip and the target.installer.exe, and the uninstall/helper.exe has German strings for the german artifacts.

Comment 24

[Phabricator Automation]

Comment on attachment 8955745 [details]
Bug 1436662: Translate uninstaller again.

Axel Hecht [:Pike] has approved the revision.

https://phabricator.services.mozilla.com/D672

Comment 25

[Axel Hecht [:Pike]]

To copy my comment from phabricator, this looks good to me from an l10n pov, but I didn't do an actual build review, I defer to a build peer for that.

Comment 27

[Michael Shal [:mshal]]

Comment on attachment 8955745 [details]
Bug 1436662: Translate uninstaller again.

Clearing r?Build until the issue in phabricator is resolved.

Comment 28

[Jim Mathies [:jimm]]

owned, active dev -> P1

Comment 29

[Phabricator Automation]

Comment on attachment 8955745 [details]
Bug 1436662: Translate uninstaller again.

Flag set by Axel Hecht [:Pike] is no longer active.

https://phabricator.services.mozilla.com/D672

Comment 30

[Phabricator Automation]

Attachment: Bug 1436662: Remove `installer` MOZ_AUTOMATION stage.

Comment 32

[Phabricator Automation]

Comment on attachment 8965736 [details]
Bug 1436662: Remove `installer` MOZ_AUTOMATION stage.

Michael Shal [:mshal] has approved the revision.

https://phabricator.services.mozilla.com/D864

Comment 33

[Phabricator Automation]

Comment on attachment 8955745 [details]
Bug 1436662: Translate uninstaller again.

Axel Hecht [:Pike] has approved the revision.
Michael Shal [:mshal] has approved the revision.

https://phabricator.services.mozilla.com/D672

Comment 34

[Phabricator Automation]

Comment on attachment 8955745 [details]
Bug 1436662: Translate uninstaller again.

Flag set by Axel Hecht [:Pike] is no longer active.
Flag set by Michael Shal [:mshal] is no longer active.

https://phabricator.services.mozilla.com/D672

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6bf22099e21
Package translated uninstaller; r=pike,mshal
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcb756834abb
Remove `installer` MOZ_AUTOMATION stage; r=mshal

Comment 36

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (bug 1436662) for build bustages on /installer/windows.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/e1eb6d06184bfc9635a8696c8d7a621799c17e1e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=fcb756834abbdbe0ae6e59a8cfdf39024f50a226&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&filter-resultStatus=superseded&selectedJob=174126093

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=174126093&repo=mozilla-inbound&lineNumber=60705

[task 2018-04-17T16:19:25.454Z] 16:19:25     INFO -  sent 177536602 bytes  received 1348 bytes  118358633.33 bytes/sec
[task 2018-04-17T16:19:25.454Z] 16:19:25     INFO -  total size is 177509913  speedup is 1.00
[task 2018-04-17T16:19:25.454Z] 16:19:25     INFO -  make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2018-04-17T16:19:30.689Z] 16:19:30     INFO -  make[6]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2018-04-17T16:19:30.689Z] 16:19:30     INFO -  /builds/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python /builds/worker/workspace/build/src/toolkit/mozapps/installer/l10n-repack.py '/builds/worker/workspace/build/src/obj-firefox/dist/l10n-stage/firefox' ../../dist/xpi-stage/locale-x-test \
[task 2018-04-17T16:19:30.689Z] 16:19:30     INFO -  	 \
[task 2018-04-17T16:19:30.689Z] 16:19:30     INFO -  make[6]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2018-04-17T16:19:30.689Z] 16:19:30     INFO -  /usr/bin/make -C ../installer/windows CONFIG_DIR=l10ngen l10ngen/helper.exe
[task 2018-04-17T16:19:30.689Z] 16:19:30     INFO -  make[7]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2018-04-17T16:19:30.689Z] 16:19:30     INFO -  make[7]: *** ../installer/windows: No such file or directory.  Stop.
[task 2018-04-17T16:19:30.689Z] 16:19:30     INFO -  make[7]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2018-04-17T16:19:30.689Z] 16:19:30     INFO -  /builds/worker/workspace/build/src/toolkit/locales/l10n.mk:116: recipe for target 'repackage-zip' failed
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  make[6]: *** [repackage-zip] Error 2
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  /builds/worker/workspace/build/src/toolkit/locales/l10n.mk:154: recipe for target 'repackage-zip-x-test' failed
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  make[5]: *** [repackage-zip-x-test] Error 2
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  Makefile:128: recipe for target 'installers-x-test' failed
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  make[4]: *** [installers-x-test] Error 2
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  Makefile:149: recipe for target 'l10n-check' failed
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  make[3]: *** [l10n-check] Error 2
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  /builds/worker/workspace/build/src/browser/build.mk:36: recipe for target 'l10n-check' failed
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  make[2]: *** [l10n-check] Error 2
[task 2018-04-17T16:19:30.690Z] 16:19:30     INFO -  /builds/worker/workspace/build/src/build/moz-automation.mk:89: recipe for target 'automation/l10n-check' failed
[task 2018-04-17T16:19:30.691Z] 16:19:30     INFO -  make[1]: *** [automation/l10n-check] Error 2

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fba7cab660da
Package translated uninstaller; r=pike,mshal
https://hg.mozilla.org/integration/mozilla-inbound/rev/66a52ced217d
Remove `installer` MOZ_AUTOMATION stage; r=mshal

Comment 38

[Phabricator Automation]

Comment on attachment 8955745 [details]
Bug 1436662: Translate uninstaller again.

Axel Hecht [:Pike] has approved the revision.
Michael Shal [:mshal] has approved the revision.

https://phabricator.services.mozilla.com/D672

Comment 39

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fba7cab660da
https://hg.mozilla.org/mozilla-central/rev/66a52ced217d

Comment 40

[Jorg K (CEST = GMT+2)]

Anything needs porting to TB here, for example this:
https://hg.mozilla.org/mozilla-central/rev/66a52ced217dda7eed86130861f8c41e2adbeb4e#l3.12
-mk_add_options "export MOZ_AUTOMATION_INSTALLER=${MOZ_AUTOMATION_INSTALLER-0}"

Do we still keep build files in sync?

Comment 41

[Phabricator Automation]

Attachment: Bug 1436662: Fix Thunderbird support for building windows packages; r?mshal

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5944ef6d6165
Port Bug 1436662: Package translated uninstaller; r=me CLOSED TREE DONTBUILD

Comment 43

[Molly Howell (she/her) (mostly inactive)]

Tom, what do you think about requesting uplift for this? I'd really like for this fix to get a spot on the ESR 60 bandwagon.

Comment 44

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8955745 [details]
Bug 1436662: Translate uninstaller again.

Approval Request Comment
[Feature/Bug causing the regression]:
Bug 1385227.

[User impact if declined]:
Windows uninstaller strings are always en-US in all locale builds. This also causes bug 1451480.

[Is this code covered by automated tests?]:
No.

[Has the fix been verified in Nightly?]:
Yes, I've manually verified that Nightly uninstallers are now correctly localized after this fix landed.

[Needs manual test from QE? If yes, steps to reproduce]: 
No, manual test shouldn't be needed.

[List of other uplifts needed for the feature/fix]:
None, just both parts of this fix.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
This is a build system change that strictly repairs an l10n build regression, it doesn't introduce any new code into the browser.

[String changes made/needed]:
N/A.

Comment 45

[Phabricator Automation]

Comment on attachment 8969308 [details]
Bug 1436662: Fix Thunderbird support for building windows packages; r?mshal

Michael Shal [:mshal] has approved the revision.

https://phabricator.services.mozilla.com/D991

Comment 46

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc8bc00108b7
Fix Thunderbird support for building windows packages; r=mshal

Comment 47

[Jorg K (CEST = GMT+2)]

Despite having that patch applied locally, I see

35:00.89 c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/_virtualenv/Scripts/python.exe: can't open file 'c:/mozilla-source/comm-central/toolkit/mozapps/installer/windows/nsis/preprocess-locale.py': [Errno 2] No such file or directory
35:00.90 mozmake[5]: *** [c:/mozilla-source/comm-central/mozilla/toolkit/mozapps/installer/windows/nsis/makensis.mk:90: instgen/helper.exe] Error 2

Is that related?

Comment 48

[Richard Marti (:Paenglab)]

I see also this:
11:34:50     INFO -  package> Error running mach:
11:34:50     INFO -  package>
11:34:50     INFO -  package>     ['repackage', 'installer', '-o', 'z:/build/build/src/obj-thunderbird/dist/install/sea/target.installer.exe', '--package-name', 'firefox', '--package', 'z:/build/build/src/obj-thunderbird/dist/target.zip', '--tag', 'z:/build/build/src/browser/installer/windows/app.tag', '--setupexe', 'instgen/setup.exe', '--sfx-stub', 'z:/build/build/src/comm/other-licenses/7zstub/thunderbird/7zSD.sfx']

This '--package-name', 'firefox' seems no to be correct for TB. Maybe https://searchfox.org/comm-central/source/mozilla/toolkit/mozapps/installer/windows/nsis/makensis.mk#62 needs a variable?

Comment 49

[Julien Cristau [:jcristau]]

Not too comfortable taking this at this stage in 60.  Setting esr60 status so it's on the radar there.

Comment 50

[Ryan VanderMeulen [:RyanVM]]

Yeah, I'd like keep this on the radar for the 60.1 release once it's had some more bake time.

Comment 51

[Tom Prince [:tomprince]]

> Despite having that patch applied locally, I see [...]

This is due to having c-c as the top-dir of your checkout. I think this should be the point where we bite the bullet and tell people to switch over.

Comment 52

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bc8bc00108b7

Comment 53

[Alice0775 White]

Is there no plan to fix for esr60?

Comment 54

[Ryan VanderMeulen [:RyanVM]]

See comment 50.

Comment 55

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8955745 [details]
Bug 1436662: Translate uninstaller again.

[Approval Request Comment]
See previous approval request in comment 44; adding only new information here.

If this is not a sec:{high,crit} bug, please state case for ESR consideration:
https://bugzilla.mozilla.org/show_bug.cgi?id=1461332#c51

User impact if declined:
Users running Kaspersky Internet Security and any Firefox locale other than en-US will find their locale changed to en-US upon updating to 60.

Comment 56

[Julien Cristau [:jcristau]]

Comment on attachment 8955745 [details]
Bug 1436662: Translate uninstaller again.

let's take this for 60.0.1 so we don't run into this mess with kaspersky again next time...

Comment 57

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/80affed34886
https://hg.mozilla.org/releases/mozilla-release/rev/4f7281fb6542

Comment 58

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/f11939364627
https://hg.mozilla.org/releases/mozilla-esr60/rev/0619e26054d7

Comment 59

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added this to Firefox and ESR 60.0.1 release notes

Comment 60

[Frank-Rainer Grahl (:frg)]

Aas far as I see it the esr60 push misses the followup cset already in Beta:

https://hg.mozilla.org/mozilla-central/rev/bc8bc00108b7

This breaks both the Thunderbird and SeaMonkey installer again. Please push this to esr60 too.

Comment 61

[Jorg K (CEST = GMT+2)]

Which ESR is that? It's already on mozilla-esr60 according to comment #58. In due course that will also go onto TB's release branch.

Comment 62

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/300908ac5dc7b8607afeaea25a5258d0f157ee45
https://hg.mozilla.org/releases/mozilla-esr60/rev/d4ddbb9e06c82bc653f07cab9692254ff28c7b0b

Comment 63

[Frank-Rainer Grahl (:frg)]

Thank you

Comment 64

[Camelia Badau [:cbadau], Desktop Test Engineering]

1. I've tested the `helper.exe` from Firefox .exe installers on Firefox 60.0.1-build2 and Firefox 60.0.1ESR using the following locale builds: ar, de, es-ES, fr, ja, ko, pt-PT, pl, ru, tr, zh-CN, vi: all the Windows uninstallers are correctly localized. 

2. I've tested that the uninstallers are correctly localized using the "Uninstall" option from Control Panel -> everything looks good (locale builds: fa, ar, vi, de). 

3. I've tested that the localized builds are correctly displayed in "Control Panel > Programs and Features" after updating Firefox to 60.0.1 RC and 60.0.1 ESR on "release-localtest"/"esr-localtest": 
- ar build: from 60.0 RC to 60.0.1 -> Firefox 60.0.1(ar) is displayed in Control Panel after update
- de build: from 59.0.3 to 60.0.1 -> Firefox 60.0.1(de) is displayed in Control Panel after update
- es-ES build: from 59.0 to 60.0.1 -> Firefox 60.0.1(es-ES) is displayed in Control Panel after update
- ja build: from 58.0.2 to 60.0.1 -> Firefox 60.0.1(ja) is displayed in Control Panel after update
- ar build: from 60.0 ESR to 60.0.1 ESR -> Firefox 60.0.1esr(ar) is displayed in Control Panel after update
- pt-PT build: from 60.0 ESR to 60.0.1 ESR -> Firefox 60.0.1esr(pt-PT) is displayed in Control Panel after update


I've tested on Windows 7 x64 and Windows 10 x86.

Comment 65

[Ryan VanderMeulen [:RyanVM]]

This was only verified by QA on 60, but that plus 4 weeks of bake time on 61 is enough to make me say that we can call it verified too.