1438716 - Upgrade Leanplum SDK

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, enhancement, P1)

Description

[:sdaswani]

Hello!

We are releasing a new version of the Android SDK on Friday, February 16th, and have some important improvements that we want to share.

Below is the full list of improvements being made:

    Splits the existing Android SDK into smaller modules e.g. Core, GCM, FCM, Location, UI editor
    Resolves contention issues between GCM and FCM 
    Reduces total SDK package size — by only including the modules you need, you can optimize the overall weight of the LP SDK 

If your project is configured to automatically pull in the latest version of our SDK from Gradle, then you will need to follow the instructions here to correctly compile your project:

https://www.leanplum.com/docs/android/upgrading-to-android-4

Please reach out directly to [e-mail] or your CSM with any questions.

Cheers,
The Leanplum Team 

Mobile Marketing Platform
Integrated. ROI Engine.
 
If you no longer wish to receive these email click here to Unsubscribe

Comment 1

[:sdaswani]

Jean what's the priority on this?

Comment 2

[Jean Collings]

Would this address fixing the banner issues we're having?

Comment 3

[:sdaswani]

No clue Jean.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

[triage] Potentially critical – is Leanplum.

Comment 5

[:sdaswani]

Andrei can you attach the diff for Fennec with the updated Leanplum SDK here please.

Comment 6

[:sdaswani]

PI request sent.

Comment 7

[:sdaswani]

Nick, it turns out that this SDK upgrade will require API level 26 - what are the plans to upgrade Fennec to API level 26+?

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to :sdaswani from comment #7)
> Nick, it turns out that this SDK upgrade will require API level 26 - what
> are the plans to upgrade Fennec to API level 26+?

There are none.  There are no people working on Fennec to the best of my knowledge.

Comment 9

[:sdaswani]

(In reply to Nick Alexander :nalexander from comment #8)
> (In reply to :sdaswani from comment #7)
> > Nick, it turns out that this SDK upgrade will require API level 26 - what
> > are the plans to upgrade Fennec to API level 26+?
> 
> There are none.  There are no people working on Fennec to the best of my
> knowledge.

Thanks Nick, the Softvision contractors are going to give it a go.

Comment 10

[Nick Alexander :nalexander [he/him]]

(In reply to :sdaswani from comment #9)
> (In reply to Nick Alexander :nalexander from comment #8)
> > (In reply to :sdaswani from comment #7)
> > > Nick, it turns out that this SDK upgrade will require API level 26 - what
> > > are the plans to upgrade Fennec to API level 26+?
> > 
> > There are none.  There are no people working on Fennec to the best of my
> > knowledge.
> 
> Thanks Nick, the Softvision contractors are going to give it a go.

Very good!  I do not expect there will be significant issues.  There's a tricky thing where the versions in https://searchfox.org/mozilla-central/source/old-configure.in#2076 and https://searchfox.org/mozilla-central/source/build/autoconf/android.m4#99 need to be updated; but after that, I expect those few version bumps to just work in https://searchfox.org/mozilla-central/source/build.gradle#18-20.

Comment 11

[:sdaswani]

(In reply to Nick Alexander :nalexander from comment #10)
> (In reply to :sdaswani from comment #9)
> > (In reply to Nick Alexander :nalexander from comment #8)
> > > (In reply to :sdaswani from comment #7)
> > > > Nick, it turns out that this SDK upgrade will require API level 26 - what
> > > > are the plans to upgrade Fennec to API level 26+?
> > > 
> > > There are none.  There are no people working on Fennec to the best of my
> > > knowledge.
> > 
> > Thanks Nick, the Softvision contractors are going to give it a go.
> 
> Very good!  I do not expect there will be significant issues.  There's a
> tricky thing where the versions in
> https://searchfox.org/mozilla-central/source/old-configure.in#2076 and
> https://searchfox.org/mozilla-central/source/build/autoconf/android.m4#99
> need to be updated; but after that, I expect those few version bumps to just
> work in https://searchfox.org/mozilla-central/source/build.gradle#18-20.

Great, this tip and any more would be much appreciated :) .

Comment 12

[Jan Henning [:JanH]]

In theory this needs to be done before being able to upgrade the Android support library to v26, although in practice the one compile error I got can be worked around, so it might not be absolutely critical.

Comment 13

[:sdaswani]

Andrei now that we've upgraded to Android O / API Level 26, can the Leanplum work move forth?

Comment 14

[Andrei Lazar]

Attachment: Bug 1438716 - Upgrade Leanplum SDK.

Upgraded to version 3.0.2 from official repository while keeping the internal changes.
This upgrade encapsulates some major changes as well as bug fixes.

Review commit: https://reviewboard.mozilla.org/r/242790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242790/

Comment 15

[Nevin Chen(Not active on Bugzilla)]

May I know the commit or branch in the Leanplum SDK your patch based on? thanks!

Comment 16

[Andrei Lazar]

Yes, as I've said in the commit message, the branch is release 3.0.2 (https://github.com/Leanplum/Leanplum-Android-SDK/tree/release/3.0.2). Thank you!

Comment 17

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8974442 [details]
Bug 1438716 - Upgrade Leanplum SDK.

https://reviewboard.mozilla.org/r/242790/#review249670

If there's no error with try, after fixing per comments this patch will be good for landing.

::: mobile/android/thirdparty/build.gradle:56
(Diff revision 1)
>      }
> +    // Provided dependencies are optional dependencies and will not show up in pom file.
> +    compileOnly('com.google.android.gms:play-services-gcm:[8.3.0,)') {
> +        exclude module: 'support-v4'
> +    }
> +    compileOnly('com.google.firebase:firebase-messaging:[10.0.0,)') {

I guess we don't need this cause we didn't and won't use it? See the comments below

::: mobile/android/thirdparty/build.gradle:59
(Diff revision 1)
> +        exclude module: 'support-v4'
> +    }
> +    compileOnly('com.google.firebase:firebase-messaging:[10.0.0,)') {
> +        exclude module: 'support-v4'
> +    }
> +    compileOnly('com.google.android.gms:play-services-location:[10.0.0,)') {

Same as above

::: mobile/android/thirdparty/com/leanplum/LeanplumFcmProvider.java:38
(Diff revision 1)
> +/**
> + * Leanplum provider for work with Firebase.
> + *
> + * @author Anna Orlova
> + */
> +class LeanplumFcmProvider extends LeanplumCloudMessagingProvider {

Since we didn't use it, can we skip and don't add this file?

::: mobile/android/thirdparty/com/leanplum/LeanplumInbox.java:107
(Diff revision 1)
> +  /**
> +   * Returns the identifiers of all inbox messages on the device sorted in ascending
> +   * chronological order, i.e. the id of the oldest message is the first one, and the most recent
> +   * one is the last one in the array.
> +   */
> +  public List<String> messagesIds() {

I'm not sure if it still the case, I think we don't use Inbox. Should we update it as well?

::: mobile/android/thirdparty/com/leanplum/internal/ActionManager.java:80
(Diff revision 1)
>  
>    private static boolean loggedLocationManagerFailure = false;
>  
>    public static LocationManager getLocationManager() {
>      if (Util.hasPlayServices()) {
> +      try {

We returned null on purpose cause we don't want google location service in our codebase.

Comment 18

[Nevin Chen(Not active on Bugzilla)]

Please feel free to request for review again. Thanks!

Comment 19

[Andrei Lazar]

Comment on attachment 8974442 [details]
Bug 1438716 - Upgrade Leanplum SDK.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242790/diff/1-2/

Comment 20

[Andrei Lazar]

Hello Nevin, I think this is good to land as soon as we finish the Oreo migration. Thank you!

Comment 21

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8974442 [details]
Bug 1438716 - Upgrade Leanplum SDK.

https://reviewboard.mozilla.org/r/242790/#review255698

Sorry for the late. Please drop me a message on Slack if you need a prompt reply :)

The fix here seems all from Leanplum. And I didn't see any Firebase or other undesired dependencies so I think it's good to land.

Comment 22

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1438716 - Upgrade Leanplum SDK.

Upgraded to version 3.0.2 from official repository while keeping the internal changes.
This upgrade encapsulates some major changes as well as bug fixes.

Review commit: https://reviewboard.mozilla.org/r/256902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256902/

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d686b90e9c64
Upgrade Leanplum SDK. r=nechen

Comment 24

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d686b90e9c64