1439991 - Fix complicated.netmonitor DAMP error on Windows 10

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Bug 1437028 disabled complicated.netmonitor on windows because it was permafailing on upcoming new Windows 10 hardware.
We should fix that error to keep it enabled on windows.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1439991 - Re-enable netmonitor test on windows.

Review commit: https://reviewboard.mozilla.org/r/221994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221994/

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1439991 - Fix complicated.netmonitor timeout on windows.

When opening the netmonitor, some pending requests may still occur after the toolbox is opened.
So that we overflow the expected number of requests we except during page reload.

Review commit: https://reviewboard.mozilla.org/r/221996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221996/

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8952770 [details]
Bug 1439991 - Re-enable netmonitor test on windows.

Robert, here is a green try with your patch from bug 1431161.
Could you confirm that your patch and the try syntax I used are valid?
I just want to ensure I really fixed what was blocking you...

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4085481ab41b0169ed70b6499938dc5a56c6743&selectedJob=163391671

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8952771 [details]
Bug 1439991 - Fix complicated.netmonitor timeout on windows.

https://reviewboard.mozilla.org/r/221996/#review228186

Oh, yes, I was seeing this today and wanted to do the same.
R+ assuming try is green.

Honza

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8952770 [details]
Bug 1439991 - Re-enable netmonitor test on windows.

https://reviewboard.mozilla.org/r/221994/#review228244

Hi Alexandre, thanks, r+ with the one change that I suggested below. FYI: We are in the process of landing Bug 1431161 right now, once that lands you'll be able to rebase and try your patch alone on try again. Thanks!

::: testing/talos/talos/tests/devtools/addon/content/damp.html:14
(Diff revision 1)
>  
>  // Bug 1400580 disable 'complicated.netmonitor' on Win
>  ChromeUtils.import("resource://gre/modules/Services.jsm");
>  var run_complicated_netmonitor = true;
>  if (Services.appinfo.OS == "WINNT") {
> -  run_complicated_netmonitor = false;
> +  run_complicated_netmonitor = true;

I would probably just remove 'run_complicated_netmonitor' conpletely and that block of code, and just set 'complicated.netmonitor' to true as it was originally. Thanks!

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8952770 [details]
Bug 1439991 - Re-enable netmonitor test on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221994/diff/1-2/

Comment 7

[Alexandre Poirot [:ochameau]]

Comment on attachment 8952771 [details]
Bug 1439991 - Fix complicated.netmonitor timeout on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221996/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffd6c09e8b06
Re-enable netmonitor test on windows. r=rwood
https://hg.mozilla.org/integration/autoland/rev/3fa2cac0f4b8
Fix complicated.netmonitor timeout on windows. r=Honza

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/ffd6c09e8b06
https://hg.mozilla.org/mozilla-central/rev/3fa2cac0f4b8