Closed Bug 1439995 Opened 3 years ago Closed 2 years ago

Missing user prompt handling for Execute Script and Execute Async Script

Categories

(Testing :: Marionette, enhancement, P1)

Version 3
enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ato, Assigned: whimboo)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Blocks: webdriver
Priority: -- → P2
Flags: needinfo?(ato)
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8953040 [details]
Bug 1439995 - Add user prompt checks for script execution commands.

https://reviewboard.mozilla.org/r/222316/#review228204
Attachment #8953040 - Flags: review?(dburns) → review+
I’m going to delay this until bug 1264259 because it creates some difficult problems with WPT.
Assignee: ato → nobody
Status: ASSIGNED → NEW
Depends on: 1264259
Priority: P2 → P3
Attachment #8953040 - Attachment is obsolete: true
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1
Attachment #8995334 - Flags: review?(ato)
Attachment #8995335 - Flags: review?(ato)
Comment on attachment 8995334 [details]
Bug 1439995 - [marionette] Add user prompt checks for script execution commands.

https://reviewboard.mozilla.org/r/259792/#review266894
Attachment #8995334 - Flags: review?(ato) → review+
Comment on attachment 8995335 [details]
Bug 1439995 - [wdspec] Refactor user_prompt tests for Execute Script / Execute Async Script.

https://reviewboard.mozilla.org/r/259794/#review266896
Attachment #8995335 - Flags: review?(ato) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fcc35eafe56
[marionette] Add user prompt checks for script execution commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/910af1264f68
[wdspec] Refactor user_prompt tests for Execute Script / Execute Async Script. r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12210 for changes under testing/web-platform/tests
https://hg.mozilla.org/mozilla-central/rev/5fcc35eafe56
https://hg.mozilla.org/mozilla-central/rev/910af1264f68
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.