Missing user prompt handling for Execute Script and Execute Async Script

RESOLVED FIXED in Firefox 63

Status

enhancement
P1
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: ato, Assigned: whimboo)

Tracking

(Blocks 1 bug)

Version 3
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Reporter

Updated

a year ago
Blocks: webdriver
Priority: -- → P2
Comment hidden (obsolete)
Comment hidden (obsolete)
Flags: needinfo?(ato)
Reporter

Updated

a year ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8953040 [details]
Bug 1439995 - Add user prompt checks for script execution commands.

https://reviewboard.mozilla.org/r/222316/#review228204
Attachment #8953040 - Flags: review?(dburns) → review+
Reporter

Comment 5

a year ago
I’m going to delay this until bug 1264259 because it creates some difficult problems with WPT.
Assignee: ato → nobody
Status: ASSIGNED → NEW
Depends on: 1264259
Priority: P2 → P3
Reporter

Updated

a year ago
Attachment #8953040 - Attachment is obsolete: true
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Attachment #8995334 - Flags: review?(ato)
Attachment #8995335 - Flags: review?(ato)
Reporter

Comment 10

10 months ago
mozreview-review
Comment on attachment 8995334 [details]
Bug 1439995 - [marionette] Add user prompt checks for script execution commands.

https://reviewboard.mozilla.org/r/259792/#review266894
Attachment #8995334 - Flags: review?(ato) → review+
Reporter

Comment 11

10 months ago
mozreview-review
Comment on attachment 8995335 [details]
Bug 1439995 - [wdspec] Refactor user_prompt tests for Execute Script / Execute Async Script.

https://reviewboard.mozilla.org/r/259794/#review266896
Attachment #8995335 - Flags: review?(ato) → review+

Comment 12

10 months ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fcc35eafe56
[marionette] Add user prompt checks for script execution commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/910af1264f68
[wdspec] Refactor user_prompt tests for Execute Script / Execute Async Script. r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12210 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/12210
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/408892579?utm_source=github_status&utm_medium=notification)

Comment 15

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5fcc35eafe56
https://hg.mozilla.org/mozilla-central/rev/910af1264f68
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Blocks: 1473814
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.