Closed Bug 1457244 Opened 6 years ago Closed 3 years ago

Intermittent /webdriver/tests/execute_async_script/user_prompts.py | test_handle_prompt_twice - NoSuchAlertException: no such alert (404): No modal dialog is currently open

Categories

(Remote Protocol :: Marionette, defect, P5)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
defect

Tracking

(firefox61 disabled, firefox62 disabled, firefox63 disabled, firefox64 disabled, firefox65 disabled)

Status:
RESOLVED DUPLICATE of bug 1459118
Tracking Flags:
Tracking Status
firefox61 --- disabled
firefox62 --- disabled
firefox63 --- disabled
firefox64 --- disabled
firefox65 --- disabled

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure) 

Those two tests will be disabled by the next wptsync merge as covered by bug 1453105.

Is it actually a new type of failure we haven't seen before. So I wonder if something else landed on the canonical repository, which triggered those failures.
Depends on: 1453105
Summary: Intermittent /webdriver/tests/execute_async_script/user_prompts.py | test_handle_prompt_twice - NoSuchAlertException: no such alert (404): No modal dialog is currently open → Intermittent /webdriver/tests/execute_async_script/user_prompts.py, /webdriver/tests/execute_script/user_prompts.py | test_handle_prompt_twice - NoSuchAlertException: no such alert (404): No modal dialog is currently open
Both tests have been disabled based on the wptsync merge from bug 1453105. See also bug 1431081 for another reason.
status-firefox61: --- → disabled
See Also: → 1431081
(In reply to Henrik Skupin (:whimboo) from comment #3)
> Both tests have been disabled based on the wptsync merge from bug 1453105.
> See also bug 1431081 for another reason.

Strange. Given bug 1459118 the tests should still be active. I will have to check that later.
See Also: 1431081 → 1459118
Summary: Intermittent /webdriver/tests/execute_async_script/user_prompts.py, /webdriver/tests/execute_script/user_prompts.py | test_handle_prompt_twice - NoSuchAlertException: no such alert (404): No modal dialog is currently open → Intermittent /webdriver/tests/execute_async_script/user_prompts.py | test_handle_prompt_twice - NoSuchAlertException: no such alert (404): No modal dialog is currently open
The test has been disabled by the landing of my patch on bug 1459118.
Assignee: nobody → hskupin
status-firefox62: --- → disabled
Assignee: hskupin → nobody
This test is disabled and as such doesn't show the failures.
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: INCOMPLETE → ---
These tests will be re-enabled together with the execute_script ones over on bug 1459118.
Assignee: nobody → hskupin
Status: REOPENED → ASSIGNED
Depends on: 1459118
Priority: P5 → P2
We are trying to build a tool to automatically classify intermittent failures, which would provide a starting point for fixing the bug, reducing the manual work for the developers.
We are collecting some feedback on the results, to see if they’re good enough and where we need to improve.
    
For this bug, the tool says that the intermittent failure is most likely a:
Concurrency Issue: This includes tests in which failures occur due to thread management issues (different threads or their outcomes depending on an implicit ordering), race conditions and/or deadlocks, and issues related to an asynchronous waits (e.g. a process trying to access an external resource or continuing before the external resource is available).


Once you’re done investigating and/or fixing the bug, could you tell me:
- Did the tool correctly recognize the type of intermittent failure?
- Did the information from the tool help your analysis, the bug fixing process, or anything in the process? (please also let us know how the tool was useful and/or what would improve the tool's usefulness for you)
Flags: needinfo?(hskupin)
(In reply to meck93 from comment #11)
Once you’re done investigating and/or fixing the bug, could you tell me:
> - Did the tool correctly recognize the type of intermittent failure?

Which tool? And where to gather that information? There has nothing pointed out.

> - Did the information from the tool help your analysis, the bug fixing
> process, or anything in the process?

Again, nothing to tell without details about the tool.
Flags: needinfo?(hskupin)
@[:whimboo]: Comment #11 was a post created by the tool. The tool analyses the Treeherder logfiles (+ affected source code files) and tries to predict the most likely type of intermittent-failure, which is then posted as a comment #11. 
For this bug, the prediction was: a concurrency issue.
Flags: needinfo?(hskupin)
Yes as of it's state now it might be a concurrency issue. In some cases the command returns too early and as such not two dialogs have been opened.
Flags: needinfo?(hskupin)
It's not clear by the spec, so I cannot continue to work on this bug for now.
Assignee: hskupin → nobody
Status: ASSIGNED → NEW
status-firefox63: --- → disabled
Priority: P2 → P3
Priority: P3 → P5
This is actually blocked by bug 1487358 if opening two alerts is the expected behavior. The discussion is still ongoing on bug https://github.com/w3c/webdriver/issues/1153.
status-firefox64: --- → disabled
status-firefox65: --- → disabled
Depends on: 1487358
No longer depends on: 1459118
No longer depends on: 1487358
No longer depends on: 1560010

With bug 1439995 the test names got updated from test_abort_by_user_prompt_twice to test_abort_by_user_prompt_twice. And both tests for Execute Script and Execute Async Script are now handled by bug 1459118.

Status: NEW → RESOLVED
Closed: 6 years ago → 3 years ago
No longer depends on: 1560015
Keywords: leave-open
Resolution: --- → DUPLICATE
See Also: 1459118 → 1439995
Moving bug to Remote Protocol::Marionette component per bug 1815831.
Component: geckodriver → Marionette
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.