Missing user prompt checks for most commands

NEW
Unassigned

Status

Testing
Marionette
P1
normal
11 months ago
6 days ago

People

(Reporter: ato, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Version 3
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

11 months ago
Most commands in Marionette are missing checks for any open user prompts.
(Reporter)

Updated

11 months ago
Blocks: 721859
(Reporter)

Updated

11 months ago
Duplicate of this bug: 1206126
Depends on: 1348872
Depends on: 1263661
Hm, the spec is not that clear about that but I assume that closing an alert should by synchronous? Right now I do not see that we are actually waiting for the alert being closed before continuing. As result we have lots of wait for conditions in the unit tests. David, should we be more explicit in the spec?

https://w3c.github.io/webdriver/webdriver-spec.html#user-prompts
Flags: needinfo?(dburns)
(In reply to Henrik Skupin (:whimboo) from comment #2)
> Hm, the spec is not that clear about that but I assume that closing an alert
> should by synchronous? Right now I do not see that we are actually waiting
> for the alert being closed before continuing. As result we have lots of wait
> for conditions in the unit tests. David, should we be more explicit in the
> spec?
> 
> https://w3c.github.io/webdriver/webdriver-spec.html#user-prompts

All commands are supposed to be synchronous when they return to the local end from the remote end.
Flags: needinfo?(dburns)
Ok, so that is clearly a point which doesn't apply to our code yet. I will take care of that when working on this bug.
(Reporter)

Comment 5

a month ago
For what it’s worth, I don’t think the spec needs to change.  It can be assumed from the way it is written that user prompts are expected to be closed synchronously.
[mass] Setting priority
Priority: -- → P1
(Reporter)

Updated

6 days ago
Depends on: 1359004
You need to log in before you can comment on or make changes to this bug.