Closed Bug 1440392 Opened 5 years ago Closed 5 years ago

Move XBL accessibility role="xul:menupopup" into XULMap.h

Categories

(Toolkit :: XUL Widgets, task)

Product:
Toolkit
Component:
XUL Widgets
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

Attachments

(1 file)

Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h
59 bytes, text/x-review-board-request
enndeakin
: review+
Details 
+++ This bug was initially created as a clone of Bug #1430777 +++

See bug 1430777 comment 1
Comment on attachment 8953185 [details]
Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h

https://reviewboard.mozilla.org/r/222466/#review228386

::: accessible/base/XULMap.h:85
(Diff revision 2)
> +  }
> +)
> +
> +XULMAP(
> +  popup,
> +  [](nsIContent* aContent, Accessible* aContext) {

I assume C++14 is supported on all platforms?

::: accessible/xul/XULFormControlAccessible.cpp:174
(Diff revision 2)
>    // buttons can have button (@type="menu-button") and popup accessibles
>    // (@type="menu-button", @type="menu" or columnpicker.
>  
>    // XXX: no children until the button is menu button. Probably it's not
>    // totally correct but in general AT wants to have leaf buttons.
>    nsAutoString role;

Either this bug or bug 1437873 would need to remove this local variable, depend on which lands first.
Attachment #8953185 - Flags: review?(paolo.mozmail)
Attachment #8953185 - Flags: review?(enndeakin)
Comment on attachment 8953185 [details]
Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h

https://reviewboard.mozilla.org/r/222466/#review229904
Attachment #8953185 - Flags: review?(enndeakin) → review+
Attachment #8953185 - Flags: review?(paolo.mozmail)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 883ddd2f08b985000563646d48972caa28aee0bd -d 13eacb5892bb: rebasing 449320:883ddd2f08b9 "Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h r=enndeakin+6102" (tip)
merging accessible/base/XULMap.h
merging accessible/base/nsAccessibilityService.cpp
warning: conflicts while merging accessible/base/XULMap.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/301d5c17203a
Move XBL accessibility role="xul:menupopup" into XULMap.h r=enndeakin+6102
https://hg.mozilla.org/mozilla-central/rev/301d5c17203a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.