1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1430777 +++

See bug 1430777 comment 1

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h

Review commit: https://reviewboard.mozilla.org/r/222466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222466/

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8953185 [details]
Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222466/diff/1-2/

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8953185 [details]
Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h

https://reviewboard.mozilla.org/r/222466/#review228386

::: accessible/base/XULMap.h:85
(Diff revision 2)
> +  }
> +)
> +
> +XULMAP(
> +  popup,
> +  [](nsIContent* aContent, Accessible* aContext) {

I assume C++14 is supported on all platforms?

::: accessible/xul/XULFormControlAccessible.cpp:174
(Diff revision 2)
>    // buttons can have button (@type="menu-button") and popup accessibles
>    // (@type="menu-button", @type="menu" or columnpicker.
>  
>    // XXX: no children until the button is menu button. Probably it's not
>    // totally correct but in general AT wants to have leaf buttons.
>    nsAutoString role;

Either this bug or bug 1437873 would need to remove this local variable, depend on which lands first.

Comment 4

[Neil Deakin]

Comment on attachment 8953185 [details]
Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h

https://reviewboard.mozilla.org/r/222466/#review229904

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8953185 [details]
Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222466/diff/2-3/

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8953185 [details]
Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222466/diff/3-4/

Comment 7

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 883ddd2f08b985000563646d48972caa28aee0bd -d 13eacb5892bb: rebasing 449320:883ddd2f08b9 "Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h r=enndeakin+6102" (tip)
merging accessible/base/XULMap.h
merging accessible/base/nsAccessibilityService.cpp
warning: conflicts while merging accessible/base/XULMap.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/301d5c17203a
Move XBL accessibility role="xul:menupopup" into XULMap.h r=enndeakin+6102

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/301d5c17203a