Closed
Bug 1440392
Opened 6 years ago
Closed 6 years ago
Move XBL accessibility role="xul:menupopup" into XULMap.h
Categories
(Toolkit :: XUL Widgets, task)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: timdream, Assigned: timdream)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1430777 +++ See bug 1430777 comment 1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8953185 [details] Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h https://reviewboard.mozilla.org/r/222466/#review228386 ::: accessible/base/XULMap.h:85 (Diff revision 2) > + } > +) > + > +XULMAP( > + popup, > + [](nsIContent* aContent, Accessible* aContext) { I assume C++14 is supported on all platforms? ::: accessible/xul/XULFormControlAccessible.cpp:174 (Diff revision 2) > // buttons can have button (@type="menu-button") and popup accessibles > // (@type="menu-button", @type="menu" or columnpicker. > > // XXX: no children until the button is menu button. Probably it's not > // totally correct but in general AT wants to have leaf buttons. > nsAutoString role; Either this bug or bug 1437873 would need to remove this local variable, depend on which lands first.
Assignee | ||
Updated•6 years ago
|
Attachment #8953185 -
Flags: review?(paolo.mozmail)
Assignee | ||
Updated•6 years ago
|
Attachment #8953185 -
Flags: review?(enndeakin)
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8953185 [details] Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h https://reviewboard.mozilla.org/r/222466/#review229904
Attachment #8953185 -
Flags: review?(enndeakin) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8953185 -
Flags: review?(paolo.mozmail)
Comment 7•6 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 883ddd2f08b985000563646d48972caa28aee0bd -d 13eacb5892bb: rebasing 449320:883ddd2f08b9 "Bug 1440392 - Move XBL accessibility role="xul:menupopup" into XULMap.h r=enndeakin+6102" (tip) merging accessible/base/XULMap.h merging accessible/base/nsAccessibilityService.cpp warning: conflicts while merging accessible/base/XULMap.h! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Updated•6 years ago
|
Blocks: war-on-xbl
Pushed by timdream@gmail.com: https://hg.mozilla.org/integration/autoland/rev/301d5c17203a Move XBL accessibility role="xul:menupopup" into XULMap.h r=enndeakin+6102
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/301d5c17203a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•4 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•