1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1430777 +++

See bug 1430777 comment 2 and bug 1430777 comment 3.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h

Review commit: https://reviewboard.mozilla.org/r/219862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219862/

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8950587 [details]
Bug 1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h

https://reviewboard.mozilla.org/r/219862/#review225654

::: accessible/base/XULMap.h:37
(Diff revision 1)
>  XULMAP_TYPE(toolbarspring, XULToolbarSeparatorAccessible)
>  XULMAP_TYPE(treecol, XULColumnItemAccessible)
>  XULMAP_TYPE(treecolpicker, XULButtonAccessible)
>  XULMAP_TYPE(treecols, XULTreeColumAccessible)
>  XULMAP_TYPE(toolbar, XULToolbarAccessible)
> +XULMAP_TYPE(toolbarbutton, XULToolbarButtonAccessible)

This may not be correct because of https://bugzilla.mozilla.org/show_bug.cgi?id=1430777#c6 ; there are a few `<toolbarbutton>` that inherits role=xul:button. According to https://dxr.mozilla.org/mozilla-central/rev/6d8f470b2579e7570f14e3db557264dc075dd654/accessible/base/nsAccessibilityService.cpp#1217 XULMAP takes precedence over role attribute.

Comment 3

[:Paolo Amadini]

It would probably make sense to do "button" and "toolbarbutton" in this bug, and use a separate one for "textbox" and "textbox[type=autocomplete]".

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to :Paolo Amadini from comment #3)
> It would probably make sense to do "button" and "toolbarbutton" in this bug,
> and use a separate one for "textbox" and "textbox[type=autocomplete]".

Yeah, make sense.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8950587 [details]
Bug 1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219862/diff/1-2/

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Hi, Marco, would you mind take a look at the patch and the try result at https://treeherder.mozilla.org/#/jobs?repo=try&revision=6122d5286a714d596a7238fe44a075148e03b4e2 ?

The changed UI are located at

1. Library icon -> Downloads -> Downloaded items in the downloads subpanel view
2. Tools -> Web Developer -> Browser Console

Thanks.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: with patch - download.png

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: with patch - webconsole.png

So I ended up inspecting the accessibility attributes of these UIs, with new tool to be introduced by bug 1151468.

I don't see any difference other than additional 'setsize' and 'posinset' attributes. I assume it's ok?

Comment 9

[Neil Deakin]

Comment on attachment 8950587 [details]
Bug 1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h

https://reviewboard.mozilla.org/r/219862/#review229894

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8950587 [details]
Bug 1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219862/diff/2-3/

Comment 11

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8e7534dc34f95e1d0cc6d00370475cc796acc36e -d f262f531263f: rebasing 449326:8e7534dc34f9 "Bug 1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h r=enndeakin+6102" (tip)
merging accessible/base/XULMap.h
merging accessible/base/nsAccessibilityService.cpp
merging accessible/xul/XULFormControlAccessible.cpp
warning: conflicts while merging accessible/xul/XULFormControlAccessible.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5056ddbfcd25
Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h r=enndeakin+6102

Comment 13

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/5056ddbfcd25