Closed
Bug 1437873
Opened 6 years ago
Closed 6 years ago
Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h
Categories
(Toolkit :: UI Widgets, task)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: timdream, Assigned: timdream)
References
Details
Attachments
(3 files)
+++ This bug was initially created as a clone of Bug #1430777 +++ See bug 1430777 comment 2 and bug 1430777 comment 3.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8950587 [details] Bug 1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h https://reviewboard.mozilla.org/r/219862/#review225654 ::: accessible/base/XULMap.h:37 (Diff revision 1) > XULMAP_TYPE(toolbarspring, XULToolbarSeparatorAccessible) > XULMAP_TYPE(treecol, XULColumnItemAccessible) > XULMAP_TYPE(treecolpicker, XULButtonAccessible) > XULMAP_TYPE(treecols, XULTreeColumAccessible) > XULMAP_TYPE(toolbar, XULToolbarAccessible) > +XULMAP_TYPE(toolbarbutton, XULToolbarButtonAccessible) This may not be correct because of https://bugzilla.mozilla.org/show_bug.cgi?id=1430777#c6 ; there are a few `<toolbarbutton>` that inherits role=xul:button. According to https://dxr.mozilla.org/mozilla-central/rev/6d8f470b2579e7570f14e3db557264dc075dd654/accessible/base/nsAccessibilityService.cpp#1217 XULMAP takes precedence over role attribute.
Assignee | ||
Updated•6 years ago
|
Attachment #8950587 -
Flags: review?(paolo.mozmail)
Comment 3•6 years ago
|
||
It would probably make sense to do "button" and "toolbarbutton" in this bug, and use a separate one for "textbox" and "textbox[type=autocomplete]".
Assignee | ||
Comment 4•6 years ago
|
||
(In reply to :Paolo Amadini from comment #3) > It would probably make sense to do "button" and "toolbarbutton" in this bug, > and use a separate one for "textbox" and "textbox[type=autocomplete]". Yeah, make sense.
Summary: Move XBL accessibility role="xul:toolbarbutton" role="xul:textbox" into XULMap.h → Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•6 years ago
|
||
Hi, Marco, would you mind take a look at the patch and the try result at https://treeherder.mozilla.org/#/jobs?repo=try&revision=6122d5286a714d596a7238fe44a075148e03b4e2 ? The changed UI are located at 1. Library icon -> Downloads -> Downloaded items in the downloads subpanel view 2. Tools -> Web Developer -> Browser Console Thanks.
Flags: needinfo?(mzehe)
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
So I ended up inspecting the accessibility attributes of these UIs, with new tool to be introduced by bug 1151468. I don't see any difference other than additional 'setsize' and 'posinset' attributes. I assume it's ok?
Flags: needinfo?(mzehe)
Assignee | ||
Updated•6 years ago
|
Attachment #8950587 -
Flags: review?(paolo.mozmail)
Assignee | ||
Updated•6 years ago
|
Attachment #8950587 -
Flags: review?(enndeakin)
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8950587 [details] Bug 1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h https://reviewboard.mozilla.org/r/219862/#review229894
Attachment #8950587 -
Flags: review?(enndeakin) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8950587 -
Flags: review?(paolo.mozmail)
Comment 11•6 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 8e7534dc34f95e1d0cc6d00370475cc796acc36e -d f262f531263f: rebasing 449326:8e7534dc34f9 "Bug 1437873 - Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h r=enndeakin+6102" (tip) merging accessible/base/XULMap.h merging accessible/base/nsAccessibilityService.cpp merging accessible/xul/XULFormControlAccessible.cpp warning: conflicts while merging accessible/xul/XULFormControlAccessible.cpp! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Updated•6 years ago
|
Blocks: war-on-xbl
Comment 12•6 years ago
|
||
Pushed by timdream@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5056ddbfcd25 Move XBL accessibility role="xul:toolbarbutton" and role="xul:button" into XULMap.h r=enndeakin+6102
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5056ddbfcd25
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•