1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1430777 +++

toolkit/content/widgets/text.xml#text-base role="xul:text"
  description
  toolkit/content/widgets/text.xml#text-label
    label
    toolkit/content/widgets/text.xml#label-control
      label[control]
      label.radio-label
      label.checkbox-label
      label.toolbarbutton-multiline-text

toolkit/content/widgets/text.xml#text-link role="xul:link"
  label.text-link
  label[onclick]

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

Review commit: https://reviewboard.mozilla.org/r/221816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221816/

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e79f6159359cefc6d998b479d63295390a568d6

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221816/diff/1-2/

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8ed35246ac37569a9fc3bcd86abecd77943b235

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

https://reviewboard.mozilla.org/r/221816/#review228004

With accessibility inspector from bug 1151468 I can verify that <label> and <label class="text-link"> are being assigned to correct roles.

Comment 6

[Neil Deakin]

Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

https://reviewboard.mozilla.org/r/221816/#review229890

::: accessible/base/XULMap.h:40
(Diff revision 2)
>  XULMAP_TYPE(treecols, XULTreeColumAccessible)
>  XULMAP_TYPE(toolbar, XULToolbarAccessible)
>  XULMAP_TYPE(tooltip, XULTooltipAccessible)
>  
>  XULMAP(
> +  label,

This doesn't handle the case where there is a label with an onclick attribute.

::: accessible/base/nsAccessibilityService.cpp:26
(Diff revision 2)
>  #include "HyperTextAccessibleWrap.h"
>  #include "RootAccessible.h"
>  #include "nsAccUtils.h"
>  #include "nsArrayUtils.h"
>  #include "nsAttrName.h"
> +#include "nsDOMTokenList.h"

This doesn't seem to be used.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

https://reviewboard.mozilla.org/r/221816/#review230052

::: accessible/base/XULMap.h:40
(Diff revision 2)
>  XULMAP_TYPE(treecols, XULTreeColumAccessible)
>  XULMAP_TYPE(toolbar, XULToolbarAccessible)
>  XULMAP_TYPE(tooltip, XULTooltipAccessible)
>  
>  XULMAP(
> +  label,

I don't find any `<label onclick>` without `class="text-link"`, so I figured it should be safe to disregard that.

::: accessible/base/nsAccessibilityService.cpp:26
(Diff revision 2)
>  #include "HyperTextAccessibleWrap.h"
>  #include "RootAccessible.h"
>  #include "nsAccUtils.h"
>  #include "nsArrayUtils.h"
>  #include "nsAttrName.h"
> +#include "nsDOMTokenList.h"

`Element::ClassList()` returns `nsDOMTokenList`.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221816/diff/2-3/

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Hi,

I don't see mozreview pick up the review flag; ni just to make sure you are seeing this.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221816/diff/3-4/

Comment 11

[Neil Deakin]

Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

https://reviewboard.mozilla.org/r/221816/#review230970

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/853ef87ccb4f
Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h r=enndeakin+6102

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/853ef87ccb4f