Closed Bug 1439773 Opened 2 years ago Closed 2 years ago

Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

Categories

(Toolkit :: XUL Widgets, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1430777 +++

toolkit/content/widgets/text.xml#text-base role="xul:text"
  description
  toolkit/content/widgets/text.xml#text-label
    label
    toolkit/content/widgets/text.xml#label-control
      label[control]
      label.radio-label
      label.checkbox-label
      label.toolbarbutton-multiline-text

toolkit/content/widgets/text.xml#text-link role="xul:link"
  label.text-link
  label[onclick]
No longer blocks: 1437873
No longer depends on: 1439778
No longer blocks: 1439761
Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

https://reviewboard.mozilla.org/r/221816/#review228004

With accessibility inspector from bug 1151468 I can verify that <label> and <label class="text-link"> are being assigned to correct roles.
Attachment #8952566 - Flags: review?(paolo.mozmail)
Attachment #8952566 - Flags: review?(enndeakin)
Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

https://reviewboard.mozilla.org/r/221816/#review229890

::: accessible/base/XULMap.h:40
(Diff revision 2)
>  XULMAP_TYPE(treecols, XULTreeColumAccessible)
>  XULMAP_TYPE(toolbar, XULToolbarAccessible)
>  XULMAP_TYPE(tooltip, XULTooltipAccessible)
>  
>  XULMAP(
> +  label,

This doesn't handle the case where there is a label with an onclick attribute.

::: accessible/base/nsAccessibilityService.cpp:26
(Diff revision 2)
>  #include "HyperTextAccessibleWrap.h"
>  #include "RootAccessible.h"
>  #include "nsAccUtils.h"
>  #include "nsArrayUtils.h"
>  #include "nsAttrName.h"
> +#include "nsDOMTokenList.h"

This doesn't seem to be used.
Attachment #8952566 - Flags: review?(enndeakin)
Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

https://reviewboard.mozilla.org/r/221816/#review230052

::: accessible/base/XULMap.h:40
(Diff revision 2)
>  XULMAP_TYPE(treecols, XULTreeColumAccessible)
>  XULMAP_TYPE(toolbar, XULToolbarAccessible)
>  XULMAP_TYPE(tooltip, XULTooltipAccessible)
>  
>  XULMAP(
> +  label,

I don't find any `<label onclick>` without `class="text-link"`, so I figured it should be safe to disregard that.

::: accessible/base/nsAccessibilityService.cpp:26
(Diff revision 2)
>  #include "HyperTextAccessibleWrap.h"
>  #include "RootAccessible.h"
>  #include "nsAccUtils.h"
>  #include "nsArrayUtils.h"
>  #include "nsAttrName.h"
> +#include "nsDOMTokenList.h"

`Element::ClassList()` returns `nsDOMTokenList`.
Attachment #8952566 - Flags: review?(paolo.mozmail)
Hi,

I don't see mozreview pick up the review flag; ni just to make sure you are seeing this.
Flags: needinfo?(enndeakin)
Comment on attachment 8952566 [details]
Bug 1439773 - Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h

https://reviewboard.mozilla.org/r/221816/#review230970
Attachment #8952566 - Flags: review?(enndeakin) → review+
Flags: needinfo?(enndeakin)
Pushed by timdream@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/853ef87ccb4f
Move XBL accessibility role="xul:text" and role="xul:link" into XULMap.h r=enndeakin+6102
https://hg.mozilla.org/mozilla-central/rev/853ef87ccb4f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.