Closed Bug 1440678 Opened 2 years ago Closed 2 years ago

Intermittent devtools/client/responsive.html/test/browser/browser_device_change.js | Test timed out -

Categories

(DevTools :: Responsive Design Mode, defect, P3)

Product:
DevTools
Component:
Responsive Design Mode
Type:
defect

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Iteration:
52.1 - Oct 3
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: henrietta_maior, Assigned: jryans)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Bug 1440678 - Disable RDM reload notification for tests.
59 bytes, text/x-review-board-request
ochameau
: review+
Details
Priority: P1 → P5
Whiteboard: [multiviewport][reserve-rdm]
No longer blocks: 1254388
No longer depends on: 1306816
There are 44 failures in the past 44 days.
Platforms: most of occurrences can be seen on Linux x64 asan/ pgo/ opt, linux64-stylo-disabled opt, OS X 10.10 opt, and a few on macosx64-devedition opt, linux64-nightly opt, linux32-devedition opt and Linux opt.
Most recent failure log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=165649916&lineNumber=3939
Relevant part of the log:
[task 2018-03-02T22:19:05.491Z] 22:19:05     INFO - TEST-INFO | started process screentopng
[task 2018-03-02T22:19:05.857Z] 22:19:05     INFO - TEST-INFO | screentopng: exit 0
[task 2018-03-02T22:19:05.858Z] 22:19:05     INFO - TEST-UNEXPECTED-FAIL | devtools/client/responsive.html/test/browser/browser_device_change.js | Test timed out - 
[task 2018-03-02T22:19:05.858Z] 22:19:05     INFO - Removing tab.
[task 2018-03-02T22:19:05.859Z] 22:19:05     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2018-03-02T22:19:05.860Z] 22:19:05     INFO - GECKO(2107) | JavaScript error: resource:///modules/ZoomUI.jsm, line 69: TypeError: win.gBrowser is undefined
[task 2018-03-02T22:19:05.861Z] 22:19:05     INFO - Got event: 'TabClose' on [object XULElement].
[task 2018-03-02T22:19:05.862Z] 22:19:05     INFO - Tab removed and finished closing
[task 2018-03-02T22:19:05.870Z] 22:19:05     INFO - GECKO(2107) | MEMORY STAT | vsize 20973986MB | residentFast 1066MB
[task 2018-03-02T22:19:05.870Z] 22:19:05     INFO - TEST-OK | devtools/client/responsive.html/test/browser/browser_device_change.js | took 180474ms
[task 2018-03-02T22:19:05.961Z] 22:19:05     INFO - checking window state
[task 2018-03-02T22:19:06.002Z] 22:19:06     INFO - TEST-START | devtools/client/responsive.html/test/browser/browser_device_custom.js
[task 2018-03-02T22:19:06.029Z] 22:19:06     INFO - Entering test bound 
[task 2018-03-02T22:19:06.030Z] 22:19:06     INFO - Adding a new tab with URL: data:text/html;charset=utf-8,
[task 2018-03-02T22:19:06.389Z] 22:19:06     INFO - Tab added and finished loading
[task 2018-03-02T22:19:06.389Z] 22:19:06     INFO - Opening responsive design mode
[task 2018-03-02T22:19:06.962Z] 22:19:06     INFO - GECKO(2107) | console.log: "[DISPATCH]" "{\n  \"type\": \"CHANGE_LOCATION\",\n  \"location\": \"about:blank\"\n}"
[task 2018-03-02T22:19:06.962Z] 22:19:06     INFO - GECKO(2107) | console.log: "[DISPATCH]" "{\n  \"type\": \"CHANGE_DISPLAY_PIXEL_RATIO\",\n  \"displayPixelRatio\": 1\n}"
[task 2018-03-02T22:19:06.986Z] 22:19:06     INFO - GECKO(2107) | console.log: "[DISPATCH]" "{\n  \"type\": \"ADD_VIEWPORT\"\n}"
[task 2018-03-02T22:19:07.104Z] 22:19:07     INFO - GECKO(2107) | JavaScript error: chrome://global/content/viewZoomOverlay.js, line 43: TypeError: zoom is undefined
[task 2018-03-02T22:19:07.106Z] 22:19:07     INFO - GECKO(2107) | JavaScript error: resource:///modules/ZoomUI.jsm, line 69: TypeError: win.gBrowser is undefined
[task 2018-03-02T22:19:07.365Z] 22:19:07     INFO - Console message: [JavaScript Error: "TypeError: zoom is undefined" {file: "chrome://global/content/viewZoomOverlay.js" line: 43}]
[task 2018-03-02T22:19:07.365Z] 22:19:07     INFO - Console message: [JavaScript Error: "TypeError: win.gBrowser is undefined" {file: "resource:///modules/ZoomUI.jsm" line: 69}]
[task 2018-03-02T22:19:07.369Z] 22:19:07     INFO - GECKO(2107) | JavaScript error: resource://gre/modules/RemoteAddonsParent.jsm, line 1110: TypeError: cannot use the given object as a weak map key
[task 2018-03-02T22:19:07.392Z] 22:19:07     INFO - Console message: [JavaScript Error: "TypeError: cannot use the given object as a weak map key" {file: "resource://gre/modules/RemoteAddonsParent.jsm" line: 1110}]
[task 2018-03-02T22:19:07.474Z] 22:19:07     INFO - Responsive design mode opened
[task 2018-03-02T22:19:07.474Z] 22:19:07     INFO - Waiting for state predicate "state => state.viewports.length == 1
[task 2018-03-02T22:19:07.475Z] 22:19:07     INFO -     && state.devices.listState == Types.loadableState.LOADED"

:jryans can you please take a look at this?
Flags: needinfo?(jryans)
Whiteboard: [stockwell needswork]
It appears that "sometimes" when we the test resizes the viewport via simulated mouse events, it's only recorded as 9 px change instead of 10 px.

I can't reproduce this locally, but I'll see if I can add some logging to the test to get a better idea on future failures.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Flags: needinfo?(jryans)
Priority: P5 → P3
Comment on attachment 8957011 [details]
Bug 1440678 - Disable RDM reload notification for tests.

https://reviewboard.mozilla.org/r/225972/#review231948

Wha, good catch!
Attachment #8957011 - Flags: review?(poirot.alex) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ea80ceed7810
Disable RDM reload notification for tests. r=ochameau
https://hg.mozilla.org/mozilla-central/rev/ea80ceed7810
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.