Closed
Bug 1441388
Opened 6 years ago
Closed 6 years ago
browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js fails after bug 1193394
Categories
(Firefox :: Enterprise Policies, defect)
Firefox
Enterprise Policies
Tracking
()
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
https://treeherder.mozilla.org/logviewer.html#?job_id=164510419&repo=try&lineNumber=4119 > 17:13:50 INFO - Entering test bound test_policy_disable_masterpassword > 17:13:50 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | Starting the test with no password - > 17:13:50 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | The device tree exists - > 17:13:50 INFO - Buffered messages finished > 17:13:50 INFO - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | Change Password button is in the correct state: false - Got true, expected false > 17:13:50 INFO - Stack trace: > 17:13:50 INFO - chrome://mochikit/content/browser-test.js:test_is:1271 > 17:13:50 INFO - chrome://mochitests/content/browser/browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js:checkDeviceManager:34 > ... > 17:13:51 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | Master Password checkbox is in the correct state: false - > 17:13:51 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | Sanity check the temporary file doesn't exist. - true == true - > 17:13:51 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | The device tree exists - > 17:13:51 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | Change Password button is in the correct state: true - > ... > 17:13:52 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | Master Password checkbox is in the correct state: true - > 17:13:52 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | Master password was set - > 17:13:52 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | The device tree exists - > 17:13:52 INFO - Not taking screenshot here: see the one that was previously logged > 17:13:52 INFO - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js | Change Password button is in the correct state: false - Got true, expected false > 17:13:52 INFO - Stack trace: > 17:13:52 INFO - chrome://mochikit/content/browser-test.js:test_is:1271 > 17:13:52 INFO - chrome://mochitests/content/browser/browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js:checkDeviceManager:34
Assignee | ||
Comment 1•6 years ago
|
||
reproduced locally. taking
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
After fixing bug 1193394, the resolution handler for the promise for "load" event runs earlier than before. BrowserTestUtils.waitForEvent can be used to wait for the next event tick after the event handler is called.
Attachment #8954254 -
Flags: review?(dkeeler)
Comment on attachment 8954254 [details] [diff] [review] Use BrowserTestUtils.waitForEvent in browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js I'm not a browser peer but I'm sure this should be fine.
Attachment #8954254 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 4•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ea447c2e10fe0f797a09bdd13edddc01c1732a9 Bug 1441388 - Use BrowserTestUtils.waitForEvent in browser/components/enterprisepolicies/tests/browser/browser_policy_disable_masterpassword.js r=keeler
Comment 5•6 years ago
|
||
Paolo, this is the last blocker of bug 1193394 (We will disable bug 1441424). Could you please take time to review the patch? Thanks!
Flags: needinfo?(paolo.mozmail)
Assignee | ||
Comment 6•6 years ago
|
||
the change is already merged to m-c https://hg.mozilla.org/mozilla-central/rev/4ea447c2e10f (In reply to Hiroyuki Ikezoe (:hiro) from comment #5) > Paolo, this is the last blocker of bug 1193394 (We will disable bug > 1441424). Could you please take time to review the patch? Thanks! bug 1439472 is ;)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•6 years ago
|
||
moved ni? to bug 1439472 comment #23
Flags: needinfo?(paolo.mozmail)
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4ea447c2e10f
Assignee | ||
Updated•6 years ago
|
status-firefox60:
--- → fixed
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•