1441942 - Migration creates broken FTL for Arabic when missing a zero case

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: Fluent Migration, enhancement)

Description

[Francesco Lodolo [:flod]]

Migration code generated two broken plural forms for Arabic, fixed in this changeset by removing the empty [zero] form.
https://hg.mozilla.org/l10n-central/ar/rev/fbbc5b00392d1ea7d3fad60eaa4c2d40238f5619

This happened because the origin string has an empty zero form
https://hg.mozilla.org/l10n-central/ar/file/7c077d8e0a59/browser/chrome/browser/preferences/preferences.properties#l253

The empty string should be serialized as {""}, but in this specific case (plurals) we should likely just drop the empty variant.

Comment 1

[Francesco Lodolo [:flod]]

NI on Stas to pick his brain :)

Comment 2

[Staś Małolepszy :stas]

Dropping empty variants sounds good but we should make sure we support the edge cases like `key=` and `key=;` in the legacy translations. I should also add checks to make sure empty TextElements are converted to {""} in the resulting AST. And in general, I'd like to write a few more tests for handling empty legacy values like `key=`.

Can this wait a bit? I can work on this when I'm back from being sick.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Staś Małolepszy :stas from comment #2)
> Can this wait a bit? I can work on this when I'm back from being sick.

Definitely. The Arabic bug was already fixed.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Staś Małolepszy :stas from comment #2)
> Dropping empty variants sounds good but we should make sure we support the
> edge cases like `key=` and `key=;` in the legacy translations. I should also
> add checks to make sure empty TextElements are converted to {""} in the
> resulting AST. And in general, I'd like to write a few more tests for
> handling empty legacy values like `key=`.

Found another error due to empty strings
https://l10n.mozilla.org/dashboard/compare?run=924810#issue1
https://hg.mozilla.org/l10n-central/si/file/f1da9ec0c3f6/browser/browser/preferences/preferences.ftl#l196

Comment 5

[Staś Małolepszy :stas]

Attachment: Pull Request

Comment 6

[Staś Małolepszy :stas]

Fixed as part of https://github.com/projectfluent/python-fluent/commit/6e14e772c973f54a7692bcfbd2a8932107e8c8b5.