1442684 - refactor beetmoverscript to strip it of all the hacks

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Uploading, enhancement)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

In bug 1424482 :jlorenzo added support for in-tree payload which makes it easy to be consistent with several tasks as the former way of doing it, via balrog_props, basically sucks and is unreliable the more we need more products (e.g TB, more fennec, etc).

For that reason, we need to:
* prep a PR that kills balrog_props altogether
* all in-tree tasks need to have relprops payload, correctly specified
* all the hacks/checks depending on platform/stage_platform need to go away as soon as possible

More motivation for this lies within TB difficulties to set those fields properly. See bug 1437586 for more details.

Other changes that could be implemented along the way are:
* https://trello.com/c/fwJruFlS/186-rewrite-the-beetmover-dependency-system-its-dirty-and-not-flexible-enough-to-meet-our-needs
* https://trello.com/c/Soc8Pz6X/243-beetmoverscript-other-improvements

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Bug 1445910 will remove balrog_props from tree. Let's make sure we cleanup beetmover by then too, targeting 61.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Note to self: to reiterate, reread https://trello.com/c/Soc8Pz6X/243-1442684-beetmoverscript-other-improvements for more ideas on what to get along there.

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Some of this are to be addressed with upcoming work for declarative artifacts.

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: [beetmoverscript] strip of bouncer.apk as it seems unused

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 9020733 [details] [review]
[beetmoverscript] strip of bouncer.apk  as it seems unused

r+ by Callek and Johan in the PR.
Landed to production with the 7.10.1 bump today.

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Most of bugs are now done here. We can close this.