1449150 - remove beetmoverscript support for balrogProps

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Uploading, enhancement, P1)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

In bug 1445910 we're stripping away the balrog props creation from mozharness. Let's make sure we're prepped in all the bits in our release automation trees to support this change. (build/signing/beetmover/balrog/etc).

This means that once 61 hits beta, we should no longer have balrog props as created artifact, consumed artifact, transferred artifact. 

This bug is to track all that work and (most likely) code removal / replacement.
Some of the work for beetmover has already been conducted in bug 1424482

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Let's narrow down the efforts of this bug to simply strip the balrog props stuff from beetmoverscript 

Again, for context: BalrogProps used to be a file generated at build time that we passed along the graph as dependency. It contained useful information like "product", "version", "locale", "stage platform" and such. That started to complicate our dependency schema a bit while the values in beetmover were not as useful once we added nightlies, devedition, fennec, release ,etc. 

At some point in bug 1424482, we started supporting a different in-tree payload `releaseProperties` dictionary that's used now in almost all beetmover jobs, if not all. Which makes the balrog props kind of useless. For that reason I think we should simply kill it:

a) first, from beetmoverscript repo altogether (both as dep, as processed item, and as created artifact for balrog jobs)
b) from tree, to avoid unnecesary manuevring with it in scriptworkers

Comment 2

[Lisa Guo [:lguo] EST]

Attachment: balrog_props stripped from beetmoerscript src and tests

now onto stripping balrog_props dependencies from central

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8981852 [details] [review]
balrog_props stripped from beetmoerscript src and tests

I imported your PR in a separate one in which I appended some fixes. 
Looks good, just some tiny nits that needed some massage. 


https://github.com/mozilla-releng/beetmoverscript/pull/153

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

We've rolled-out 7.3.0 to production beetmoverworkers to encompass this PR.
This is now done, thank you again for this useful cleanup!