1445910 - Remove balrog support from mozharness

Status: NEW

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Chris AtLee [:catlee]]

Similar to bug 1441495, we no longer need Balrog support inside mozharness. The mixin and all references to it can be removed.

https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/updates/balrog.py

Comment 1

[Venkatesh Prabhu :vprabhu]

I will take this up. I will start here: https://searchfox.org/mozilla-central/search?q=balrogmixin&path=

Looks like it's assigned to me just now. Thanks, Chris.

Comment 2

[Venkatesh Prabhu :vprabhu]

I looked into this and got a couple of doubts, Chris! 

1) In buildbase.py, should this entire method be removed?(Submit balrog Update steps).  https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#1711

If yes, should this 'if block' be also gone? https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#142
As the comment says this code is for balrog submission.

2) The submit_to_balrog() should be removed? https://searchfox.org/mozilla-central/source/testing/mozharness/scripts/mobile_l10n.py#613 

And all the config_options related to balrog? (balrog-api-root, user name, credentials file etc.,)

Comment 3

[Chris AtLee [:catlee]]

(In reply to Venkatesh Prabhu :vprabhu from comment #2)
> I looked into this and got a couple of doubts, Chris! 
> 
> 1) In buildbase.py, should this entire method be removed?(Submit balrog
> Update steps). 
> https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/
> mozilla/building/buildbase.py#1711

Yes, I think it should. :mtabara should be able to tell us if those properties are required by downstream tasks.

> If yes, should this 'if block' be also gone?
> https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/
> mozilla/building/buildbase.py#142
> As the comment says this code is for balrog submission.

Yes, I think that should be deleted as well.

> 2) The submit_to_balrog() should be removed?
> https://searchfox.org/mozilla-central/source/testing/mozharness/scripts/
> mobile_l10n.py#613 

Yup!

> And all the config_options related to balrog? (balrog-api-root, user name,
> credentials file etc.,)

Yes, I think so.

Comment 4

[Venkatesh Prabhu :vprabhu]

(In reply to Chris AtLee [:catlee] from comment #3)
> (In reply to Venkatesh Prabhu :vprabhu from comment #2)
> > I looked into this and got a couple of doubts, Chris! 
> > 
> > 1) In buildbase.py, should this entire method be removed?(Submit balrog
> > Update steps). 
> > https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/
> > mozilla/building/buildbase.py#1711
> 
> Yes, I think it should. :mtabara should be able to tell us if those
> properties are required by downstream tasks.
> 
> > If yes, should this 'if block' be also gone?
> > https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/
> > mozilla/building/buildbase.py#142
> > As the comment says this code is for balrog submission.
> 
> Yes, I think that should be deleted as well.
> 
> > 2) The submit_to_balrog() should be removed?
> > https://searchfox.org/mozilla-central/source/testing/mozharness/scripts/
> > mobile_l10n.py#613 
> 
> Yup!
> 
> > And all the config_options related to balrog? (balrog-api-root, user name,
> > credentials file etc.,)
> 
> Yes, I think so.

I am waiting for the information from Mihai. Please let me know when I can proceed.

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Sorry for delays, I've been out in PTO but forgot to update my bugzilla handle!

Yep, we no longer need any of the buildprops, we're gonna craft everything in-tree. 
Also, balrog subsmission is now done in 60+ via balrogworkers which no longer make use of mozharness.

Let's strip all this down!

Will file a bug as well in our RelEng side to make sure we're tracking all the existing cases where we support both the old-way (via mozharness) and the new ways (via in-tree taskcluster kind.yml).

Comment 6

[Venkatesh Prabhu :vprabhu]

(In reply to Chris AtLee [:catlee] from comment #3)
> (In reply to Venkatesh Prabhu :vprabhu from comment #2)
> > I looked into this and got a couple of doubts, Chris! 
> > 
> > 1) In buildbase.py, should this entire method be removed?(Submit balrog
> > Update steps). 
> > https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/
> > mozilla/building/buildbase.py#1711
> 
> Yes, I think it should. :mtabara should be able to tell us if those
> properties are required by downstream tasks.
> 
> > If yes, should this 'if block' be also gone?
> > https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/
> > mozilla/building/buildbase.py#142
> > As the comment says this code is for balrog submission.
> 
> Yes, I think that should be deleted as well.
> 
> > 2) The submit_to_balrog() should be removed?
> > https://searchfox.org/mozilla-central/source/testing/mozharness/scripts/
> > mobile_l10n.py#613 
> 
> Yup!
> 
> > And all the config_options related to balrog? (balrog-api-root, user name,
> > credentials file etc.,)
> 
> Yes, I think so.

Sorry about the delay. I was on a vacation. Here's the link to the try results for linux build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c17509974a70db5fb8ad7e85f437546fcdf9604b

Comment 7

[Chris AtLee [:catlee]]

Looks pretty good!

I think we need to also remove references to the 'update' action, e.g. https://hg.mozilla.org/try/file/ef19d904882deb92a79473e5a6949c7b01e56fad/testing/mozharness/scripts/fx_desktop_build.py#l43 and https://hg.mozilla.org/try/file/ef19d904882deb92a79473e5a6949c7b01e56fad/testing/mozharness/configs/builds/taskcluster_sub_win32/opt.py#l5

Comment 8

[Venkatesh Prabhu :vprabhu]

(In reply to Chris AtLee [:catlee] from comment #7)
> Looks pretty good!
> 
> I think we need to also remove references to the 'update' action, e.g.
> https://hg.mozilla.org/try/file/ef19d904882deb92a79473e5a6949c7b01e56fad/
> testing/mozharness/scripts/fx_desktop_build.py#l43 and
> https://hg.mozilla.org/try/file/ef19d904882deb92a79473e5a6949c7b01e56fad/
> testing/mozharness/configs/builds/taskcluster_sub_win32/opt.py#l5

Thank you Chris. How can I figure out the remaining references to update? (If any).

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

Some of this work, (if not all, at least for l10n stuff) is being done in bug 1466222 by Callek.

Comment 10

[Mihai Tabara [:mtabara]⌚️GMT]

:Callek - can we close this? I think you've taken most of the stuff in your large cleanup bug, right?

Comment 11

[Justin Wood (:Callek)]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #10)
> :Callek - can we close this? I think you've taken most of the stuff in your
> large cleanup bug, right?

I think there is still a bunch of work here, my cleanup bug was just l10n. And there are still some lingering references: https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+balrog&redirect=false

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.