1442945 - DND failures in Places menus

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: Drop insertion indicator would not display in Bookmarks Menu


Reproducible: always

Steps To Reproduce:
1. Enable Menubar
2. Drag any link over in Bookmarks menu
3. Drag it over memupopup


Actual Results:
Drop insertion indicator would not display

Expected Results:
Drop insertion indicator should display

egression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=61165dc3f54a7d05455a2f28604adedf4d98cd10&tochange=b05ca0b26e73a43db099b82ff3606cb867878f16


Regressed by: Bug 1439315

Comment 1

[Alice0775 White]

Actual Results:
Drop insertion indicator would not display.
And always drops a link at bottom.

Expected Results:
Drop insertion indicator should display.
And the drag&drop link should be inserted the indicated position.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1442945 - Fix DND in Places menus.

Review commit: https://reviewboard.mozilla.org/r/224874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224874/

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8955878 [details]
Bug 1442945 - Fix DND in Places menus.

https://reviewboard.mozilla.org/r/224874/#review230904

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d97c0342dc0d
Fix DND in Places menus. r=standard8

Comment 9

[Michal Čaplygin [:myf]]

For record, such summary ("DND failures in Places menus") is quite undiscoverable for uninitiated reporters; FMPoW it lacks nearly anything potential (dupe) reporter could search for.

Comment 10

[Marco Bonardo [:mak]]

All the other dupes are connected to this bug and have better titles, they should appear as suggestions when a new bug gets filed, afaik.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d97c0342dc0d