Closed Bug 1443812 Opened 2 years ago Closed 2 years ago

Update harfbuzz to 1.7.6

Categories

(Core :: Graphics: Text, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: jfkthame, Assigned: RyanVM)

References

Details

Attachments

(1 file)

I know we just landed 1.7.5 a week ago, but 1.7.6 includes the fix for https://github.com/harfbuzz/harfbuzz/issues/863, which I think potentially affects our code that determines whether the word cache can safely be used during shaping. As such, we should probably try to slip this update into 60.
Ryan, if you have time to do a quick try run and put up a patch here, that would be awesome - thanks!
Flags: needinfo?(ryanvm)
Assignee: nobody → ryanvm
Flags: needinfo?(ryanvm)
As you already are aware of, I had to avoid building the newly-added hb-subset stuff for now due to upstream issue #865. I added the files to the patch, but they'll need to be added to moz.build if/when we intend to use that functionality.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcbf4a3bba07198a1796a75efed310513c718ce9
Attachment #8956900 - Flags: review?(jfkthame)
Comment on attachment 8956900 [details] [diff] [review]
Update HarfBuzz to version 1.7.6

Review of attachment 8956900 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Yes, we'll worry about hb-subset.cc if/when we want to use it; I expect quite a bit of ongoing churn there anyhow for the time being. (A number of the other new files from the last couple of releases aren't currently needed for our build either, but that's OK, the linker will just leave out the unused stuff.)
Attachment #8956900 - Flags: review?(jfkthame) → review+
We can also try to give better support for dominant-baseline property based on this, since this version get support for BASE table.
https://hg.mozilla.org/mozilla-central/rev/32da8b4abfd7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Blocks: 1467108
You need to log in before you can comment on or make changes to this bug.