1445266 - New Tab page elements are not rendered in High Contrast mode (Windows theme)

Status: RESOLVED INVALID

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: IMG_13032018_164624_0.png

[Affected versions]:
- Firefox 57 and up

[Affected Platforms]:
- All Windows

[Prerequisites]:
- Latest Activity Stream system add-on is available for a clean profile.

[Steps to reproduce]:
1. Go to High Contrast settings in Windows.
2. Choose a different theme. (High Contrast 1, High Contrast 2, High Contrast Black, High Contrast White)
3. Open the browser with the profile from prerequisites.
4. Observe the Search bar, Top Sites, Highlights and Context menu elements.

[Expected result]:
- All the elements of the page are rendered and the high contrast theme is correctly applied.

[Actual result]:
- The Search bar:
    No search icon is visible
    The arrow is not visible in the search button and it has no hover effect.
    Search suggestions have no hover effect.

- Top Sites and Highlights:
    The tiles have no hover effect.
    The context menu button and the options within have no icons.
    The context menu options have no hover effect.
    Section context menu is not visible.

Comment 3

[Daniel Bodea [:danibodea]]

Updating flags.

Comment 4

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: high contrast 1.png

Comment 5

[Maria Heres, inactive, contact Ecosystem QA]

I can still reproduce this in Firefox Beta 85.0b5 (Build ID: 20210105185604), Firefox Release 84.0.2 (Build ID: 20210105180113), Firefox Nightly 86.0a1 (Build ID: 20210107040715) using Windows 10.

Comment 6

[kbryant]

Don't have permissions to add this as a whiteboard flag: [fidefe-quality-foundation]

Comment 7

[Molly Howell (she/her) (mostly inactive)]

The majority of the elements mentioned here are no longer present in the current new tab design, and most of the ones that are present seem to have been fixed.

The one thing that I do still see is the top site tile hover effect being entirely missing; I would guess that this is because it's implemented entirely as a background color change, and in high contrast we're not rendering the background.

It seems like in other parts of the browser we're using the selected text color as the background for this kind of hover effect, so I'm assuming that's what should be here also. I would also think that there should be a border around the tile in high contrast, whether its hovered or not. We should make sure I'm on the right track with that before anything gets landed though.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:amy, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 9

[Amy Churchwell [:amy]]

The new tab page recently went under an accessibility review. The remaining issues here will be addressed in bug 1893056 and bug 1893730.

See also: [meta] Firefox surfaces should use standardised HCM components.