1446657 - Backspacing in options search makes the window/scrollbar flicker

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[Jason]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180316220124

Steps to reproduce:

1. Go to about:preferences#general
2. In the options search box (the one that has the words "Find in Options"), type the following: asdfjkl
3. Press the backspace key.


Actual results:

The scrollbar on the right flickers for a fraction of a second.  Each backspace makes this happen.


Expected results:

The scrollbar should not appear at all.  The window should more gracefully handle the lack of search results.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

While triaging this I decided to just fix it because it looks pretty bad and the effort to write up the steps for a new contributor was more than just fixing this particular bug.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1446657 - Refactor preferences search code to remove flickering and scrollbar appearing/disappearing.

Review commit: https://reviewboard.mozilla.org/r/229114/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229114/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8960358 [details]
Bug 1446657 - Refactor preferences search code to remove flickering and scrollbar appearing/disappearing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229114/diff/1-2/

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8960358 [details]
Bug 1446657 - Refactor preferences search code to remove flickering and scrollbar appearing/disappearing.

https://reviewboard.mozilla.org/r/229114/#review235214

Looks good, works well. Just the one nit/cleanup needed that I can see.

::: browser/components/preferences/in-content/findInPage.js:306
(Diff revision 2)
>              Services.telemetry.keyedScalarAdd("preferences.search_query", this.query, 1);
>            }, 1000);
>          }
>        }
>      } else {
> -      document.getElementById("sorry-message").textContent = "";
> +      noResultsEl.hidden = true;

This is already hidden on line 284, when you assign noResultsEl.hidden = !!resultsFound, right?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8960358 [details]
Bug 1446657 - Refactor preferences search code to remove flickering and scrollbar appearing/disappearing.

https://reviewboard.mozilla.org/r/229114/#review235214

> This is already hidden on line 284, when you assign noResultsEl.hidden = !!resultsFound, right?

No, because this is in the `else` branch, where `resultsFound` is not defined.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d015e9c711f4
Refactor preferences search code to remove flickering and scrollbar appearing/disappearing. r=sfoster

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> 
> > This is already hidden on line 284, when you assign noResultsEl.hidden = !!resultsFound, right?
> 
> No, because this is in the `else` branch, where `resultsFound` is not
> defined.

Ah, I see, this is the outer block where this.query is falsey. Ok thanks.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Sam Foster [:sfoster] from comment #7)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> > 
> > > This is already hidden on line 284, when you assign noResultsEl.hidden = !!resultsFound, right?
> > 
> > No, because this is in the `else` branch, where `resultsFound` is not
> > defined.
> 
> Ah, I see, this is the outer block where this.query is falsey. Ok thanks.

No problem :) thanks for looking at this :)

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/d015e9c711f4

Comment 10

[Sajedul Islam]

I have reproduced this bug with Nightly 61.0a1 (2018-03-17) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20180327105613
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

[bugday-20180328]

Comment 11

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 61.0a1 (2018-03-17) on Ubuntu 16.04 LTS!

This bug's fix is Verified with latest Nightly !

Build   ID    20180331101347
User Agent    Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Comment 12

[Sajedul Islam]

As par comment 10 and comment 11 , i am marking this bug as verified fixed !