1446762 - Graphical issue with skin for Nightly

Status: RESOLVED FIXED

Description

[wqese2]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180317220121

Steps to reproduce:

Once opened Nightly window on 1080p monitor, and moved into 1440p monitor,  Skin doesn't adjust, and just have this greenish spot.
https://i.imgur.com/vovfekq.png


Actual results:

https://i.imgur.com/vovfekq.png


Expected results:

Adjust skin width correctly.

did not have this problem with Firefox quantum.

Comment 1

[Carmen Fat [:carmenf] - Experiments QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

Hi wqese2, thanks for reporting this issue.

I wasn't able to reproduce the issue on Windows 10 x64, using latest Nightly 61.0a1 (2018-03-21) and Firefox Release 59.0.1. 
I've set the following values for the monitors:
- monitor 1: 1920 x 1080
- monitor 2: 1440 x 900

After setting the custom values for resolution, I've installed the theme you are using (https://addons.mozilla.org/en-US/firefox/addon/deep-dark-blue-forest/?src=collection&collection_id=325c993e-0379-4151-adb5-ad28dccc41fd), but I wasn't able to reproduce the issue you described after moving the browser window between the 2 screens.

Could you please retest this issue using a new clean Firefox profile (https://goo.gl/7Fec9d), maybe even safe mode (https://goo.gl/AR5o9d), to eliminate custom settings as a possible cause?

Thanks.

Comment 2

[wqese2]

Okay, did it on clean profile, Its the same

But this time i know exactly when this happens.

Made video explaining:

https://youtu.be/YUVNcr1SA4c



I have 2 screens

One bigger   2560x1440

Smaller  1920x1080

When My browser first opens on Bigger screen,  there is no problem.

If it opens first on small screen,  and I move it and maximize to bigger screen,  theme doesn't adjust.

Comment 3

[wqese2]

Checked also  on 59.0.1   It works as it should. no matter on which screen window opens first

Comment 4

[Carmen Fat [:carmenf] - Experiments QA]

Tested again using the following resolutions available:2560 x 1440 and 1680 x 1050 and managed to reproduce it intermittently on Nightly 61.0a1 (2018-03-29).

I'll try to narrow down a regression window asap.

Comment 5

[Dão Gottwald [::dao]]

(In reply to Carmen Fat [:carmenf] from comment #4)
> I'll try to narrow down a regression window asap.

Any update?

Comment 6

[Carmen Fat [:carmenf] - Experiments QA]

Sorry for the delay!

I have tested this issue on Windows 10 x64, using the STR  from comment 2, performed a regression, the result as follows:

Last good revision: 994a8d6eccbcdc6106794705bd77e3ac5f031be2 (2018-02-15)
First bad revision: c4d818c138689a66a397393fe1dd259ef0943b35 (2018-02-16)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=994a8d6eccbcdc6106794705bd77e3ac5f031be2&tochange=c4d818c138689a66a397393fe1dd259ef0943b35

I wasn't able to bisect more since the tool didn't provide me more builds, so this is the best I could do.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Might be bug 1438573? Is that plausible, Dao?

Comment 8

[Dão Gottwald [::dao]]

(In reply to Mike Conley (:mconley) (:⚙️) (Totally backlogged on reviews and needinfos) from comment #7)
> Might be bug 1438573? Is that plausible, Dao?

Yeah, looks like I removed too much.

Comment 9

[Dão Gottwald [::dao]]

Attachment: Bug 1446762 - Update the lwt header image on resolution change.

This was previously implemented using the resize event, and was wrongly removed in bug 1438573.

Review commit: https://reviewboard.mozilla.org/r/238408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238408/

Comment 10

[Matthew N. [:MattN] (PM me if requests are blocking you)]

Comment on attachment 8969624 [details]
Bug 1446762 - Update the lwt header image on resolution change.

https://reviewboard.mozilla.org/r/238408/#review244318

This should work but I have never heard of `resolutionchange` so know if it works on every platform.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a2fedfeaa96
Update the lwt header image on resolution change. r=MattN

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3a2fedfeaa96

Comment 13

[Dão Gottwald [::dao]]

wqese2, would you please check if this is fixed for you in the latest Nightly?

Comment 14

[wqese2]

Sorry, i tested both in my profile, and that clean one i created to test it last time.
Still same issue.

https://youtu.be/VeLlpZxlMiQ

Comment 15

[Dão Gottwald [::dao]]

Attachment: bug 1438573 backout for uplift

Approval Request Comment
[Feature/Bug causing the regression]: bug 1438573
[User impact if declined]: lightweight theme header image can be too small in a multi-monitor setting
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: see comment 2
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple backout
[String changes made/needed]: /

Comment 16

[Liz Henry (:lizzard) (use needinfo)]

Dão, from comment 14 it sounds like it might not be fixed in the first patch. 

Carmen, can you reproduce this on nightly, or verify the fix? Thanks!

Comment 17

[Dão Gottwald [::dao]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #16)
> Dão, from comment 14 it sounds like it might not be fixed in the first
> patch. 

I'm still investigating that, but that patch is not what I want to uplift anyway.

Comment 18

[Julien Cristau [:jcristau]]

Comment on attachment 8970448 [details] [diff] [review]
bug 1438573 backout for uplift

backout bug 1438573 for causing a regression, approved for 60.0b16

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8bfb96be15cb

Comment 20

[Carmen Fat [:carmenf] - Experiments QA]

Tested again on latest Nightly 61.0a1 (2018-04-26) using Windows 10 x64. I wasn't able to reproduce the issue anymore. The theme rendered correctly to the new resolution of the second monitor.

Comment 21

[Dão Gottwald [::dao]]

I think I found the missing pieces that prevent this from working consistently; filed bug 1457186 and bug 1457189.

Comment 22

[wqese2]

Hi guys,

I'm on new system now (upgraded a lot), and that smnall bug was one of first thing I tried after fresh windows install and some drivers.
It's not fixed yet. 
Theme still wont adjust when moving nightly from smaller screen to bigger one.