Closed Bug 1447037 Opened 6 years ago Closed 6 years ago

Many crashes contain "WR: ERROR: Invalid window dimensions! Please call api.set_window_size()" message

Categories

(Core :: Graphics: WebRender, defect, P2)

Product:
Core
Component:
Graphics: WebRender
Platform:
Unspecified
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- unaffected
firefox60 --- disabled
firefox61 --- disabled
firefox62 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Keywords: regression, Whiteboard: [gfx-noted]) 

From https://bugzilla.mozilla.org/show_bug.cgi?id=1446681#c2, there are many crash reports that contain the string "WR: ERROR: Invalid window dimensions! Please call api.set_window_size()" in the GraphicsCriticalError.

We should find out why this is happening and fix it.

Also puzzling is that error message is one of two variants (see [1]), and this variant should only occur when the scene builder thread is enabled, which shouldn't be the case. So I don't know what's up with that.

[1] https://searchfox.org/mozilla-central/search?q=Invalid%20window%20dimensions
(Jan Andre Ikenmeyer [:darkspirit] from bug 1442608 comment 10)
> Created a fresh profile, then I set webrender.all + force-angle=false and restarted:
> > (#0) 	GP+[GFX1-]: WR: ERROR: Invalid window dimensions! Please call api.set_window_size()

If the window is white: Just Ctrl+A, Ctrl+C and paste into a text editor.
mozregression --good 2018-02-15 --bad 2018-03-02 --pref gfx.webrender.all:true gfx.webrender.force-angle:false startup.homepage_welcome_url:"about:support"
> 9:20.75 INFO: Last good revision: cfc5d19e856fc43766669069b7e2695dd519e5c3
> 9:20.75 INFO: First bad revision: 81f389c2524e58b4b95844667719cc1642573019
> 9:20.75 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cfc5d19e856fc43766669069b7e2695dd519e5c3&tochange=81f389c2524e58b4b95844667719cc1642573019

(2018-03-01)
> 81f389c2524e	Kartikaya Gupta — Bug 1440664 - Update reftest annotation for changes in WR PR 2471. r=jrmuizel
> 507a25c3afd0	Kartikaya Gupta — Bug 1440664 - Update reftest annotation for WR PR 2443. r=jrmuizel
> 6098d2c015d7	Kartikaya Gupta — Bug 1440664 - Re-generate FFI header. r=jrmuizel
> a5991299ebd0	Kartikaya Gupta — Bug 1440664 - Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
> c066c419e378	Martin Robinson — Bug 1440664 - Update gecko WR bindings for API changes in WR PR 2449. r=kats
> 6f54af02c2e6	Kartikaya Gupta — Bug 1440664 - Update webrender to commit 22b831c02479eea31821f49a0fac7dd699083557. r=jrmuizel

try builds from bug 1440664:
> WR @ 992dbd3f07b143f35581012082aa59fbda7c387e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4916bd1bb3e9470ea106ebf45859b68b2a1b474c
mozregression --repo try --launch 4916bd1bb3e9470ea106ebf45859b68b2a1b474c --pref gfx.webrender.all:true gfx.webrender.force-angle:false startup.homepage_welcome_url:"about:support"
white, but good
good
white, but good

> WR @ 0b711f2e514107361deef4297c3c7da794d4835c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cbf4580d196e5997b2ca7f8ce4fa26b49e47b0f
mozregression --repo try --launch 9cbf4580d196e5997b2ca7f8ce4fa26b49e47b0f --pref gfx.webrender.all:true gfx.webrender.force-angle:false startup.homepage_welcome_url:"about:support"
white, bad
white, bad
white, bad

Regression range: https://github.com/servo/webrender/compare/992dbd3f07b143f35581012082aa59fbda7c387e...0b711f2e514107361deef4297c3c7da794d4835c
(bug 1445723 has the same range.)

With gfx.webrender.force-angle=true I do not see this message.
There were some crashes with this message even before it became permanently visible with force-angle=false:
https://crash-stats.mozilla.com/search/?graphics_critical_error=~WR%3A%20ERROR%3A%20Invalid%20window%20dimensions%21%20Please%20call%20api.set_window_size%28%29&date=%3E%3D2018-02-01T01%3A33%3A00.000Z&date=%3C2018-03-03T01%3A33%3A00.000Z&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports
Blocks: 1440664
Has Regression Range: --- → yes
status-firefox59: --- → unaffected
status-firefox60: --- → disabled
status-firefox61: --- → disabled
status-firefox-esr52: --- → unaffected
Keywords: regression
OS: Unspecified → Windows 10
Version: Other Branch → Trunk
I'm not able to reproduce this.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> I'm not able to reproduce this.

Hm. Maybe it depends on the screen size (2560x1440) / layout.css.devPixelsPerPx?
I kicked off a try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4c2d08243426aa6b4bd27adbbaceca5f6216315 with some extra logging/panics. Can you try to reproduce on that build and see what happens? I'm interested in any critical errors that get reported or crash reports/stacktraces that get generated.
Flags: needinfo?(jan)
It's probably nondeterministic/racy behaviour, and so random changes will appear to introduce or fix it.
See Also: → 1441392
Assignee: nobody → sotaro.ikeda.g
The next WR update should address this error.
Assignee: sotaro.ikeda.g → bugmail
Depends on: 1462611
See Also: → https://github.com/servo/webrender/pull/2766
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
status-firefox62: --- → fixed
status-firefox-esr60: --- → unaffected
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.