1432261 - regression: wrong backgrounds when gfx.webrender.force-angle=false

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Darkspirit]

Attachment: angle-false.png

Nightly 59 x64 20180122100120 de_DE @ Windows 10 1709 (Radeon RX480)

(I know this is less interesting for you. Maybe it broke something else, too.)

Windows PowerShell:
mozregression --good 2017-12-01 --bad 2018-01-10 --pref gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true gfx.webrender.force-angle:false
> 7:41.47 INFO: Last good revision: 6500c02faddf82983d563a6d1fd9fe47b281884f
> 7:41.47 INFO: First bad revision: ba269efce3cedf4a733276b913135febb5be3228
> 7:41.47 INFO: Pushlog:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6500c02faddf82983d563a6d1fd9fe47b281884f&tochange=ba269efce3cedf4a733276b913135febb5be3228

non-WR commit:
> ba269efce3ce	Jeff Gilbert — Bug 1347731 - Simplify WGL initialization code. - r=daoshengmu

After 2018-01-11 09:43 (bug 1425260 comment 9) prefs are:
gfx.webrender.all;true (activate WebRender) + gfx.webrender.force-angle;false (non-default)

Comment 1

[Henrik Winnemöller]

Attachment: angle-false-w7-rx460-driver17.4.4.png

User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180213220104
GPU: AMD Radeon RX 460
Driver: Crimson ReLive 17.4.4

I can reproduce the bright background on "About Nightly" but not the different background on about:newtab at the same time.

Note: This is on Windows 7, not Windows 10.

Comment 2

[Darkspirit]

Attachment: invisible-image.png

I noticed that even regular images are missing. The close window button doesn't get red when hovering it.
URL: https://perfektesgewicht.de/wp-content/uploads/2016/03/Leben-ohne-Kohlenhydrate-600x303.jpg

Comment 3

[Darkspirit]

@jgilbert Could you have a look, please? Maybe there's an easy fix?

https://hg.mozilla.org/mozilla-central/rev/ba269efce3ce#l1.67
This line of your change reminds me a bit of bug 1401455 (Ctrl+F depth).

(And in bug 1446681 Nvidia has problems with gfx.webrender.force-angle=false.)

Comment 4

[Kelsey Gilbert [:jgilbert]]

Routing to jrmuizel.

Comment 5

[Darkspirit]

force-angle=false on Win10 has been fine before and everything was exactly like on Debian Testing. (Radeon RX 480, Polaris)
This is the only regression of force-angle=false. bug 1347731 pushed a rebase with a year old r+ and broke this.

WTF bug: bug 1430321 (may be already fixed?)
Positive effects of angle=false: bug 1411503 (faster), bug 1437559 (able to use WR at all), bug 1447037 (easier to reproduce)

Comment 6

[Jeff Muizelaar [:jrmuizel]]

I don't have anything to add, and gfx.webrender.force-angle=false is not a priority right now.

Comment 7

[Sotaro Ikeda [:sotaro]]

From the symptom, depth seems not enabled.

Comment 8

[Sotaro Ikeda [:sotaro]]

Before Bug 1347731, depth was enabled for WebRender. But it was removed by Bug 1347731.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable depth for WebRender

Comment 10

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1a657d8baf5dff4bc4592656b1a69625f281387

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92bd25aaba89
Enable depth for WebRender r=jgilbert

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/92bd25aaba89