1448688 - Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1448688: Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits.

Review commit: https://reviewboard.mozilla.org/r/231022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231022/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8962182 [details]
Bug 1448688: Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits.

https://reviewboard.mozilla.org/r/231022/#review236460

::: dom/base/Element.h:108
(Diff revision 1)
>    // Remaining bits are for subclasses
>    ELEMENT_TYPE_SPECIFIC_BITS_OFFSET = NODE_TYPE_SPECIFIC_BITS_OFFSET + 6

Looks like you are releasing two bits here, maybe you can reduce the offset here or at least add a comment above mentioning that there are two free bits?

::: dom/base/Element.h
(Diff revision 1)
> -inline void nsINode::UnsetRestyleFlagsIfGecko()
> -{
> -  if (IsElement() && !AsElement()->IsStyledByServo()) {
> -    UnsetFlags(ELEMENT_ALL_RESTYLE_FLAGS |
> -               ELEMENT_HAS_CHILD_WITH_LATER_SIBLINGS_HINT);
> -  }
> -}

Note that you should remove the declaration of this function in nsINode in this patch as I mentioned in bug 1448690.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9689be6122d
Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits. r=xidorn

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/311b16a73755
followup: Remove unused StyleDataType. r=me

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c9689be6122d
https://hg.mozilla.org/mozilla-central/rev/311b16a73755