Closed Bug 1448688 Opened 2 years ago Closed 2 years ago

Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8962182 [details]
Bug 1448688: Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits.

https://reviewboard.mozilla.org/r/231022/#review236460

::: dom/base/Element.h:108
(Diff revision 1)
>    // Remaining bits are for subclasses
>    ELEMENT_TYPE_SPECIFIC_BITS_OFFSET = NODE_TYPE_SPECIFIC_BITS_OFFSET + 6

Looks like you are releasing two bits here, maybe you can reduce the offset here or at least add a comment above mentioning that there are two free bits?

::: dom/base/Element.h
(Diff revision 1)
> -inline void nsINode::UnsetRestyleFlagsIfGecko()
> -{
> -  if (IsElement() && !AsElement()->IsStyledByServo()) {
> -    UnsetFlags(ELEMENT_ALL_RESTYLE_FLAGS |
> -               ELEMENT_HAS_CHILD_WITH_LATER_SIBLINGS_HINT);
> -  }
> -}

Note that you should remove the declaration of this function in nsINode in this patch as I mentioned in bug 1448690.
Attachment #8962182 - Flags: review?(xidorn+moz) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c9689be6122d
Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits. r=xidorn
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/311b16a73755
followup: Remove unused StyleDataType. r=me
https://hg.mozilla.org/mozilla-central/rev/c9689be6122d
https://hg.mozilla.org/mozilla-central/rev/311b16a73755
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.