Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

No description provided.
Comment hidden (mozreview-request)

Comment 2

Last year
mozreview-review
Comment on attachment 8962183 [details]
Bug 1448690: Remove IsStyledByServo.

https://reviewboard.mozilla.org/r/231026/#review236440


Code analysis found 4 defects in this patch:
 - 4 defects found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: dom/base/DOMMatrix.h:31
(Diff revision 1)
>  struct DOMPointInit;
>  
>  class DOMMatrixReadOnly : public nsWrapperCache
>  {
>  public:
> -  DOMMatrixReadOnly(nsISupports* aParent, bool aIsServo)
> +  DOMMatrixReadOnly(nsISupports* aParent)

Error: Bad implicit conversion constructor for 'dommatrixreadonly' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/DOMMatrix.h:31
(Diff revision 1)
>  struct DOMPointInit;
>  
>  class DOMMatrixReadOnly : public nsWrapperCache
>  {
>  public:
> -  DOMMatrixReadOnly(nsISupports* aParent, bool aIsServo)
> +  DOMMatrixReadOnly(nsISupports* aParent)

Error: Bad implicit conversion constructor for 'dommatrixreadonly' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/DOMMatrix.h:158
(Diff revision 1)
>  };
>  
>  class DOMMatrix : public DOMMatrixReadOnly
>  {
>  public:
> -  DOMMatrix(nsISupports* aParent, bool aIsServo)
> +  DOMMatrix(nsISupports* aParent)

Error: Bad implicit conversion constructor for 'dommatrix' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/DOMMatrix.h:158
(Diff revision 1)
>  };
>  
>  class DOMMatrix : public DOMMatrixReadOnly
>  {
>  public:
> -  DOMMatrix(nsISupports* aParent, bool aIsServo)
> +  DOMMatrix(nsISupports* aParent)

Error: Bad implicit conversion constructor for 'dommatrix' [clang-tidy: mozilla-implicit-constructor]
Comment hidden (mozreview-request)

Comment 4

Last year
mozreview-review-reply
Comment on attachment 8962183 [details]
Bug 1448690: Remove IsStyledByServo.

https://reviewboard.mozilla.org/r/231026/#review236440

> Error: Bad implicit conversion constructor for 'dommatrixreadonly' [clang-tidy: mozilla-implicit-constructor]

As you are remiving the only other parameter here, you need to add `explicit` here to satisify the linter.

Comment 5

Last year
mozreview-review
Comment on attachment 8962183 [details]
Bug 1448690: Remove IsStyledByServo.

https://reviewboard.mozilla.org/r/231026/#review236454

::: dom/base/WebKitCSSMatrix.h:18
(Diff revision 2)
>  namespace dom {
>  
>  class WebKitCSSMatrix final : public DOMMatrix
>  {
>  public:
> -  WebKitCSSMatrix(nsISupports* aParent, bool aIsServo)
> +  WebKitCSSMatrix(nsISupports* aParent)

`explicit`

::: dom/base/nsINode.h
(Diff revision 2)
> -   * Returns true if this is a node belonging to a document that uses the Servo
> -   * style system.
> -   */
> -  bool IsStyledByServo() const;
> -
> -  inline void UnsetRestyleFlagsIfGecko();

It seems this removal should belong to bug 1448688 rather than here.
Attachment #8962183 - Flags: review?(xidorn+moz) → review+

Comment 7

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/b84db00d7fd9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.