Closed Bug 1448757 Opened 2 years ago Closed 2 years ago

Port nsDOMWindowUtils::GetAnimationTypeForLonghand to use Servo

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(3 files)

This is the only usage of nsCSSProps::kAnimTypeTable which is not guarded for Stylo. After porting this, we should be able to get rid of nsCSSProps::kAnimTypeTable.
Blocks: 1448759
Assignee: nobody → xidorn+moz
Comment on attachment 8969547 [details]
Bug 1448757 part 1 - Add more filters for InspectorUtils.getCSSPropertyNames.

https://reviewboard.mozilla.org/r/238294/#review244066
Attachment #8969547 - Flags: review?(cam) → review+
I think the second patch should be reviewed by daisuke since he introduced the feature that animation timing function is drawn depending on the animation type.  And as far as I know, now we only use color and a few other types.  So we don't need to maintain all animation types for now.
Flags: needinfo?(dakatsuka)
Comment on attachment 8969549 [details]
Bug 1448757 part 3 - Remove nsDOMWindowUtils::GetAnimationTypeForLonghand and nsStyleAnimType.

https://reviewboard.mozilla.org/r/238298/#review244068

I am fine with these removal if the second patch works for daisuke.
Attachment #8969549 - Flags: review?(hikezoe) → review+
Attachment #8969548 - Flags: review?(jryans) → review?(dakatsuka)
(In reply to Hiroyuki Ikezoe (:hiro) from comment #5)
> I think the second patch should be reviewed by daisuke since he introduced
> the feature that animation timing function is drawn depending on the
> animation type.  And as far as I know, now we only use color and a few other
> types.  So we don't need to maintain all animation types for now.

OK, I've flagged r? him.
Flags: needinfo?(dakatsuka)
Comment on attachment 8969548 [details]
Bug 1448757 part 2 - Move longhand animation type table into devtools.

https://reviewboard.mozilla.org/r/238296/#review244098

As Hiro said, we are checking not all types. The animation inspector (includes previous one) needs to know the types 'color', 'coord', 'float' and 'discrete'.
However, as in your test, because we don't want to make any missing properties in the future, I'd like to leave all types as it is.

Thank you very much!
Attachment #8969548 - Flags: review?(dakatsuka) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7cdcd109938
part 1 - Add more filters for InspectorUtils.getCSSPropertyNames. r=heycam
https://hg.mozilla.org/integration/autoland/rev/616bbf7a8815
part 2 - Move longhand animation type table into devtools. r=daisuke
https://hg.mozilla.org/integration/autoland/rev/3f4820437c25
part 3 - Remove nsDOMWindowUtils::GetAnimationTypeForLonghand and nsStyleAnimType. r=hiro
You need to log in before you can comment on or make changes to this bug.