1448831 - TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_db_path.js and more (Windows only)

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_db_path.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_update_webextensions.js | xpcshell return code: 0

Perma-red since Wed, Mar 21, 2018, 11:54:05

M-C last good: 6d0f84afc194e287b6f144d17cd88371a5
M-C first bad: e636edf00e6fbdc3206c9df4a1548ae38b

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6d0f84afc194e287b6f144d17cd88371a5&tochange=e636edf00e6fbdc3206c9df4a1548ae38b

Comment 1

[Jorg K (CEST = GMT+2)]

Running
  mozilla/mach xpcshell-test toolkit/mozapps/extensions/test/xpcshell/test_db_path.js
locally gives a good selection of errors :-(

 0:02.28 INFO xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_db_path.js | Starting test_non_ascii_path
 0:02.28 INFO (xpcshell/head.js) | test test_non_ascii_path pending (2)
 0:02.69 pid:8608 JavaScript strict warning: resource://testing-common/AddonTestUtils.jsm, line 228: ReferenceError: reference to undefined property "testScope"
 0:02.30 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "testScope"" {file: "resource://testing-common/AddonTestUtils.jsm" line: 228}]"
 0:02.69 pid:8608 [8608, LoadRoots] WARNING: This method is lossy. Use GetCanonicalPath !: file c:/mozilla-source/comm-central/mozilla/xpcom/io/nsLocalFileWin.cpp, line 3378
 0:02.69 pid:8608 Assertion failure: IsIdle(oldState) || IsRead(oldState), at c:\\mozilla-source\\comm-central\\mozilla\\xpcom\\ds\\PLDHashTable.h:118
 0:02.69 pid:8608 Assertion failure: IsWrite(oldState), at c:\\mozilla-source\\comm-central\\mozilla\\xpcom\\ds\\PLDHashTable.h:142
 0:02.69 pid:8608 ### ERROR: SymInitialize: The parameter is incorrect.

Comment 2

[Jorg K (CEST = GMT+2)]

Looks like a consequence of bug 1446571, especially the "testScope" added here:
https://hg.mozilla.org/mozilla-central/rev/afbc519c3856#l1.12
Other recent changes:
https://hg.mozilla.org/mozilla-central/log/tip/toolkit/mozapps/extensions/internal/AddonTestUtils.jsm

Kris, any idea why this is only failing in the TB Xpcshell test suite and only on Windows?

Comment 3

[Kris Maglione [:kmag]]

(In reply to Jorg K (GMT+1) from comment #2)
> Looks like a consequence of bug 1446571, especially the "testScope" added
> here:

The testScope warning is a red herring. It's more or less expected.

> Kris, any idea why this is only failing in the TB Xpcshell test suite and
> only on Windows?

Nope. I'd have to see the full test output with a complete stack. That assertion generally means that something's trying to change a hash table while it's iterating over it. Bug 1446571 seems like a pretty unlikely candidate. Possibly bug 1446833.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: log.txt - test_db_path.js

Here's the log file after rebuilding at today's tip on M-C.

"Assertion failure: IsWrite(oldState)" is no longer there, but the test still fails, in fact, right at the very start at line 7 of the log. I can't see what fails since the four Assert.ok() in the test itself pass.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: log2.txt - test_update_webextensions.js

Running test_update_webextensions.js gives a similar result, all the 27 subtests I can see pass, but there is some failure right at the start at line 7.

Comment 6

[Kris Maglione [:kmag]]

Ah, this is a file locking issue:

 0:02.99 ERROR Error: Found unexpected files in temporary directory: generated-extension-1.xpi at resource://testing-common/AddonTestUtils.jsm:342
init/<@resource://testing-common/AddonTestUtils.jsm:342:15
_execute_test/<@c:\mozilla-source\comm-central\mozilla\testing\xpcshell\head.js:577:15
async*_execute_test@c:\mozilla-source\comm-central\mozilla\testing\xpcshell\head.js:574:4
@-e:1:1

 0:02.99 INFO "CONSOLE_MESSAGE: (error) [JavaScript Error: "[Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://testing-common/AddonTestUtils.jsm :: cleanupTempXPIs :: line 471"  data: no]"]
cleanupTempXPIs@resource://testing-common/AddonTestUtils.jsm:471:11
init/<@resource://testing-common/AddonTestUtils.jsm:318:7
_execute_test/<@c:\\mozilla-source\\comm-central\\mozilla\\testing\\xpcshell\\head.js:577:15
async*_execute_test@c:\\mozilla-source\\comm-central\\mozilla\\testing\\xpcshell\\head.js:574:4
@-e:1:1

Not sure why it only fails on Thunderbird. It might be fixed by the follow-ups to bug 1447903, since they flush the jar cache at add-on manager shutdown.

Comment 7

[Jorg K (CEST = GMT+2)]

As far as I can see, this last failed at the beginning of May 2018 here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=c0b88c3cd2cdaeaa39805dc1f86d7a459df1c9e7

I never checked any more since the Xpcshell tests were perma-red on Windows. Looking closer, this failure here disappeared and was "replaced" by TEST-UNEXPECTED-FAIL | uriloader/exthandler/tests/unit/test_handlerService.js. That has also cleared, so Xpcshell on Windows is mostly green now.

So let's mark this fixed.