Closed Bug 1451455 Opened 6 years ago Closed 5 years ago

Load event not fired on OOP iframes

Categories

(Core :: DOM: Content Processes, defect, P3)

Product:
Core
Component:
DOM: Content Processes
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Project Flags:
Fission Milestone M3
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: qdot, Assigned: nika)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1451455 - Fire the 'load' event on out-of-process iframes,
47 bytes, text/x-phabricator-request
Details | Review 
When loading an iframe with OOP iframes turned on, the load event is never received by listeners. This causes multiple tests to fail, including dom/tests/browser/browser_xhr_sandbox.js.

https://treeherder.mozilla.org/logviewer.html#?job_id=171144500&repo=try&lineNumber=9543
Priority: -- → P3
Fission Milestone: --- → M3
No longer blocks: oop-frames
Status: NEW → RESOLVED
Fission Milestone: M3 → ---
Closed: 5 years ago
Resolution: --- → DUPLICATE

This is not in any way a dup of bug 1440212. It may depend on that bug. Maybe.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Fission Milestone: --- → M3
Fission Milestone: M3 → M4

Taking this because it's a constant pain point for writing fission tests, and should be relatively straightforward to do a band-aid fix for.

Assignee: nobody → nika

This is done by sending a message over PBrowser and PBrowserBridge when the
event would fire to fire it in the correct process.

Fission Milestone: M4 → M3
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86e87b18a282
Fire the 'load' event on out-of-process iframes, r=rhunt

Backed out changeset 86e87b18a282 (bug 1451455) for mochitest failures at dom/html/test/test_ignoreuserfocus.html

Backout: https://hg.mozilla.org/integration/autoland/rev/d0354606cae03dd6a9b990597c6eee38e858ff2c

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=249816754&revision=86e87b18a2824592cc896d2788eca204086c4842

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249815316&repo=autoland&lineNumber=9055
[task 2019-06-03T21:37:17.319Z] 21:37:17 INFO - GECKO(1072) | console.info: services.settings: Start polling for changes
[task 2019-06-03T21:37:17.321Z] 21:37:17 INFO - [1047, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-06-03T21:37:17.484Z] 21:37:17 INFO - GECKO(1072) | console.info: services.settings: Polling for changes done
[task 2019-06-03T21:37:29.873Z] 21:37:29 INFO - GECKO(1072) | --DOCSHELL 0x7f630110e000 == 7 [pid = 1154] [id = {0102951a-31e5-4e7d-a9b4-3c4762fdd585}] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_g_if1.html]
[task 2019-06-03T21:37:29.875Z] 21:37:29 INFO - GECKO(1072) | --DOCSHELL 0x7f6301107800 == 6 [pid = 1154] [id = {7e33ff37-c9f3-422e-b291-456da2f7990e}] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_b_if1.html]
[task 2019-06-03T21:37:29.877Z] 21:37:29 INFO - GECKO(1072) | --DOCSHELL 0x7f6301109800 == 5 [pid = 1154] [id = {caf49b1c-8f33-42c6-abaf-10871b1cba6a}] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_b_if2.html]
[task 2019-06-03T21:37:29.878Z] 21:37:29 INFO - GECKO(1072) | --DOCSHELL 0x7f6301111800 == 4 [pid = 1154] [id = {f63e2376-d993-460e-89c7-b3a7f24ff98a}] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_b_if3.html]
[task 2019-06-03T21:37:29.998Z] 21:37:29 INFO - GECKO(1072) | --DOMWINDOW == 24 (0x7f63049afa60) [pid = 1154] [serial = 1661] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_k_if6.html]
[task 2019-06-03T21:37:29.999Z] 21:37:29 INFO - GECKO(1072) | --DOMWINDOW == 23 (0x7f6305082f20) [pid = 1154] [serial = 1646] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_k_if6.html]
[task 2019-06-03T21:37:29.999Z] 21:37:29 INFO - GECKO(1072) | --DOMWINDOW == 22 (0x7f63015a1f20) [pid = 1154] [serial = 1614] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_window_top_navigation_pass.html]
[task 2019-06-03T21:37:30.001Z] 21:37:30 INFO - GECKO(1072) | --DOMWINDOW == 21 (0x7f630155ae20) [pid = 1154] [serial = 1613] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_window_top_navigation_pass.html]
[task 2019-06-03T21:37:30.002Z] 21:37:30 INFO - GECKO(1072) | --DOMWINDOW == 20 (0x7f63016f32e0) [pid = 1154] [serial = 1612] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_window_top_navigation_pass.html]
[task 2019-06-03T21:37:30.002Z] 21:37:30 INFO - GECKO(1072) | --DOMWINDOW == 19 (0x7f63015b6020) [pid = 1154] [serial = 1651] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_k_if6.html]
[task 2019-06-03T21:37:34.027Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 18 (0x7f63011f1000) [pid = 1154] [serial = 1680] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_window_top_navigation_pass.html]
[task 2019-06-03T21:37:34.030Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 17 (0x7f6301545c00) [pid = 1154] [serial = 1706] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/test_iframe_sandbox_same_origin.html]
[task 2019-06-03T21:37:34.032Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 16 (0x7f63011f4800) [pid = 1154] [serial = 1682] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_window_top_navigation_pass.html]
[task 2019-06-03T21:37:34.034Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 15 (0x7f6303d6a800) [pid = 1154] [serial = 1671] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_k_if6.html]
[task 2019-06-03T21:37:34.036Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 14 (0x7f6303d69400) [pid = 1154] [serial = 1670] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_k_if6.html]
[task 2019-06-03T21:37:34.039Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 13 (0x7f63011f3000) [pid = 1154] [serial = 1681] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_window_top_navigation_pass.html]
[task 2019-06-03T21:37:34.041Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 12 (0x7f63020d7400) [pid = 1154] [serial = 1621] [outer = (nil)] [url = about:blank]
[task 2019-06-03T21:37:34.043Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 11 (0x7f6302065800) [pid = 1154] [serial = 1620] [outer = (nil)] [url = about:blank]
[task 2019-06-03T21:37:34.046Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 10 (0x7f63015de400) [pid = 1154] [serial = 1666] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/file_iframe_sandbox_k_if6.html]
[task 2019-06-03T21:37:34.048Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 9 (0x7f63015d4000) [pid = 1154] [serial = 1692] [outer = (nil)] [url = http://mochi.test:8888/tests/dom/html/test/test_iframe_sandbox_refresh.html]
[task 2019-06-03T21:37:34.049Z] 21:37:34 INFO - GECKO(1072) | --DOMWINDOW == 8 (0x7f63020dcc00) [pid = 1154] [serial = 1622] [outer = (nil)] [url = about:blank]
[task 2019-06-03T21:41:17.353Z] 21:41:17 INFO - [1047, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-06-03T21:42:01.563Z] 21:42:01 INFO - TEST-INFO | started process screentopng
[task 2019-06-03T21:42:01.865Z] 21:42:01 INFO - TEST-INFO | screentopng: exit 0
[task 2019-06-03T21:42:01.866Z] 21:42:01 INFO - TEST-UNEXPECTED-FAIL | dom/html/test/test_ignoreuserfocus.html | Test timed out.
[task 2019-06-03T21:42:01.866Z] 21:42:01 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-06-03T21:42:01.867Z] 21:42:01 INFO - reportError@SimpleTest/TestRunner.js:121:22
[task 2019-06-03T21:42:01.868Z] 21:42:01 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
[task 2019-06-03T21:42:01.868Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.868Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.868Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.868Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.869Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.870Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.870Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.871Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.871Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.871Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.872Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.872Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.875Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.876Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.876Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.877Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.877Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.877Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.877Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.878Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.879Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.880Z] 21:42:01 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-06-03T21:42:01.880Z] 21:42:01 INFO - TestRunner.runTests/<@SimpleTest/TestRunner.js:381:20
[task 2019-06-03T21:42:01.881Z] 21:42:01 INFO - promise callbackTestRunner.runTests@SimpleTest/TestRunner.js:368:50
[task 2019-06-03T21:42:01.881Z] 21:42:01 INFO - RunSet.runtests@SimpleTest/setup.js:201:14
[task 2019-06-03T21:42:01.881Z] 21:42:01 INFO - RunSet.runall@SimpleTest/setup.js:180:12
[task 2019-06-03T21:42:01.881Z] 21:42:01 INFO - hookupTests@SimpleTest/setup.js:273:12
[task 2019-06-03T21:42:01.882Z] 21:42:01 INFO - parseTestManifest@http://mochi.test:8888/manifestLibrary.js:36:5
[task 2019-06-03T21:42:01.882Z] 21:42:01 INFO - getTestManifest/req.onload@http://mochi.test:8888/manifestLibrary.js:49:11
[task 2019-06-03T21:42:01.883Z] 21:42:01 INFO - EventHandlerNonNullgetTestManifest@http://mochi.test:8888/manifestLibrary.js:45:3
[task 2019-06-03T21:42:01.883Z] 21:42:01 INFO - hookup@SimpleTest/setup.js:253:5
[task 2019-06-03T21:42:01.884Z] 21:42:01 INFO - EventHandlerNonNull*@http://mochi.test:8888/tests?autorun=1&closeWhenDone=1&consoleLevel=INFO&manifestFile=tests.json&dumpOutputDirectory=%2Ftmp&cleanupCrashes=true:11:1
[task 2019-06-03T21:42:02.575Z] 21:42:02 INFO - GECKO(1072) | MEMORY STAT | vsize 2838MB | residentFast 189MB | heapAllocated 19MB

Flags: needinfo?(nika)
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49dfd67a3ba8
Fire the 'load' event on out-of-process iframes, r=rhunt

https://hg.mozilla.org/mozilla-central/rev/49dfd67a3ba8

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Flags: needinfo?(nika)
See Also: → 1573322
Regressions: 1606896
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: