1451926 - Add a pref around AV1 decoding

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P1)

Description

[Nils Ohlmeier [:drno]]

AV1 decoding is currently turned on via build system in Firefox Nightly on OSX and Linux https://searchfox.org/mozilla-central/rev/d0413b711da4dac72b237d0895daba2537f1514c/toolkit/moz.configure#381

We need to add a user pref to be able to turn it off if we need to.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1451926: add a user pref for AV1 codec.

Review commit: https://reviewboard.mozilla.org/r/234342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234342/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8965553 [details]
Bug 1451926: add a user pref for AV1 codec.

https://reviewboard.mozilla.org/r/234342/#review239942

r+ with review comments addressed.

::: dom/media/MediaPrefs.h:138
(Diff revision 1)
>  #endif
>  #ifdef MOZ_FFVPX
>    DECL_MEDIA_PREF("media.ffvpx.enabled",                      PDMFFVPXEnabled, bool, true);
>  #endif
> +#ifdef MOZ_AV1
> +  DECL_MEDIA_PREF("media.mediasource.av1.enabled",            AV1Enabled, bool, false);

There's nothing here to enforce that this pref toggles Media Source Extensions support only, so I think you should just name it "media.av1.enabled".

::: dom/media/webm/WebMDecoder.cpp:73
(Diff revision 1)
>          continue;
>        }
>      }
>  #ifdef MOZ_AV1
> -    if (isVideo && AOMDecoder::IsSupportedCodec(codec)) {
> +    if (isVideo &&
> +        Preferences::GetBool("media.mediasource.av1.enabled", false) &&

Best to use the MediaPref here for consistency, and to avoid typos causing problems.

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8965553 [details]
Bug 1451926: add a user pref for AV1 codec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/234342/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd2106b68805
add a user pref for AV1 codec. r=cpearce

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cd2106b68805

Comment 6

[Eric Shepherd [:sheppy]]

For documentation -- note that AV1 is available on Nightly 61 but only with the preference enabled.

Comment 7

[Eric Shepherd [:sheppy]]

Updated "Experimental Features in Firefox" to note that AV1 arrived in 55, enabled by default, and was disabled by default effective in 61, with all availability only in nightly.

https://developer.mozilla.org/en-US/Firefox/Experimental_features#WebRTC_and_media