Closed Bug 1452146 Opened 2 years ago Closed Last year

Flip AV1 pref (media.av1.enabled) for Windows to true

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

61 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
relnote-firefox --- 65+
firefox64 --- wontfix
firefox65 + fixed
firefox66 + fixed

People

(Reporter: drno, Assigned: mjf)

References

(Depends on 2 open bugs, Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete, feature)

Attachments

(2 files)

After bug 1451926 has landed we should discuss what is required and under which circumstances we turn the user pref for AV1 back to on.
Dan, what does it take from your point of view before we can pref AV1 on again?
Flags: needinfo?(dveditz)
We ought to go through MDN to see if we cover AV1 support in appropriate places. Adding a ddn as a reminder here.
Keywords: dev-doc-needed
Blocks: AV1
(In reply to Nils Ohlmeier [:drno] from comment #1)
> Dan, what does it take from your point of view before we can pref AV1 on again?

There should be few enough security vulnerabilities that we can file and track them individually in Bugzilla.

It should stand up to fuzzing for a reasonable period of time and with the only potentially exploitable signatures it spits out ones that are already known and on file. (I'll let abillings and the fuzzing team define "reasonable period")

Otherwise we'll get bled dry by bounty folks racing with our own team. I'm surprised that hasn't happened yet but I guess the fact that it was there has flown under the radar.
Flags: needinfo?(dveditz)
Duplicate of this bug: 1473088
Summary: Flip AV1 pref to on → Flip AV1 pref (media.av1.enabled) to true
Depends on: 1479304
Depends on: 1471535
Depends on: 1492548
Keywords: feature
The Nightly 65 soft freeze starts on Monday - what's the status here?
Flags: needinfo?(drno)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> The Nightly 65 soft freeze starts on Monday - what's the status here?

So over in bug 1498624 we are landing sandboxing code for the RDD process right now. Once that is in I believe we can turn on the RDD process on Win and Mac. And then we can turn AV1 on on these two platforms.

So yes I would like to still turn it on in 65.
Flags: needinfo?(drno)
Depends on: 1498624
Assignee: nobody → drno
Assignee: drno → mfroman
Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e6cbbc4c53e
flip av1 and rdd on for OSX and Win. r=drno
(In reply to Andreea Pavel [:apavel] from comment #9)
> BC:
> https://treeherder.mozilla.org/logviewer.html#?job_id=214746707&repo=autoland

I guess this one is easily fixed by adding 'rdd' to the list here https://searchfox.org/mozilla-central/source/testing/mozbase/mozleak/mozleak/leaklog.py#174
mjf: what I find strange is why do these memory and process checks all encounter the RDD process? Isn't the RDD process suppose to be started only if we need it for decoding AV1 videos (and I doubt these test pages attempt that)?
(In reply to Nils Ohlmeier [:drno] from comment #13)
> mjf: what I find strange is why do these memory and process checks all
> encounter the RDD process? Isn't the RDD process suppose to be started only
> if we need it for decoding AV1 videos (and I doubt these test pages attempt
> that)?
No, RDD process is started at launch (just like the GPU process is on Windows-only).
Flags: needinfo?(mfroman)
About mem checks, leak check rdd process awareness, and add a 400 byte leak check threshold for rdd.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6291a80a56cf90d08d68ab3da2a4d0649f63699d
Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3c8a3a052ea
flip av1 and rdd on for OSX and Win. r=mjf
Attachment #9028806 - Attachment description: Bug 1452146 - flip av1 and rdd on for OSX and Win. r?drno! → Bug 1452146 - flip av1 and rdd on for Win. r?drno!
Keywords: leave-open
(In reply to Michael Froman [:mjf] from comment #22)
> Pref on only for Win try run:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=bb27b71aed28fd8d8e039e9522e64f1b018748f6

Looks like this still has a bunch of Windows leaks? This seems pretty unlikely to make it into the first beta of 65 at this point.
relnote-firefox: --- → ?
We're not going to make 65 - we're dealing with Sandbox issues.
Flags: needinfo?(drno)
Comment on attachment 9028806 [details]
Bug 1452146 - flip av1 and rdd on for Win. r?drno!

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Firefox users won't be able to watch video content encoded in the new AV1 codec.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: Bug 1513101

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The patch itself only flips the pref for AV1. There is only limited amount of content available in AV1 yet (but we expect more to show up soon), thus the impact for most of the Firefox users should be minimal.

String changes made/needed: N/A
Attachment #9028806 - Flags: approval-mozilla-beta?
For the sake of simpler tracking, can we please repurpose this bug to just the Windows case and move unconditional enabling to a new bug?
Flags: needinfo?(mfroman)
Depends on: 1514274
(In reply to Ryan VanderMeulen [:RyanVM] from comment #28)
> For the sake of simpler tracking, can we please repurpose this bug to just
> the Windows case and move unconditional enabling to a new bug?
Sure - I'll change the title.
Flags: needinfo?(mfroman)
Summary: Flip AV1 pref (media.av1.enabled) to true → Flip AV1 pref (media.av1.enabled) for Windows to true
Status: NEW → RESOLVED
Closed: Last year
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Comment on attachment 9028806 [details]
Bug 1452146 - flip av1 and rdd on for Win. r?drno!

[Triage Comment]
Approved for 65.0b5, thanks.
Attachment #9028806 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify-

Note to MDN writers: I've added a note to the Fx 66 rel notes to cover this: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/66#Other

In terms of actual docs, this should be covered nicely by the all-new media formats guide Sheppy is working on!

Blocks: 1531092

Looks like the note got removed from the Firefox 66 page at some point. I've added it back. In addition, AV1 is covered in the new "Guide to video codecs used on the web" article at:

https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Video_codecs#AV1

You need to log in before you can comment on or make changes to this bug.