Closed
Bug 1452146
Opened 7 years ago
Closed 6 years ago
Flip AV1 pref (media.av1.enabled) for Windows to true
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: drno, Assigned: mjf)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
(Keywords: dev-doc-complete, feature)
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
47 bytes,
text/x-phabricator-request
|
Details | Review |
After bug 1451926 has landed we should discuss what is required and under which circumstances we turn the user pref for AV1 back to on.
Reporter | ||
Comment 1•7 years ago
|
||
Dan, what does it take from your point of view before we can pref AV1 on again?
Flags: needinfo?(dveditz)
Comment 2•7 years ago
|
||
We ought to go through MDN to see if we cover AV1 support in appropriate places. Adding a ddn as a reminder here.
Keywords: dev-doc-needed
Comment 3•7 years ago
|
||
(In reply to Nils Ohlmeier [:drno] from comment #1)
> Dan, what does it take from your point of view before we can pref AV1 on again?
There should be few enough security vulnerabilities that we can file and track them individually in Bugzilla.
It should stand up to fuzzing for a reasonable period of time and with the only potentially exploitable signatures it spits out ones that are already known and on file. (I'll let abillings and the fuzzing team define "reasonable period")
Otherwise we'll get bled dry by bounty folks racing with our own team. I'm surprised that hasn't happened yet but I guess the fact that it was there has flown under the radar.
Flags: needinfo?(dveditz)
Reporter | ||
Updated•6 years ago
|
Summary: Flip AV1 pref to on → Flip AV1 pref (media.av1.enabled) to true
Comment 5•6 years ago
|
||
The Nightly 65 soft freeze starts on Monday - what's the status here?
Flags: needinfo?(drno)
Reporter | ||
Comment 6•6 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> The Nightly 65 soft freeze starts on Monday - what's the status here?
So over in bug 1498624 we are landing sandboxing code for the RDD process right now. Once that is in I believe we can turn on the RDD process on Win and Mac. And then we can turn AV1 on on these two platforms.
So yes I would like to still turn it on in 65.
Flags: needinfo?(drno)
Updated•6 years ago
|
Updated•6 years ago
|
Assignee: nobody → drno
Assignee | ||
Comment 7•6 years ago
|
||
Updated•6 years ago
|
Assignee: drno → mfroman
Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e6cbbc4c53e
flip av1 and rdd on for OSX and Win. r=drno
Comment 9•6 years ago
|
||
Backed out for leaks on OS X and chrome failures
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2e6cbbc4c53e3c0cc762b8c716d5e6370a11bd17
Failure logs:
Chrome: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214751779&repo=autoland&lineNumber=2302
BC: https://treeherder.mozilla.org/logviewer.html#?job_id=214746707&repo=autoland
Backout: https://hg.mozilla.org/integration/autoland/rev/c4a45f2bd13972fb4728aefab69197c6d2eb2215
Flags: needinfo?(mfroman)
Reporter | ||
Comment 10•6 years ago
|
||
(In reply to Andreea Pavel [:apavel] from comment #9)
> BC:
> https://treeherder.mozilla.org/logviewer.html#?job_id=214746707&repo=autoland
I guess this one is easily fixed by adding 'rdd' to the list here https://searchfox.org/mozilla-central/source/testing/mozbase/mozleak/mozleak/leaklog.py#174
Comment 11•6 years ago
|
||
Nils there were other failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=88f8e61c7b04acfb705448f02851b0c17ca470db&group_state=expanded&tochange=2f0e92d76c4e96fe66f0aab96075c22b3692f116&failure_classification_id=2&searchStr=M-e10s&selectedJob=214753509
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=88f8e61c7b04acfb705448f02851b0c17ca470db&group_state=expanded&tochange=2f0e92d76c4e96fe66f0aab96075c22b3692f116&failure_classification_id=2&searchStr=M-e10s&selectedJob=214753437
These all appeared to be from your patch.
Reporter | ||
Comment 12•6 years ago
|
||
Try run with leaklog.py patched https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd72ad38a2dc8183f16526153d8ebef432288d33
Reporter | ||
Comment 13•6 years ago
|
||
mjf: what I find strange is why do these memory and process checks all encounter the RDD process? Isn't the RDD process suppose to be started only if we need it for decoding AV1 videos (and I doubt these test pages attempt that)?
Assignee | ||
Comment 14•6 years ago
|
||
(In reply to Nils Ohlmeier [:drno] from comment #13)
> mjf: what I find strange is why do these memory and process checks all
> encounter the RDD process? Isn't the RDD process suppose to be started only
> if we need it for decoding AV1 videos (and I doubt these test pages attempt
> that)?
No, RDD process is started at launch (just like the GPU process is on Windows-only).
Flags: needinfo?(mfroman)
Reporter | ||
Comment 15•6 years ago
|
||
Added RDD to about memory checks - try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b638ef4ec0fc449dd5006880bfa835b260ae8dc
Assignee | ||
Comment 16•6 years ago
|
||
About mem checks, leak check rdd process awareness, and add a 400 byte leak check threshold for rdd.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6291a80a56cf90d08d68ab3da2a4d0649f63699d
Reporter | ||
Comment 17•6 years ago
|
||
Another try run with PID removed from process name https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfc5ce706a31c5923c4d451124bbaa80ee45a356
Reporter | ||
Comment 18•6 years ago
|
||
Updated RDD about memory numbers https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dd16391688dce89948e56e0ef4da5f85a621347
Reporter | ||
Comment 19•6 years ago
|
||
Comment 20•6 years ago
|
||
Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3c8a3a052ea
flip av1 and rdd on for OSX and Win. r=mjf
Comment 21•6 years ago
|
||
Backed out changeset b3c8a3a052ea (Bug 1452146) for mochitest automation.py failures
Push with failureS: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=215231290&revision=b3c8a3a052ea96b093839b5732661e6c1d006a77
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=215231290&repo=autoland&lineNumber=31716
Backout: https://hg.mozilla.org/integration/autoland/rev/b1c9fa45f90ee5f26843749557a2fda84581f406
Flags: needinfo?(drno)
Assignee | ||
Comment 22•6 years ago
|
||
Pref on only for Win try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb27b71aed28fd8d8e039e9522e64f1b018748f6
Updated•6 years ago
|
Attachment #9028806 -
Attachment description: Bug 1452146 - flip av1 and rdd on for OSX and Win. r?drno! → Bug 1452146 - flip av1 and rdd on for Win. r?drno!
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Comment 23•6 years ago
|
||
(In reply to Michael Froman [:mjf] from comment #22)
> Pref on only for Win try run:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=bb27b71aed28fd8d8e039e9522e64f1b018748f6
Looks like this still has a bunch of Windows leaks? This seems pretty unlikely to make it into the first beta of 65 at this point.
relnote-firefox:
--- → ?
Assignee | ||
Comment 24•6 years ago
|
||
We're not going to make 65 - we're dealing with Sandbox issues.
Comment 25•6 years ago
|
||
Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ded3b65ca045
flip av1 and rdd on for Win. r=drno
Comment 26•6 years ago
|
||
bugherder |
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(drno)
Reporter | ||
Comment 27•6 years ago
|
||
Comment on attachment 9028806 [details]
Bug 1452146 - flip av1 and rdd on for Win. r?drno!
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: None
User impact if declined: Firefox users won't be able to watch video content encoded in the new AV1 codec.
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: No
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: Bug 1513101
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): The patch itself only flips the pref for AV1. There is only limited amount of content available in AV1 yet (but we expect more to show up soon), thus the impact for most of the Firefox users should be minimal.
String changes made/needed: N/A
Attachment #9028806 -
Flags: approval-mozilla-beta?
Comment 28•6 years ago
|
||
For the sake of simpler tracking, can we please repurpose this bug to just the Windows case and move unconditional enabling to a new bug?
Flags: needinfo?(mfroman)
Assignee | ||
Comment 29•6 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #28)
> For the sake of simpler tracking, can we please repurpose this bug to just
> the Windows case and move unconditional enabling to a new bug?
Sure - I'll change the title.
Flags: needinfo?(mfroman)
Assignee | ||
Updated•6 years ago
|
Summary: Flip AV1 pref (media.av1.enabled) to true → Flip AV1 pref (media.av1.enabled) for Windows to true
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → wontfix
status-firefox66:
--- → fixed
tracking-firefox66:
--- → +
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Comment 30•6 years ago
|
||
Comment on attachment 9028806 [details]
Bug 1452146 - flip av1 and rdd on for Win. r?drno!
[Triage Comment]
Approved for 65.0b5, thanks.
Attachment #9028806 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 31•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Flags: qe-verify-
Comment 32•6 years ago
|
||
Note to MDN writers: I've added a note to the Fx 66 rel notes to cover this: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/66#Other
In terms of actual docs, this should be covered nicely by the all-new media formats guide Sheppy is working on!
Comment 33•5 years ago
|
||
Looks like the note got removed from the Firefox 66 page at some point. I've added it back. In addition, AV1 is covered in the new "Guide to video codecs used on the web" article at:
https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Video_codecs#AV1
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•