5.17 KB, patch
Ian Neal: review+
|Details | Diff | Splinter Review|
5.03 KB, patch
|Details | Diff | Splinter Review|
From Bugzilla Helper: User-Agent: RC2 as Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.4) Gecko/20011128 Netscape6/6.2.1 BuildID: 2002051006 Using ctrl-click, more than one filter at a time can be selected, but after pressing delete only the bottom one is deleted. Reproducible: Always Steps to Reproduce: 1. Highlight more than one filter 2. Press delete 3. Actual Results: The bottom filter was deleted Expected Results: All filters should have been deleted Using windows 98, RC2 as NS6.2.1
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
I'll attach a patch so this bug can't be reproduced, until someone decides to implement opening/editing/deleting multiple filters at once.
Created attachment 86991 [details] [diff] [review] don't allow multiple rows to be selected for now One-liner to prevent multiple rows from being selected in this tree.
Comment on attachment 86991 [details] [diff] [review] don't allow multiple rows to be selected for now firstname.lastname@example.org renamed patch to make clear that this bug stays open and to back this patch out once the bug is really fixed
Assignee: naving → sspitzer
Is the patch for this bug in the trunk? Currently, the Delete button is greyed and the delete key does nothing. Bug 204547 is an enhancment requesting multi-filter deletion; is that a dupe of this? Should that one be WontFix?
*** Bug 204547 has been marked as a duplicate of this bug. ***
I duped bug 204547 to this--the original comment was the same, even if that issue isn't addressed in the fix.
Not enhancement, the ui is there but fails to work as expected. Delete button should be enabled and should delete the selected filters when multiple filters are selected.
Severity: enhancement → minor
OS: Windows 98 → All
function onDeleteFilter() needs to behave like runSelectedFilters() and then updateButtons() changed to enable the delete button for multiple select - in http://lxr.mozilla.org/seamonkey/source/mailnews/base/search/resources/content/FilterListDialog.js
Assignee: sspitzer → nobody
QA Contact: laurel → filters
Summary: Can't delete more than one filter at a time → Can't delete more than one filter at a time - delete multiple selected filters is disabled
Created attachment 256853 [details] [diff] [review] allow multiple filter deletions; SM v1 First go for fixing this. Will do a TB version if this goes through.
Comment on attachment 256853 [details] [diff] [review] allow multiple filter deletions; SM v1 >+ var sel = gFilterTree.view.selection, selCount = sel.getRangeCount(); Nit: I found this unsightly. Please put selCount on its own line.
Attachment #256853 - Flags: superreview?(neil) → superreview+
Comment on attachment 256853 [details] [diff] [review] allow multiple filter deletions; SM v1 Landed on trunk; requesting SM branch approval.
Comment on attachment 257409 [details] [diff] [review] allow multiple filter deletions; TB variant looks good, but we can't land that on the 1.8.1 branch because we're past the string freeze...
Comment on attachment 257409 [details] [diff] [review] allow multiple filter deletions; TB variant Landed on trunk, though. I try to remember "a-TB2.0x?" ;-)
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [approval-seamonkey1.1.2?] → [approval-seamonkey1.1.2?][approval-thunderbird220.127.116.11?]
-deleteFilterConfirmation=Are you sure you want to delete this filter? +deleteFilterConfirmation=Are you sure you want to delete the selected filter(s)? This is a semantic change, so the key name should be changed as well.
(In reply to comment #17) nod
You need to log in before you can comment on or make changes to this bug.