145290 - Can't delete more than one filter at a time - delete multiple selected filters is disabled

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[JWBohrer]

From Bugzilla Helper:
User-Agent: RC2 as Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.4)
Gecko/20011128 Netscape6/6.2.1
BuildID:    2002051006

Using ctrl-click, more than one filter at a time can be selected, but after
pressing delete only the bottom one is deleted.

Reproducible: Always
Steps to Reproduce:
1. Highlight more than one filter
2. Press delete
3.

Actual Results:  The bottom filter was deleted

Expected Results:  All filters should have been deleted

Using windows 98, RC2 as NS6.2.1

Comment 1

[Håkan Waara]

I'll attach a patch so this bug can't be reproduced, until someone decides to
implement opening/editing/deleting multiple filters at once.

Comment 2

[Håkan Waara]

Attachment: don't allow multiple rows to be selected for now

One-liner to prevent multiple rows from being selected in this tree.

Comment 3

[Axel Hecht]

Comment on attachment 86991 [details] [diff] [review]
don't allow multiple rows to be selected for now

r=[e-mail]
renamed patch to make clear that this bug stays open and to back this patch out
once the bug is really fixed

Comment 4

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 5

[Mike Cowperthwaite]

Is the patch for this bug in the trunk?  Currently, the Delete button is greyed 
and the delete key does nothing.  Bug 204547 is an enhancment requesting 
multi-filter deletion; is that a dupe of this?  Should that one be WontFix?

Comment 6

[Robert Mohr]

*** Bug 204547 has been marked as a duplicate of this bug. ***

Comment 7

[Robert Mohr]

I duped bug 204547 to this--the original comment was the same, even if that
issue isn't addressed in the fix.

Comment 8

[Tuukka Tolvanen (sp3000)]

Not enhancement, the ui is there but fails to work as expected. Delete button
should be enabled and should delete the selected filters when multiple filters
are selected.

Comment 9

[Wayne Mery (:wsmwk)]

function onDeleteFilter() needs to behave like runSelectedFilters() and then updateButtons() changed to enable the delete button for multiple select - in http://lxr.mozilla.org/seamonkey/source/mailnews/base/search/resources/content/FilterListDialog.js

Comment 11

[Karsten Düsterloh]

Attachment: allow multiple filter deletions; SM v1

First go for fixing this. Will do a TB version if this goes through.

Comment 12

[[e-mail]]

Comment on attachment 256853 [details] [diff] [review]
allow multiple filter deletions; SM v1

>+  var sel = gFilterTree.view.selection, selCount = sel.getRangeCount();
Nit: I found this unsightly. Please put selCount on its own line.

Comment 13

[Karsten Düsterloh]

Attachment: allow multiple filter deletions; TB variant

Comment 14

[Karsten Düsterloh]

Comment on attachment 256853 [details] [diff] [review]
allow multiple filter deletions; SM v1

Landed on trunk; requesting SM branch approval.

Comment 15

[David :Bienvenu]

Comment on attachment 257409 [details] [diff] [review]
allow multiple filter deletions; TB variant

looks good, but we can't land that on the 1.8.1 branch because we're past the string freeze...

Comment 16

[Karsten Düsterloh]

Comment on attachment 257409 [details] [diff] [review]
allow multiple filter deletions; TB variant

Landed on trunk, though. I try to remember "a-TB2.0x?" ;-)

Comment 17

[Marek Stępień [:marcoos, inactive]]

-deleteFilterConfirmation=Are you sure you want to delete this filter?
+deleteFilterConfirmation=Are you sure you want to delete the selected filter(s)?

This is a semantic change, so the key name should be changed as well.

Comment 18

[Axel Hecht [:Pike]]

(In reply to comment #17)
nod