Closed Bug 1452920 Opened 2 years ago Closed 1 year ago

Convert WebConsoleActor to protocol.js

Categories

(DevTools :: General, enhancement, P2)

enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: yulia, Assigned: yulia)

References

(Depends on 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Webconsole is a dependancy for the conversion of AddonActor
Assignee: nobody → ystartsev
Depends on: 1452932
Severity: normal → enhancement
Priority: -- → P2
Blocks: 1450958
No longer blocks: 1450960
Depends on: 1461715
Note: AddonConsole inherits from this actor, there will be some clean up there once this is updated
Product: Firefox → DevTools
We also need to address refactoring evaluateJSAsync, as it is currently a synchronous function. Several older actors are relying on it so this needs to be done with care. New actors can return promises, but evaluateJSAsync breaks if it is turned into one. 

what needs to be done once protocol.js is introduced is that we modernize this function, and make sure that the tests are passing. here is a try run with the failing tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6d34f4f03a85b601745d641625d29a8e0cd316a
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cba74a67e19
Convert WebConsoleActor to protocoljs Actor. r=nchevobbe,yulia
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
No longer blocks: 1570685
Regressions: 1570685
Regressions: 1571916
Attachment #9059252 - Attachment is obsolete: true
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a2f71c2dfd2
Clean up WebConsoleActor events and responses. r=nchevobbe
You need to log in before you can comment on or make changes to this bug.