1453233 - Port bug 1437302 to TB: Fix width of textbox[type=number] consumers

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1437302 made it possible to define the width of the numberboxes.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: numberbox.patch

This should fix all numberboxes. Note that they have no more the spinbuttons on the right, althought when they would be visible they are not working.

I changed in the CSS the calculated width to use 24px instead of 22px to to show the max port (65535) fully and not shifting when moving the cursor to the right, at least on incontent prefs. On Mac it wouldn't be necessary as it fits (FX has probably tested it only on Mac).

I've found also an overlay we need to remove but I'll do it after this bug to make it easier to uplift to beta. This still needs work as we changed the file names after the overlay removal.

Comment 2

[Jorg K (CEST = GMT+2)]

So what's the story about the spinbuttons? Why don't they work? Most of the patch is about adding hidespinbuttons="true" everywhere.

Comment 3

[Richard Marti (:Paenglab)]

The FX bug adds the hidespinbuttons="true" too. Without, they are shown but not clickable...and oddly placed. Instead of the spinbuttons with cursor up/down you can increment/decrement.

Comment 4

[Jorg K (CEST = GMT+2)]

Any plans/bug to fix them?

Comment 5

[Richard Marti (:Paenglab)]

Not that I know. It's probably either you have spinbuttons but no width to define or the other way.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8966868 [details] [diff] [review]
numberbox.patch

All the number boxes I looked at were OK: Various in (SMTP) server settings, proxies and cache size. I liked the spinbuttons :-(

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4d405d2392d2
Port bug 1437302 to TB: Fix width of textbox[type=number] consumers. r=jorgk

Comment 8

[Jorg K (CEST = GMT+2)]

I've landed this now since without the patch but bug 1437302 landed, the number boxes looked bad. However, prior to bug 1437302, the fields where too wide, but the spinbuttons worked, so I don't understand why they went broken and were removed altogether, but basically leaving them in a broken state if anyone still uses them.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: numberbox-beta.patch

The same patch for beta, when the m-c bug will be uplifted.

The only change in this patch are the renamed files from inc.xul to xul.

Comment 10

[Jorg K (CEST = GMT+2)]

We still have the spinbutton binding, so should we make that work?

Comment 11

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+1) from comment #10)
> We still have the spinbutton binding, so should we make that work?

If you know how to do.

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 8966916 [details] [diff] [review]
numberbox-beta.patch

No uplift for this since it's being backed out in bug 1453322.