Closed
Bug 1453872
Opened 6 years ago
Closed 6 years ago
HTMLEditRules::JoinNodesSmart() doesn't set initial result correctly
Categories
(Core :: DOM: Editor, defect, P1)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | wontfix |
firefox60 | --- | fixed |
firefox61 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: regression)
Attachments
(2 files)
59 bytes,
text/x-review-board-request
|
m_kato
:
review+
|
Details |
16.79 KB,
patch
|
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This is regression of bug 1423835. If HTMLEditRules::JoinNodesSmart() joins aLeftNode and aRightNode actually, children of aLeftNode are inserted before first child of aRightNode and returns the point of old first node of aRightNode as its result. However, after fixing bug 1423835, it returns point at nth child of new aRightNode, nth is length of old right node children. I'm not sure how to get actual symptom though.
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4654076263a97a153dc350497159c86da800cc6
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
Here is the diff of bug 1423835: https://searchfox.org/mozilla-central/diff/d95c27869decc6a8d7787d8245a23cc095e35956/editor/libeditor/HTMLEditRules.cpp#7614
Assignee | ||
Comment 5•6 years ago
|
||
Fortunately, we've already gotten an actual bug report with STR. I'll add automated test for this.
Assignee | ||
Updated•6 years ago
|
Attachment #8967664 -
Flags: review?(m_kato) → review-
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f52e182c2a5960aee83d0b5e2390dc6c98e335f
Updated•6 years ago
|
status-firefox59:
--- → wontfix
status-firefox60:
--- → affected
status-firefox-esr52:
--- → unaffected
Comment hidden (mozreview-request) |
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8967664 [details] Bug 1453872 - Make HTMLEditRules::JoinNodesSmart() return { aRightNode - aLeftNode.Length() } by default https://reviewboard.mozilla.org/r/236394/#review242494
Attachment #8967664 -
Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/bc6e8d505359 Make HTMLEditRules::JoinNodesSmart() return { aRightNode - aLeftNode.Length() } by default r=m_kato
Updated•6 years ago
|
Priority: -- → P1
Assignee | ||
Comment 10•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7441c4ffa9082b6f94c70ca554f99f5c7b8aa38c
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc6e8d505359
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee | ||
Comment 13•6 years ago
|
||
Approval Request Comment [Feature/Bug causing the regression]: Regression of bug 1423835. [User impact if declined]: User will see odd crate position when removing <br> element with Delete or Backspace. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: Not yet, but new automated test passed on m-c. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: This is one line backing out. [String changes made/needed]: No.
Attachment #8968139 -
Flags: approval-mozilla-beta?
Comment 14•6 years ago
|
||
Comment on attachment 8968139 [details] [diff] [review] Patch for Beta (only changes manifest file of wpt) editor regression fix, approved for 60.0b13
Attachment #8968139 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 15•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/01e680ea0270
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•