145568 - Composing text email generates lots of JavaScript errors on CVS 2002051[89]

Status: VERIFIED DUPLICATE of bug 156918

(MailNews Core :: Composition, defect)

Description

[Mitch]

When composing, forwarding text email a lot of javascript errors
are thrown up in the javascript console such as:

Error: redecleration od const MOZ_HELP_URI
Source File: chrome://help/content/contextHelp.js  Line: 1

and quite a few of these:

Error: uncaught exception:[Exception..."Component returned failure code:
0x80004001 (NS_ERROR_NOT_IMPLEMENTED)
[nslEditorShell.GetSelectedOrParentTableElement]" nsresult: "0x80004001
(NS_ERROR_NOT_IMPLEMENTED)" location:"JS frame ::
chrome://editor/content/editor.js :: goUpdateTableMenuItem :: line 2462" data: no]

See also bug 145475

Comment 1

[(not reading, please use [e-mail] instead)]

confirming, all platforms.

Comment 2

[Jean-Francois Ducarroz]

*** Bug 145678 has been marked as a duplicate of this bug. ***

Comment 3

[Jean-Francois Ducarroz]

reassign to varada

Comment 4

[Charles Manske]

The source of this problem is obviously the updating of commands in the Table 
submenu, which is under "Format" in Mail Composer. It looks like the entire 
"Format" menu is hidden in Plain Text Mail Composer, but the command updating
is still occuring. Looking over the XUL, it's not clear to me why this is 
happening, but Mail Composer manages commands very differently than HTML Composer,
so I'll let Varada investigate that.

Comment 5

[Matthias Versen [:Matti]]

*** Bug 149552 has been marked as a duplicate of this bug. ***

Comment 6

[Andrew Schultz]

*** Bug 154518 has been marked as a duplicate of this bug. ***

Comment 7

[Andrew Schultz]

here's the problem:

goUpdateTableMenuItem in editor.js calls
editorShell.GetSelectedOrParentTableElement.  The problem is that
GetSelectedOrParentTableElement only works for HTML format and not plaintext
(why would there by a table in plaintext, eh?).  If the user composes in HTML,
this bug never shows up, but plaintext users will always see this.

One could argue that a plaintext composition window should never get into
goUpdateTableMenuItem, but it appears to be called directly from chrome (based
on Javascript Debugger, but I don't know how to figure out exactly where it's
coming from).  Fixing it at the source would be the best solution

but simply catch/trying the call to GetSelectedOrParentTableElement is
sufficient to prevent the errors from being generated.

Comment 8

[David G King]

NOTE: The redeclaration of MOZ_HELP_URI is covered in BUG #141481

Comment 9

[David G King]

*** Bug 154986 has been marked as a duplicate of this bug. ***

Comment 10

[Andrew Schultz]

this was fixed by bug 156918.  marking dupe because part of the stated purpose
of that bug was to handle javascript exceptions

*** This bug has been marked as a duplicate of 156918 ***

Comment 11

[Vedran Miletic]

v