1456706 - Low-hanging fruit in WebRTC web-platform-tests

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Doing a drive-by pass of some webrtc web-platform-tests for quick nits.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1456706 - Fix typo in RTCPeerConnection-setDescription-transceiver.html

Review commit: https://reviewboard.mozilla.org/r/239574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239574/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1456706 - Removed outdated cruft in RTCPeerConnection-constructor.html.ini

Review commit: https://reviewboard.mozilla.org/r/239576/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239576/

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Ended up filing an issue for a third one https://github.com/w3c/web-platform-tests/issues/10622

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8970802 [details]
Bug 1456706 - Fix typo in RTCPeerConnection-setDescription-transceiver.html

https://reviewboard.mozilla.org/r/239574/#review245388

LGTM

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8970803 [details]
Bug 1456706 - Removed outdated cruft in RTCPeerConnection-constructor.html.ini

https://reviewboard.mozilla.org/r/239576/#review245390

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cc2050e05c4
Fix typo in RTCPeerConnection-setDescription-transceiver.html r=drno
https://hg.mozilla.org/integration/autoland/rev/7c85700809ef
Removed outdated cruft in RTCPeerConnection-constructor.html.ini r=drno

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10999 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4cc2050e05c4
https://hg.mozilla.org/mozilla-central/rev/7c85700809ef

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged