Closed Bug 1461712 Opened 4 years ago Closed 4 years ago

Nit: some misleading helper names in WPT webrtc

Categories

(Core :: WebRTC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jib, Assigned: jib)

References

Details

Attachments

(1 file)

The webrtc WPT helpers assert_session_desc_equals() and assert_session_desc_not_equals() are misnomers, checking only type and number of m-lines.

https://searchfox.org/mozilla-central/rev/a85db9e29eb3f022dbaf8b9a6390ecbacf51e7dd/testing/web-platform/tests/webrtc/RTCPeerConnection-helper.js#96,101
Depends on: 1461563
Comment on attachment 8975847 [details]
Bug 1461712 - s/assert_session_desc_(not_)equals/assert_session_desc_(not_)similar/

https://reviewboard.mozilla.org/r/244042/#review250304

Wow, even "similar" is a stretch here...
Attachment #8975847 - Flags: review?(docfaraday) → review+
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14fb6876d996
s/assert_session_desc_(not_)equals/assert_session_desc_(not_)similar/ r=bwc
https://hg.mozilla.org/mozilla-central/rev/14fb6876d996
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11789 for changes under testing/web-platform/tests
You need to log in before you can comment on or make changes to this bug.