Closed Bug 1456813 Opened 2 years ago Closed 2 years ago

Rename the editContactOverlay to editContactPanel and prepare it to make it better looking with the dark theme

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement
Not set
normal

Tracking

(thunderbird60 fixed, thunderbird61 fixed)

RESOLVED FIXED
Thunderbird 61.0
Tracking Status
thunderbird60 --- fixed
thunderbird61 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

The edit contact panel has still the overlay in his name, although overlays are removed.
Rename the overlay to panel and style the edit fields that they are able to be styled by bug 1456819.

I leave the buttons as they are now. The FX editBookmarkPanel uses also the system buttons and it doesn't look very good with the dark theme.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8970860 - Flags: review?(jorgk)
Can you please describe the expected visual changes, if any.
The only visual change is that the textbox in the popup is no more native but custom styled. The change is almost not visible on Win 10. On Linux and Mac it looks now more like the gloda searchbox which is also not native.

Without the patch the email address in the popup is black with the dark theme. With the patch white.
Comment on attachment 8970860 [details] [diff] [review]
editContactPanel.patch

Looks OK, the address is indeed white now.
Attachment #8970860 - Flags: review?(jorgk) → review+
Thanks.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2cfdd560ac0a
Rename the editContactOverlay to editContactPanel and prepare it to make it better looking with the dark theme. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.