Rename the editContactOverlay to editContactPanel and prepare it to make it better looking with the dark theme

RESOLVED FIXED in Thunderbird 61.0

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 61.0

Thunderbird Tracking Flags

(thunderbird60 fixed, thunderbird61 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
The edit contact panel has still the overlay in his name, although overlays are removed.
Assignee

Comment 1

Last year
Rename the overlay to panel and style the edit fields that they are able to be styled by bug 1456819.

I leave the buttons as they are now. The FX editBookmarkPanel uses also the system buttons and it doesn't look very good with the dark theme.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8970860 - Flags: review?(jorgk)

Comment 2

Last year
Can you please describe the expected visual changes, if any.
Assignee

Comment 3

Last year
The only visual change is that the textbox in the popup is no more native but custom styled. The change is almost not visible on Win 10. On Linux and Mac it looks now more like the gloda searchbox which is also not native.

Without the patch the email address in the popup is black with the dark theme. With the patch white.

Comment 4

Last year
Comment on attachment 8970860 [details] [diff] [review]
editContactPanel.patch

Looks OK, the address is indeed white now.
Attachment #8970860 - Flags: review?(jorgk) → review+
Assignee

Comment 5

Last year
Thanks.
Keywords: checkin-needed

Comment 6

Last year
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2cfdd560ac0a
Rename the editContactOverlay to editContactPanel and prepare it to make it better looking with the dark theme. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.