1456813 - Rename the editContactOverlay to editContactPanel and prepare it to make it better looking with the dark theme

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Richard Marti (:Paenglab)]

The edit contact panel has still the overlay in his name, although overlays are removed.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: editContactPanel.patch

Rename the overlay to panel and style the edit fields that they are able to be styled by bug 1456819.

I leave the buttons as they are now. The FX editBookmarkPanel uses also the system buttons and it doesn't look very good with the dark theme.

Comment 2

[Jorg K (CEST = GMT+2)]

Can you please describe the expected visual changes, if any.

Comment 3

[Richard Marti (:Paenglab)]

The only visual change is that the textbox in the popup is no more native but custom styled. The change is almost not visible on Win 10. On Linux and Mac it looks now more like the gloda searchbox which is also not native.

Without the patch the email address in the popup is black with the dark theme. With the patch white.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8970860 [details] [diff] [review]
editContactPanel.patch

Looks OK, the address is indeed white now.

Comment 5

[Richard Marti (:Paenglab)]

Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2cfdd560ac0a
Rename the editContactOverlay to editContactPanel and prepare it to make it better looking with the dark theme. r=jorgk

Comment 7

[Jorg K (CEST = GMT+2)]

Beta (TB 60 beta 5):
https://hg.mozilla.org/releases/comm-beta/rev/c3e64abc3311a2c3475886d57b7f57f193c390e0