Closed
Bug 1458277
Opened 7 years ago
Closed 6 years ago
Remove unused old console .eslintignore entries
Categories
(DevTools :: Console, enhancement, P3)
DevTools
Console
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: ntim, Assigned: manishkk)
References
Details
Attachments
(1 file, 2 obsolete files)
810 bytes,
patch
|
nchevobbe
:
review+
|
Details | Diff | Splinter Review |
The old console was removed in bug 1381834, but the .eslintignore entries are still there:
https://dxr.mozilla.org/mozilla-central/source/.eslintignore#133-135
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → 1991manish.kumar
Comment 1•6 years ago
|
||
Hello Manish, are you blocked on something for this bug ?
Status: NEW → ASSIGNED
Flags: needinfo?(1991manish.kumar)
Priority: -- → P3
Assignee | ||
Comment 2•6 years ago
|
||
:nchevobbe
Hi, I have some interviews this week.
I assigned this bug to myself. I will work on the weekend.
Flags: needinfo?(1991manish.kumar)
Updated•6 years ago
|
Product: Firefox → DevTools
Reporter | ||
Comment 4•6 years ago
|
||
Comment on attachment 8985545 [details] [diff] [review]
Patch_Bug1458277
Review of attachment 8985545 [details] [diff] [review]:
-----------------------------------------------------------------
::: .eslintignore
@@ -130,4 @@
> # Soon to be removed
> devtools/client/webconsole/old/net/**
> devtools/client/webconsole/old/test/**
> -devtools/client/webconsole/old/webconsole.js
Seems like the link was out of date,
you should remove the `# Soon to be removed` lines and the ones starting with `devtools/client/webconsole/old/`
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(ntim.bugs)
Assignee | ||
Comment 5•6 years ago
|
||
Please review
Attachment #8985545 -
Attachment is obsolete: true
Flags: needinfo?(ntim.bugs)
Reporter | ||
Updated•6 years ago
|
Attachment #8985548 -
Flags: review?(nchevobbe)
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(ntim.bugs)
Comment 6•6 years ago
|
||
Comment on attachment 8985548 [details] [diff] [review]
PatchV2_Bug1458277
This looks good, thanks !
I pushed to TRY just to make sure everything is still right https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3948813b0ba8e50feb147c73dd5d05bac42b1e8
The only thing you need to change is to change the commit message to append "; r=nchevobbe" at the end of the line.
Attachment #8985548 -
Flags: review?(nchevobbe) → review+
Assignee | ||
Comment 7•6 years ago
|
||
Please review
Attachment #8985548 -
Attachment is obsolete: true
Flags: needinfo?(nchevobbe)
Updated•6 years ago
|
Attachment #8985756 -
Flags: review+
Comment 8•6 years ago
|
||
Comment on attachment 8985756 [details] [diff] [review]
New_Patch1458277
I applied it and everything looks fine. Let's land this patch.
Flags: needinfo?(nchevobbe)
Attachment #8985756 -
Flags: checkin+
Updated•6 years ago
|
Attachment #8985756 -
Flags: checkin+
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98323ed2610b
Remove unused old console .eslintignore entries; r=nchevobbe
Keywords: checkin-needed
Comment 10•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•