Closed Bug 1458277 Opened 2 years ago Closed 2 years ago

Remove unused old console .eslintignore entries

Categories

(DevTools :: Console, enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: ntim, Assigned: manishkk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

The old console was removed in bug 1381834, but the .eslintignore entries are still there:

https://dxr.mozilla.org/mozilla-central/source/.eslintignore#133-135
Assignee: nobody → 1991manish.kumar
Hello Manish, are you blocked on something for this bug ?
Status: NEW → ASSIGNED
Flags: needinfo?(1991manish.kumar)
Priority: -- → P3
:nchevobbe

Hi, I have some interviews this week.
I assigned this bug to myself. I will work on the weekend.
Flags: needinfo?(1991manish.kumar)
Product: Firefox → DevTools
Attached patch Patch_Bug1458277 (obsolete) — Splinter Review
Please review
Flags: needinfo?(ntim.bugs)
Comment on attachment 8985545 [details] [diff] [review]
Patch_Bug1458277

Review of attachment 8985545 [details] [diff] [review]:
-----------------------------------------------------------------

::: .eslintignore
@@ -130,4 @@
>  # Soon to be removed
>  devtools/client/webconsole/old/net/**
>  devtools/client/webconsole/old/test/**
> -devtools/client/webconsole/old/webconsole.js

Seems like the link was out of date,

you should remove the `# Soon to be removed` lines and the ones starting with `devtools/client/webconsole/old/`
Flags: needinfo?(ntim.bugs)
Attached patch PatchV2_Bug1458277 (obsolete) — Splinter Review
Please review
Attachment #8985545 - Attachment is obsolete: true
Flags: needinfo?(ntim.bugs)
Attachment #8985548 - Flags: review?(nchevobbe)
Flags: needinfo?(ntim.bugs)
Comment on attachment 8985548 [details] [diff] [review]
PatchV2_Bug1458277

This looks good, thanks !
I pushed to TRY just to make sure everything is still right https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3948813b0ba8e50feb147c73dd5d05bac42b1e8

The only thing you need to change is to change the commit message to append "; r=nchevobbe" at the end of the line.
Attachment #8985548 - Flags: review?(nchevobbe) → review+
Attached patch New_Patch1458277Splinter Review
Please review
Attachment #8985548 - Attachment is obsolete: true
Flags: needinfo?(nchevobbe)
Comment on attachment 8985756 [details] [diff] [review]
New_Patch1458277

I applied it and everything looks fine. Let's land this patch.
Flags: needinfo?(nchevobbe)
Attachment #8985756 - Flags: checkin+
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98323ed2610b
Remove unused old console .eslintignore entries; r=nchevobbe
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/98323ed2610b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.