Closed Bug 1381834 Opened 2 years ago Closed Last year

Remove old Console front-end

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: Honza, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Entire code base related to the old Console front-end including all preferences should be removed.

Honza
See also bug 1375778 comment #c8

Honza
Whiteboard: [console-html]
See also bug 1378850 comment #c8

Honza
Whiteboard: [console-html] → [console-html] [triage]
Flags: qe-verify?
Priority: -- → P3
Whiteboard: [console-html] [triage] → [reserve-console-html]
Flags: qe-verify? → qe-verify-
Priority: P3 → P4
Blocks: 1399837
Flags: qe-verify-
Priority: P4 → P2
Whiteboard: [reserve-console-html] → [newconsole-mvp]
Blocks: 1434860
Duplicate of this bug: 1395590
Depends on: 1347127
No longer blocks: 1434860
Depends on: 1434860
Whiteboard: [newconsole-mvp]
Depends on: 1304794
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8967444 [details]
Bug 1381834 - Remove old Console front-end;

https://reviewboard.mozilla.org/r/236114/#review242128

Looks good to me (and feel soooo good \o/)
I might have missed it, but I don't think we take care of the old frontend prefs (and the new frontend console and browserconsole) from devtools/client/preferences/devtools-client.js ?
Should we do it here or in a follow up ?
Attachment #8967444 - Flags: review?(nchevobbe) → review+
Should we clean devtools/shared/webconsole/server-logger-monitor.js and devtools/shared/webconsole/server-logger.js here ? 
Maybe a follow up would be better since I think there is some actor code
Thanks, I'll make follow ups for your suggestions
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 87a8961b7ee8dd8347e3c3b2b0da19281b001982 -d 40ab295f68f7: rebasing 457869:87a8961b7ee8 "Bug 1381834 - Remove old Console front-end;r=nchevobbe" (tip)
local [dest] changed devtools/client/webconsole/old/test/head.js which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
merging devtools/client/framework/toolbox-options.js
merging devtools/client/jar.mn
unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 934fb6223874bbbfe5c6755e9a302775f81bab84 -d 1cece7d5df17: rebasing 457871:934fb6223874 "Bug 1381834 - Remove old Console front-end;r=nchevobbe" (tip)
local [dest] changed devtools/client/webconsole/old/test/head.js which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
unresolved conflicts (see hg resolve, then hg rebase --continue)
Blocks: 1452424
Ah, this needs to land on top of Bug 1453712
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e71c12ebd74
Remove old Console front-end;r=nchevobbe
Blocks: 1454012
https://hg.mozilla.org/mozilla-central/rev/1e71c12ebd74
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Blocks: 1454419
Depends on: 1458277
Product: Firefox → DevTools
Depends on: 1525682
You need to log in before you can comment on or make changes to this bug.