1458658 - Unblock sites that are added

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P3)

Description

[Ed Lee :Mardak]

Similar to bug 735987 where unblock was added, activity stream has in-page UI to allow adding sites instead of drag/drop. Pinned links do get shown even when blocked, but when visited and unpinned, they go away.

Design thinks if we do this, bug 1432307 would be much lower priority as at least for top sites, the user has a way to "undo" by just adding the site back.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4204

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/c035e5130c94431293a298e7d9bd8b3a17c34842
Bug 1458658 - Unblock sites that are added if they were previously
blocked

https://github.com/mozilla/activity-stream/commit/688aaede6fc2d4bd37acd18595285052106b8de0
Merge pull request #4204 from sarracini/bug_1458658

Bug 1458658 - Unblock sites that are added if they were previously blocked

Comment 3

[Ursula Sarracini (:ursula)]

Oops, forgot to put 'Fix' in the commit message. This is fixed by https://github.com/mozilla/activity-stream/pull/4204. Closing this.

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9dcaad7a978f

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this something you're aiming at the 62 release? If so I'd like us to verify the fix before uplift.

Comment 6

[Ed Lee :Mardak]

This is an enhancement that missed 62. I don't think it needs to be uplifted.

Comment 7

[Patriciu Pop [:ppop], Ecosystem QA]

I have verified that this issue is no longer reproducible on Windows 10 x64 and Mac 10.13.3 on the Nightly Version 63.0a1, Build ID 20180702220046.
However, the issue is currently reproducible on Ubuntu 16.04 on the same version of Nightly.

After a visited a website that appeared naturally in the Top Sites section is dismissed, pinning it, visiting the website and unpinning causes it to disappear from the Top Sites section.
Considering this I will reopen the issue.

Comment 8

[David Olah]

I have verified the issue on Windows 10 and Ubuntu 18 on Nightly 63.0a1 (2018-07-16).
The issue is reproducing on each of the OSes.

Adding a new Top Site, opening it and then unpinning it makes it disappear from the Top Sites.

Comment 9

[Ed Lee :Mardak]

What's the top site you're trying to add? I could see the unblocking mechanism might have a slightly mismatched url, e.g., blocked https://www.mozilla.org/ but when adding a site, perhaps https is missing, or missing www, or missing the trailing slash -- all of which don't quite match the original url to unblock. I wonder if we should just try unblocking multiple similar urls just in case?

Comment 10

[David Olah]

I tried to add the following types of links and the issue is reproducing with all of them:

- https://www.emag.ro
- https://emag.ro
- www.emag.ro

Comment 11

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Using Patric's steps from comment 7, Ed's additional info about having slightly mismatching URLs, I have verified that the issue is no longer reproducible on Windows 10 x64, Mac 10.13.5 and Arch Linux x64.

STR on a clean new profile:
1. Add a website to the Top Sites section using its full URL. (eg https://www.imdb.com/)
2. Dismiss the Top Site.
3. Add the same website to the Top Sites section.
4. Open it in at least 2 new tabs.
5. Unpin the website.

@David, for the remaining issue, I suggest filing a new bug with your STR to enhance our unblocking mechanism.

Comment 12

[David Olah]

I created an issue also for the incomplete URLs. The issue is: Bug 1477709