Closed Bug 1459260 Opened Last year Closed 3 months ago

Allow APZ zooming without dom.meta-viewport.enabled

Categories

(Core :: Panning and Zooming, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: botond, Assigned: botond)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

Currently, APZ zooming requires dom.meta-viewport.enabled to be set.

However, meta viewport tags only really make sense on mobile, and we want to support zooming on desktop as well, so we'd like to remove this requirement.

In the absence of a meta viewport tag, the layout viewport would be sized to the device / browser window size.
(And the initial zoom level would be 1, modulo any device scale or full-zoom.)
No longer blocks: desktop-zoom
Assignee: nobody → botond

However, we continue to only respect a <meta name="viewport"> tag if
dom.meta-viewport.enabled is set.

Many tests only had it enabled because it was required for zooming to work on
desktop. This patch revises tests to only use it if they actually use a non-
default meta viewport tag.

The motivation is to bring test coverage closer to the platform defaults (so
on desktop, tests will run with dom.meta-viewport.enabled=false, and on Android
with dom.meta-viewport.enabled=true, matching the production scenarios).

Depends on D30988

Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db30d35f7130
Create a MobileViewportManager whenever apz.allow_zooming is set. r=kats
https://hg.mozilla.org/integration/autoland/rev/ab450513a156
Don't use dom.meta-viewport.enabled in tests that don't need it. r=kats
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.