Closed
Bug 1460005
Opened 7 years ago
Closed 7 years ago
PluginInstanceChild::InitImm32Hook needs to do better checking of AddHook results
Categories
(Core Graveyard :: Plug-ins, enhancement, P1)
Tracking
(firefox60 affected, firefox61 affected, firefox62 affected)
RESOLVED
WONTFIX
People
(Reporter: bugzilla, Assigned: jimm)
References
Details
(Whiteboard: inj+)
Attachments
(1 file)
|
1.90 KB,
patch
|
masayuki
:
review+
m_kato
:
review+
|
Details | Diff | Splinter Review |
If AddHook fails for some reason, we will repeatedly retry setting them every time a new plugin instance has been created.
|
Reporter | |
Updated•7 years ago
|
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → jmathies
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8976260 -
Flags: review?(masayuki)
|
|
Assignee | |
Updated•7 years ago
|
Priority: P3 → P1
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8976260 [details] [diff] [review]
patch v.1
It might be okay, but Makoto-san should review this. If there are some possible cases that we need to retry at least once, this breaks a lot in some environments.
Attachment #8976260 -
Flags: review?(masayuki)
Attachment #8976260 -
Flags: review?(m_kato)
Attachment #8976260 -
Flags: review+
|
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8976260 [details] [diff] [review]
patch v.1
Ah, but please declare sIMMHooksSet immediately before the if statement. It shouldn't be referred nor modified by other methods.
|
||
Updated•7 years ago
|
Attachment #8976260 -
Flags: review?(m_kato) → review+
|
|
Reporter | |
Comment 4•7 years ago
|
||
Now that bug 1460022 has landed, this is no longer needed.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•