Closed Bug 1460007 Opened 6 years ago Closed 6 years ago

PluginInstanceChild::HookSetWindowLongPtr needs to do better checking of AddHook results

Categories

(Core Graveyard :: Plug-ins, enhancement, P1)

Unspecified
Windows
enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bugzilla, Assigned: jimm)

References

Details

(Whiteboard: inj+)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1460005 +++ If AddHook fails for some reason, we will repeatedly retry setting them every time a new plugin instance has been created.
Priority: -- → P3
Whiteboard: inj+
Attached patch patchSplinter Review
Assignee: nobody → jmathies
Attachment #8976269 - Flags: review?(aklotz)
Priority: P3 → P1
Attachment #8976269 - Flags: review?(aklotz) → review+
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5ef0d3057ca7 Only call PluginInstanceChild's HookSetWindowLongPtr once. r=aklotz
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: